You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Patrick Hunt <ph...@apache.org> on 2011/12/10 01:10:10 UTC
So I don't lose track of this, ZK reviewboard script.
If you're using git to manage your patches locally this script is
super useful, it will upload reviews from the commandline, filling in
just about all the details. You do however need to use this slightly
modified version of rbtools
https://github.com/phunt/rbtools/commits/ro_reviewboard
(clone that repo, then checkout the ro_reviewboard branch)
Use the following script, replace <location of rbtools repo> with the
location of the repo you just cloned:
----- snip ----
#!/bin/bash
if [ $# -lt 2 ]; then
echo "Usage: zpost-review.sh rev-list JIRA# ...";
exit 1;
fi;
REVLIST=$1;
JIRA=$2
shift 2;
<location of rbtools repo>/rbtools/postreview.py
--repository-url="/home/reviewboard/zookeeper/.git"
--server="https://reviews.apache.org" --target-groups=zookeeper
--summary="$(git log --pretty=format:%s $REVLIST)"
--description="$(git whatchanged $REVLIST)" --diff-filename=<(git diff
--no-prefix $REVLIST) -o --bugs-closed=ZOOKEEPER-$JIRA $*
Patrick
Re: So I don't lose track of this, ZK reviewboard script.
Posted by Patrick Hunt <ph...@apache.org>.
I posted the one for svn as well:
https://github.com/phunt/apache-reviewboard-zk-svn
Not at slick as git but if you're using svn it's helpful.
Patrick
On Tue, Dec 13, 2011 at 11:30 AM, Patrick Hunt <ph...@apache.org> wrote:
> Infra updated the config on reviews.apache.org such that all you need
> is rbtools and my script, updated script repo here:
> https://github.com/phunt/apache-reviewboard-zk-git
>
> Patrick
>
> On Fri, Dec 9, 2011 at 4:17 PM, Patrick Hunt <ph...@apache.org> wrote:
>> Hrm, the script text got borked. that last section should all be on one line.
>>
>> I pushed it to github instead: (you still need the slightly modified
>> version of rbtools to make this work though)
>> https://github.com/phunt/apache-reviewboard-zk-git
>>
>> Patrick
>>
>> On Fri, Dec 9, 2011 at 4:10 PM, Patrick Hunt <ph...@apache.org> wrote:
>>> If you're using git to manage your patches locally this script is
>>> super useful, it will upload reviews from the commandline, filling in
>>> just about all the details. You do however need to use this slightly
>>> modified version of rbtools
>>> https://github.com/phunt/rbtools/commits/ro_reviewboard
>>> (clone that repo, then checkout the ro_reviewboard branch)
>>>
>>> Use the following script, replace <location of rbtools repo> with the
>>> location of the repo you just cloned:
>>>
>>> ----- snip ----
>>> #!/bin/bash
>>>
>>> if [ $# -lt 2 ]; then
>>> echo "Usage: zpost-review.sh rev-list JIRA# ...";
>>> exit 1;
>>> fi;
>>>
>>> REVLIST=$1;
>>> JIRA=$2
>>> shift 2;
>>>
>>> <location of rbtools repo>/rbtools/postreview.py
>>> --repository-url="/home/reviewboard/zookeeper/.git"
>>> --server="https://reviews.apache.org" --target-groups=zookeeper
>>> --summary="$(git log --pretty=format:%s $REVLIST)"
>>> --description="$(git whatchanged $REVLIST)" --diff-filename=<(git diff
>>> --no-prefix $REVLIST) -o --bugs-closed=ZOOKEEPER-$JIRA $*
>>>
>>>
>>> Patrick
Re: So I don't lose track of this, ZK reviewboard script.
Posted by Patrick Hunt <ph...@apache.org>.
Infra updated the config on reviews.apache.org such that all you need
is rbtools and my script, updated script repo here:
https://github.com/phunt/apache-reviewboard-zk-git
Patrick
On Fri, Dec 9, 2011 at 4:17 PM, Patrick Hunt <ph...@apache.org> wrote:
> Hrm, the script text got borked. that last section should all be on one line.
>
> I pushed it to github instead: (you still need the slightly modified
> version of rbtools to make this work though)
> https://github.com/phunt/apache-reviewboard-zk-git
>
> Patrick
>
> On Fri, Dec 9, 2011 at 4:10 PM, Patrick Hunt <ph...@apache.org> wrote:
>> If you're using git to manage your patches locally this script is
>> super useful, it will upload reviews from the commandline, filling in
>> just about all the details. You do however need to use this slightly
>> modified version of rbtools
>> https://github.com/phunt/rbtools/commits/ro_reviewboard
>> (clone that repo, then checkout the ro_reviewboard branch)
>>
>> Use the following script, replace <location of rbtools repo> with the
>> location of the repo you just cloned:
>>
>> ----- snip ----
>> #!/bin/bash
>>
>> if [ $# -lt 2 ]; then
>> echo "Usage: zpost-review.sh rev-list JIRA# ...";
>> exit 1;
>> fi;
>>
>> REVLIST=$1;
>> JIRA=$2
>> shift 2;
>>
>> <location of rbtools repo>/rbtools/postreview.py
>> --repository-url="/home/reviewboard/zookeeper/.git"
>> --server="https://reviews.apache.org" --target-groups=zookeeper
>> --summary="$(git log --pretty=format:%s $REVLIST)"
>> --description="$(git whatchanged $REVLIST)" --diff-filename=<(git diff
>> --no-prefix $REVLIST) -o --bugs-closed=ZOOKEEPER-$JIRA $*
>>
>>
>> Patrick
Re: So I don't lose track of this, ZK reviewboard script.
Posted by Patrick Hunt <ph...@apache.org>.
Hrm, the script text got borked. that last section should all be on one line.
I pushed it to github instead: (you still need the slightly modified
version of rbtools to make this work though)
https://github.com/phunt/apache-reviewboard-zk-git
Patrick
On Fri, Dec 9, 2011 at 4:10 PM, Patrick Hunt <ph...@apache.org> wrote:
> If you're using git to manage your patches locally this script is
> super useful, it will upload reviews from the commandline, filling in
> just about all the details. You do however need to use this slightly
> modified version of rbtools
> https://github.com/phunt/rbtools/commits/ro_reviewboard
> (clone that repo, then checkout the ro_reviewboard branch)
>
> Use the following script, replace <location of rbtools repo> with the
> location of the repo you just cloned:
>
> ----- snip ----
> #!/bin/bash
>
> if [ $# -lt 2 ]; then
> echo "Usage: zpost-review.sh rev-list JIRA# ...";
> exit 1;
> fi;
>
> REVLIST=$1;
> JIRA=$2
> shift 2;
>
> <location of rbtools repo>/rbtools/postreview.py
> --repository-url="/home/reviewboard/zookeeper/.git"
> --server="https://reviews.apache.org" --target-groups=zookeeper
> --summary="$(git log --pretty=format:%s $REVLIST)"
> --description="$(git whatchanged $REVLIST)" --diff-filename=<(git diff
> --no-prefix $REVLIST) -o --bugs-closed=ZOOKEEPER-$JIRA $*
>
>
> Patrick