You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/03/06 01:20:49 UTC
[GitHub] [incubator-dolphinscheduler] lgcareer opened a new pull request
#2096: update resource name also need update all the children full name
lgcareer opened a new pull request #2096: update resource name also need update all the children full name
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2096
## What is the purpose of the pull request
*update resource name also need update all the children full name*
## Brief change log
*update resource name also need update all the children full name*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#2096: update resource name also need update all the children full name
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #2096: update resource name also need update all the children full name
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2096#issuecomment-595551229
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2096&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2096&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2096&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2096&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2096&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2096&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2096&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2096&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2096&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2096&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2096&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2096&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2096&metric=duplicated_lines_density&view=list) No Duplication information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#2096: update resource name also need update all the children full name
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2096: update resource name also need update all the children full name
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2096#issuecomment-595547619
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096?src=pr&el=h1) Report
> Merging [#2096](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096?src=pr&el=desc) into [dev-resource-tree](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1a722c8646ca21af082d17c7cf88ba884859fe58?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev-resource-tree #2096 +/- ##
=======================================================
+ Coverage 24.43% 24.44% +<.01%
- Complexity 1317 1318 +1
=======================================================
Files 317 317
Lines 16903 16914 +11
Branches 2085 2086 +1
=======================================================
+ Hits 4130 4134 +4
- Misses 12311 12318 +7
Partials 462 462
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh) | `60.45% <18.18%> (-0.9%)` | `66 <0> (ø)` | |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `74.57% <0%> (+3.38%)` | `13% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096?src=pr&el=footer). Last update [1a722c8...031a122](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #2096:
update resource name also need update all the children full name
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2096: update resource name also need update all the children full name
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2096#issuecomment-595547619
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096?src=pr&el=h1) Report
> Merging [#2096](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096?src=pr&el=desc) into [dev-resource-tree](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1a722c8646ca21af082d17c7cf88ba884859fe58?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev-resource-tree #2096 +/- ##
=======================================================
+ Coverage 24.43% 24.44% +<.01%
- Complexity 1317 1318 +1
=======================================================
Files 317 317
Lines 16903 16914 +11
Branches 2085 2086 +1
=======================================================
+ Hits 4130 4134 +4
- Misses 12311 12318 +7
Partials 462 462
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...dolphinscheduler/api/service/ResourcesService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUmVzb3VyY2VzU2VydmljZS5qYXZh) | `60.45% <18.18%> (-0.9%)` | `66 <0> (ø)` | |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `74.57% <0%> (+3.38%)` | `13% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096?src=pr&el=footer). Last update [1a722c8...031a122](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2096?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #2096:
update resource name also need update all the children full name
Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #2096: update resource name also need update all the children full name
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2096
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services