You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Peter Bacsko via Review Board <no...@reviews.apache.org> on 2018/09/04 12:05:28 UTC
Re: Review Request 67885: POC: OOZIE-3160 PriorityDelayQueue
put()/take() can cause significant CPU load due to busy waiting
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67885/
-----------------------------------------------------------
(Updated szept. 4, 2018, 12:05 du)
Review request for oozie, András Piros, Peter Cseh, Kinga Marton, and Robert Kanter.
Changes
-------
Addressed comments of Sala
Repository: oozie-git
Description
-------
See upstream JIRA for details
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java PRE-CREATION
core/src/main/java/org/apache/oozie/service/CallableQueueService.java ef8d58da5
core/src/main/java/org/apache/oozie/util/PriorityDelayQueue.java 75c20698c
core/src/main/resources/oozie-default.xml b69d2c9aa
core/src/test/java/org/apache/oozie/service/TestAsyncXCommandExecutor.java PRE-CREATION
core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 9c2a11d6f
Diff: https://reviews.apache.org/r/67885/diff/9/
Changes: https://reviews.apache.org/r/67885/diff/8-9/
Testing
-------
1. Executed TestCallableQueueService which passed completely.
2. New unit tests for ASyncXCommandExecutor.
3. Tried it on a 3-node cluster
Thanks,
Peter Bacsko
Re: Review Request 67885: POC: OOZIE-3160 PriorityDelayQueue
put()/take() can cause significant CPU load due to busy waiting
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67885/#review208310
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java
Lines 1 (patched)
<https://reviews.apache.org/r/67885/#comment292140>
Apache 2.0 license header missing.
core/src/main/java/org/apache/oozie/service/CallableQueueService.java
Lines 562 (patched)
<https://reviews.apache.org/r/67885/#comment292142>
Typo: `by looking at the`
core/src/test/java/org/apache/oozie/service/TestAsyncXCommandExecutor.java
Lines 75 (patched)
<https://reviews.apache.org/r/67885/#comment292143>
Remove newline
- András Piros
On Sept. 4, 2018, 12:05 p.m., Peter Bacsko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67885/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2018, 12:05 p.m.)
>
>
> Review request for oozie, András Piros, Peter Cseh, Kinga Marton, and Robert Kanter.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See upstream JIRA for details
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java PRE-CREATION
> core/src/main/java/org/apache/oozie/service/CallableQueueService.java ef8d58da5
> core/src/main/java/org/apache/oozie/util/PriorityDelayQueue.java 75c20698c
> core/src/main/resources/oozie-default.xml b69d2c9aa
> core/src/test/java/org/apache/oozie/service/TestAsyncXCommandExecutor.java PRE-CREATION
> core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 9c2a11d6f
>
>
> Diff: https://reviews.apache.org/r/67885/diff/9/
>
>
> Testing
> -------
>
> 1. Executed TestCallableQueueService which passed completely.
> 2. New unit tests for ASyncXCommandExecutor.
> 3. Tried it on a 3-node cluster
>
>
> Thanks,
>
> Peter Bacsko
>
>
Re: Review Request 67885: OOZIE-3160 PriorityDelayQueue put()/take()
can cause significant CPU load due to busy waiting
Posted by Peter Bacsko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67885/
-----------------------------------------------------------
(Updated szept. 5, 2018, 11:59 de)
Review request for oozie, András Piros, Peter Cseh, Kinga Marton, and Robert Kanter.
Changes
-------
Re-adding FB annotations
Repository: oozie-git
Description
-------
See upstream JIRA for details
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java PRE-CREATION
core/src/main/java/org/apache/oozie/service/CallableQueueService.java ef8d58da5
core/src/main/java/org/apache/oozie/util/PriorityDelayQueue.java 75c20698c
core/src/main/resources/oozie-default.xml c354f0264
core/src/test/java/org/apache/oozie/service/TestAsyncXCommandExecutor.java PRE-CREATION
core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 9c2a11d6f
Diff: https://reviews.apache.org/r/67885/diff/11/
Changes: https://reviews.apache.org/r/67885/diff/10-11/
Testing
-------
1. Executed TestCallableQueueService which passed completely.
2. New unit tests for ASyncXCommandExecutor.
3. Tried it on a 3-node cluster
Thanks,
Peter Bacsko
Re: Review Request 67885: OOZIE-3160 PriorityDelayQueue put()/take()
can cause significant CPU load due to busy waiting
Posted by Peter Bacsko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67885/
-----------------------------------------------------------
(Updated szept. 5, 2018, 11:58 de)
Review request for oozie, András Piros, Peter Cseh, Kinga Marton, and Robert Kanter.
Changes
-------
Changed title (no longer POC)
Summary (updated)
-----------------
OOZIE-3160 PriorityDelayQueue put()/take() can cause significant CPU load due to busy waiting
Repository: oozie-git
Description
-------
See upstream JIRA for details
Diffs
-----
core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java PRE-CREATION
core/src/main/java/org/apache/oozie/service/CallableQueueService.java ef8d58da5
core/src/main/java/org/apache/oozie/util/PriorityDelayQueue.java 75c20698c
core/src/main/resources/oozie-default.xml b69d2c9aa
core/src/test/java/org/apache/oozie/service/TestAsyncXCommandExecutor.java PRE-CREATION
core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 9c2a11d6f
Diff: https://reviews.apache.org/r/67885/diff/10/
Testing
-------
1. Executed TestCallableQueueService which passed completely.
2. New unit tests for ASyncXCommandExecutor.
3. Tried it on a 3-node cluster
Thanks,
Peter Bacsko
Re: Review Request 67885: POC: OOZIE-3160 PriorityDelayQueue
put()/take() can cause significant CPU load due to busy waiting
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67885/#review208313
-----------------------------------------------------------
Ship it!
Ship It!
- András Piros
On Sept. 4, 2018, 3:45 p.m., Peter Bacsko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67885/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2018, 3:45 p.m.)
>
>
> Review request for oozie, András Piros, Peter Cseh, Kinga Marton, and Robert Kanter.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> See upstream JIRA for details
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java PRE-CREATION
> core/src/main/java/org/apache/oozie/service/CallableQueueService.java ef8d58da5
> core/src/main/java/org/apache/oozie/util/PriorityDelayQueue.java 75c20698c
> core/src/main/resources/oozie-default.xml b69d2c9aa
> core/src/test/java/org/apache/oozie/service/TestAsyncXCommandExecutor.java PRE-CREATION
> core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 9c2a11d6f
>
>
> Diff: https://reviews.apache.org/r/67885/diff/10/
>
>
> Testing
> -------
>
> 1. Executed TestCallableQueueService which passed completely.
> 2. New unit tests for ASyncXCommandExecutor.
> 3. Tried it on a 3-node cluster
>
>
> Thanks,
>
> Peter Bacsko
>
>
Re: Review Request 67885: POC: OOZIE-3160 PriorityDelayQueue
put()/take() can cause significant CPU load due to busy waiting
Posted by Peter Bacsko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67885/
-----------------------------------------------------------
(Updated szept. 4, 2018, 3:45 du)
Review request for oozie, András Piros, Peter Cseh, Kinga Marton, and Robert Kanter.
Changes
-------
Final changes
Repository: oozie-git
Description
-------
See upstream JIRA for details
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java PRE-CREATION
core/src/main/java/org/apache/oozie/service/CallableQueueService.java ef8d58da5
core/src/main/java/org/apache/oozie/util/PriorityDelayQueue.java 75c20698c
core/src/main/resources/oozie-default.xml b69d2c9aa
core/src/test/java/org/apache/oozie/service/TestAsyncXCommandExecutor.java PRE-CREATION
core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 9c2a11d6f
Diff: https://reviews.apache.org/r/67885/diff/10/
Changes: https://reviews.apache.org/r/67885/diff/9-10/
Testing
-------
1. Executed TestCallableQueueService which passed completely.
2. New unit tests for ASyncXCommandExecutor.
3. Tried it on a 3-node cluster
Thanks,
Peter Bacsko
Re: Review Request 67885: POC: OOZIE-3160 PriorityDelayQueue
put()/take() can cause significant CPU load due to busy waiting
Posted by Peter Bacsko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67885/
-----------------------------------------------------------
(Updated szept. 4, 2018, 3:42 du)
Review request for oozie, András Piros, Peter Cseh, Kinga Marton, and Robert Kanter.
Repository: oozie-git
Description
-------
See upstream JIRA for details
Diffs
-----
core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java PRE-CREATION
core/src/main/java/org/apache/oozie/service/CallableQueueService.java ef8d58da5
core/src/main/java/org/apache/oozie/util/PriorityDelayQueue.java 75c20698c
core/src/main/resources/oozie-default.xml b69d2c9aa
core/src/test/java/org/apache/oozie/service/TestAsyncXCommandExecutor.java PRE-CREATION
core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 9c2a11d6f
Diff: https://reviews.apache.org/r/67885/diff/9/
Testing
-------
1. Executed TestCallableQueueService which passed completely.
2. New unit tests for ASyncXCommandExecutor.
3. Tried it on a 3-node cluster
Thanks,
Peter Bacsko