You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Timothy Bish (JIRA)" <ji...@apache.org> on 2011/07/07 01:09:16 UTC
[jira] [Resolved] (AMQ-3012) HttpTunnelServlet incorrectly swallows
exceptions during transport creation.
[ https://issues.apache.org/jira/browse/AMQ-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish resolved AMQ-3012.
-------------------------------
Resolution: Fixed
Fix Version/s: 5.6.0
Patch applied, thanks!
> HttpTunnelServlet incorrectly swallows exceptions during transport creation.
> ----------------------------------------------------------------------------
>
> Key: AMQ-3012
> URL: https://issues.apache.org/jira/browse/AMQ-3012
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
> Affects Versions: 5.4.1
> Reporter: Stirling Chow
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: patch.txt
>
>
> Symptom
> =======
> org.apache.activemq.transport.http.HttpTunnelServlet.java contains the following logic:
> protected BlockingQueueTransport createTransportChannel(HttpServletRequest request, HttpServletResponse response) throws IOException {
> ...
> clients.put(clientID, answer);
> Transport transport = answer;
> try {
> HashMap options = new HashMap(transportOptions);
> transport = transportFactory.serverConfigure(answer, null, options);
> } catch (Exception e) {
> IOExceptionSupport.create(e);
> }
> If the call to transportFactory.serverConfigure(...) throws an exception, IOExceptionSupport.create(e) is called, which wraps the exception in an IOException, but that IOException is never thrown.
> Solution
> =======
> See attached patch file. Add a "throw" clause to propagate the IOException.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira