You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/12 13:41:12 UTC
[GitHub] [pulsar] poorbarcode opened a new issue, #15134: Remove useless code to reduce confusion
poorbarcode opened a new issue, #15134:
URL: https://github.com/apache/pulsar/issues/15134
**Describe the bug**
https://github.com/apache/pulsar/blob/46baae6a5e89a5feed171d231b59042a2ce9e1f8/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java#L325-L355
L343 - L345 & L349-L351
It looks like unnecessary
this method `doCumulativeAckAsync(messageId, bitSet)` only update variable `lastCumulativeAck`, will not change `pendingIndividualBatchIndexAcks`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode closed issue #15134: Remove useless code to reduce confusion
Posted by GitBox <gi...@apache.org>.
poorbarcode closed issue #15134: Remove useless code to reduce confusion
URL: https://github.com/apache/pulsar/issues/15134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #15134: Remove useless code to reduce confusion
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #15134:
URL: https://github.com/apache/pulsar/issues/15134#issuecomment-1125588923
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #15134: Remove useless code to reduce confusion
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #15134:
URL: https://github.com/apache/pulsar/issues/15134#issuecomment-1153048033
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on issue #15134: Remove useless code to reduce confusion
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on issue #15134:
URL: https://github.com/apache/pulsar/issues/15134#issuecomment-1154970872
It has been fixed at https://github.com/apache/pulsar/pull/15877, so close this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org