You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/28 14:39:12 UTC

[GitHub] [kafka] sasukerui opened a new pull request #8741: KAFKA-9332 change how to get joinGroupTimeoutMs

sasukerui opened a new pull request #8741:
URL: https://github.com/apache/kafka/pull/8741


   rebalanceTimeoutMs + 5000 is always greater than rebalanceTimeoutMs


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji closed pull request #8741: KAFKA-9332 change how to get joinGroupTimeoutMs

Posted by GitBox <gi...@apache.org>.
hachikuji closed pull request #8741:
URL: https://github.com/apache/kafka/pull/8741


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on a change in pull request #8741: KAFKA-9332 change how to get joinGroupTimeoutMs

Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #8741:
URL: https://github.com/apache/kafka/pull/8741#discussion_r432864242



##########
File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -519,7 +519,7 @@ public void onFailure(RuntimeException e) {
         // Note that we override the request timeout using the rebalance timeout since that is the
         // maximum time that it may block on the coordinator. We add an extra 5 seconds for small delays.
 
-        int joinGroupTimeoutMs = Math.max(rebalanceTimeoutMs, rebalanceTimeoutMs + 5000);
+        int joinGroupTimeoutMs = rebalanceTimeoutMs + 5000;

Review comment:
       The previous code handles overflow.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji commented on pull request #8741: KAFKA-9332 change how to get joinGroupTimeoutMs

Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #8741:
URL: https://github.com/apache/kafka/pull/8741#issuecomment-640281800


   Thanks for the patch. I'm going to close this since the code was changed separately. I don't think there's a strong reason to port the change back to 2.0, but let us know if there is a specific reason why it's necessary. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji commented on a change in pull request #8741: KAFKA-9332 change how to get joinGroupTimeoutMs

Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #8741:
URL: https://github.com/apache/kafka/pull/8741#discussion_r436402832



##########
File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -519,7 +519,7 @@ public void onFailure(RuntimeException e) {
         // Note that we override the request timeout using the rebalance timeout since that is the
         // maximum time that it may block on the coordinator. We add an extra 5 seconds for small delays.
 
-        int joinGroupTimeoutMs = Math.max(rebalanceTimeoutMs, rebalanceTimeoutMs + 5000);
+        int joinGroupTimeoutMs = rebalanceTimeoutMs + 5000;

Review comment:
       I think the original code was unintentional. We changed it in #8702 to the following:
   ```scala
           int joinGroupTimeoutMs = Math.max(client.defaultRequestTimeoutMs(),
               rebalanceConfig.rebalanceTimeoutMs + JOIN_GROUP_TIMEOUT_LAPSE);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org