You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/12/02 10:36:11 UTC

[GitHub] [geode-native] albertogpz commented on pull request #697: Feature/asio

albertogpz commented on pull request #697:
URL: https://github.com/apache/geode-native/pull/697#issuecomment-737143846


   > @albertogpz Despite it's terrible name, `doIfDestroyNotPending` ends a race condition where code tries to access the cache after it was destroyed. It's a shame we apparently need to set max connections which is only available from the distributed system when we close connections. This could cause a segfault during client shutdown.
   
   Thanks @mreddington .
   @pdxcodemonkey , I have pushed a new commit to see if removing the need to use that method (and the use itself) in `TcrEndpoint::closeConnections()`, fixes the possible deadlock. I do not have a RHEL7 environment so I cannot verify if this change fixes anything. Could you please test it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org