You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "K-handle-Y (via GitHub)" <gi...@apache.org> on 2025/10/20 07:03:22 UTC
[PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
K-handle-Y opened a new pull request, #57144:
URL: https://github.com/apache/doris/pull/57144
### What problem does this PR solve?
Related PR: #48203
Problem Summary: support simple sql function for factorial(from Hive)
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [x] Yes.(link coming soon) <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb merged PR #57144:
URL: https://github.com/apache/doris/pull/57144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57144:
URL: https://github.com/apache/doris/pull/57144#issuecomment-3510284793
<details>
<summary>TPC-DS: <b>Total hot run time: 188233 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 20f4de1c88b0c07ad4872900829b325ebb9500aa, data reload: false
query1 1040 407 394 394
query2 6587 1709 1720 1709
query3 6760 229 227 227
query4 26423 23928 23233 23233
query5 4407 640 485 485
query6 371 262 242 242
query7 4649 507 308 308
query8 319 276 274 274
query9 8685 2591 2584 2584
query10 480 341 283 283
query11 15544 15098 14894 14894
query12 189 117 116 116
query13 1673 554 439 439
query14 11313 9226 9237 9226
query15 212 188 171 171
query16 7669 682 511 511
query17 1230 781 616 616
query18 2030 414 316 316
query19 217 207 177 177
query20 132 126 121 121
query21 218 133 113 113
query22 3985 4129 4075 4075
query23 34015 32963 33082 32963
query24 8475 2435 2441 2435
query25 646 519 465 465
query26 1255 270 163 163
query27 2766 497 351 351
query28 4379 2180 2175 2175
query29 815 618 496 496
query30 308 227 197 197
query31 933 828 742 742
query32 84 80 74 74
query33 591 387 342 342
query34 795 844 521 521
query35 834 842 747 747
query36 970 1004 869 869
query37 115 111 84 84
query38 3556 3574 3489 3489
query39 1471 1445 1418 1418
query40 222 132 122 122
query41 68 62 61 61
query42 134 116 116 116
query43 496 512 461 461
query44 1226 757 739 739
query45 196 186 172 172
query46 881 998 659 659
query47 1752 1765 1727 1727
query48 405 422 332 332
query49 785 564 453 453
query50 653 686 417 417
query51 3907 3925 3942 3925
query52 120 112 105 105
query53 250 279 207 207
query54 334 315 299 299
query55 91 93 89 89
query56 364 358 331 331
query57 1214 1204 1115 1115
query58 303 288 286 286
query59 2616 2680 2539 2539
query60 373 364 358 358
query61 194 193 186 186
query62 825 772 704 704
query63 233 201 204 201
query64 4627 1311 995 995
query65 4045 3959 3982 3959
query66 1122 460 362 362
query67 15386 14979 15067 14979
query68 8308 949 606 606
query69 522 333 301 301
query70 1364 1309 1206 1206
query71 498 359 334 334
query72 5933 4872 4869 4869
query73 677 582 360 360
query74 9035 9248 8715 8715
query75 4005 3335 2818 2818
query76 3675 1156 730 730
query77 820 414 318 318
query78 9575 9648 8857 8857
query79 2533 843 608 608
query80 706 573 527 527
query81 495 259 244 244
query82 427 166 134 134
query83 298 267 257 257
query84 307 113 91 91
query85 913 494 437 437
query86 338 305 311 305
query87 3751 3741 3637 3637
query88 3316 2290 2241 2241
query89 392 339 306 306
query90 2068 233 228 228
query91 181 183 141 141
query92 91 68 62 62
query93 1599 1013 645 645
query94 703 447 350 350
query95 415 326 309 309
query96 487 581 286 286
query97 2934 2999 2848 2848
query98 249 239 210 210
query99 1464 1399 1309 1309
Total cold run time: 277042 ms
Total hot run time: 188233 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57144:
URL: https://github.com/apache/doris/pull/57144#issuecomment-3510979078
# BE Regression && UT Coverage Report
Increment line coverage `87.88% (29/33)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57144_20f4de1c88b0c07ad4872900829b325ebb9500aa_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57144_20f4de1c88b0c07ad4872900829b325ebb9500aa_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.45% (24258/33952) |
| Line Coverage | 57.96% (252402/435493) |
| Region Coverage | 53.38% (210712/394737) |
| Branch Coverage | 54.67% (89895/164423) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57144:
URL: https://github.com/apache/doris/pull/57144#issuecomment-3512519807
# FE Regression Coverage Report
Increment line coverage ` 93.75% (15/16)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57144_20f4de1c88b0c07ad4872900829b325ebb9500aa_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57144_20f4de1c88b0c07ad4872900829b325ebb9500aa_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #57144:
URL: https://github.com/apache/doris/pull/57144#issuecomment-3509972989
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #57144:
URL: https://github.com/apache/doris/pull/57144#discussion_r2444957719
##########
be/src/vec/functions/math.cpp:
##########
@@ -388,6 +388,70 @@ double csc(double x) {
}
using FunctionCosec = FunctionMathUnary<UnaryFunctionPlain<CscName, csc>>;
+static const Int64 FACT_TABLE[] = {
+ 1LL, 1LL, 2LL, 6LL, 24LL, 120LL, 720LL, 5040LL, 40320LL, 362880LL, 3628800LL,
+ 39916800LL, 479001600LL, 6227020800LL, 87178291200LL, 1307674368000LL,
+ 20922789888000LL, 355687428096000LL, 6402373705728000LL,
+ 121645100408832000LL, 2432902008176640000LL
+};
+
+class FunctionFactorial : public IFunction {
+public:
+ static constexpr auto name = "factorial";
+ static FunctionPtr create() { return std::make_shared<FunctionFactorial>(); }
+
+private:
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ return make_nullable(std::make_shared<DataTypeInt64>());
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ uint32_t result, size_t input_rows_count) const override {
+ ColumnPtr int_col = block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
Review Comment:
no need to do this, we have framework to do for const
##########
be/src/vec/functions/math.cpp:
##########
@@ -388,6 +388,70 @@ double csc(double x) {
}
using FunctionCosec = FunctionMathUnary<UnaryFunctionPlain<CscName, csc>>;
+static const Int64 FACT_TABLE[] = {
+ 1LL, 1LL, 2LL, 6LL, 24LL, 120LL, 720LL, 5040LL, 40320LL, 362880LL, 3628800LL,
+ 39916800LL, 479001600LL, 6227020800LL, 87178291200LL, 1307674368000LL,
+ 20922789888000LL, 355687428096000LL, 6402373705728000LL,
+ 121645100408832000LL, 2432902008176640000LL
+};
+
+class FunctionFactorial : public IFunction {
+public:
+ static constexpr auto name = "factorial";
+ static FunctionPtr create() { return std::make_shared<FunctionFactorial>(); }
+
+private:
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ return make_nullable(std::make_shared<DataTypeInt64>());
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ uint32_t result, size_t input_rows_count) const override {
+ ColumnPtr int_col = block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+
+ const ColumnUInt8* input_null_map = nullptr;
+ if (int_col->is_nullable()) {
Review Comment:
ditto. we have framework for nullable input
##########
be/src/vec/functions/math.cpp:
##########
@@ -388,6 +388,70 @@ double csc(double x) {
}
using FunctionCosec = FunctionMathUnary<UnaryFunctionPlain<CscName, csc>>;
+static const Int64 FACT_TABLE[] = {
+ 1LL, 1LL, 2LL, 6LL, 24LL, 120LL, 720LL, 5040LL, 40320LL, 362880LL, 3628800LL,
+ 39916800LL, 479001600LL, 6227020800LL, 87178291200LL, 1307674368000LL,
+ 20922789888000LL, 355687428096000LL, 6402373705728000LL,
+ 121645100408832000LL, 2432902008176640000LL
+};
+
+class FunctionFactorial : public IFunction {
+public:
+ static constexpr auto name = "factorial";
+ static FunctionPtr create() { return std::make_shared<FunctionFactorial>(); }
+
+private:
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ return make_nullable(std::make_shared<DataTypeInt64>());
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ uint32_t result, size_t input_rows_count) const override {
+ ColumnPtr int_col = block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+
+ const ColumnUInt8* input_null_map = nullptr;
+ if (int_col->is_nullable()) {
+ const auto& nullable_col = static_cast<const ColumnNullable&>(*int_col);
+ int_col = nullable_col.get_nested_column_ptr();
+ input_null_map = static_cast<const ColumnUInt8*>(nullable_col.get_null_map_column_ptr().get());
+ }
+
+ const auto* data_col = check_and_get_column<ColumnInt64>(int_col.get());
+
+ if (!data_col) {
+ return Status::InvalidArgument("Illegal column {} of argument of function {}",
Review Comment:
should be InternalError for wrong type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57144:
URL: https://github.com/apache/doris/pull/57144#issuecomment-3510219578
<details>
<summary>TPC-H: <b>Total hot run time: 34195 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 20f4de1c88b0c07ad4872900829b325ebb9500aa, data reload: false
------ Round 1 ----------------------------------
q1 17601 5149 5018 5018
q2 2043 302 203 203
q3 10291 1364 747 747
q4 10235 943 382 382
q5 7474 2379 2331 2331
q6 186 172 135 135
q7 910 765 627 627
q8 9343 1298 1075 1075
q9 7025 5114 5191 5114
q10 6874 2239 1804 1804
q11 501 297 288 288
q12 347 374 235 235
q13 17787 3609 3100 3100
q14 235 233 220 220
q15 573 518 507 507
q16 1022 1024 942 942
q17 593 871 378 378
q18 7859 7100 6999 6999
q19 1078 963 565 565
q20 349 339 221 221
q21 3797 3212 2305 2305
q22 1096 1048 999 999
Total cold run time: 107219 ms
Total hot run time: 34195 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5110 5089 5095 5089
q2 257 329 231 231
q3 2184 2699 2299 2299
q4 1333 1811 1355 1355
q5 4174 4446 4557 4446
q6 226 178 137 137
q7 2060 2043 1860 1860
q8 2670 2597 2581 2581
q9 7441 7402 7367 7367
q10 3078 3251 2829 2829
q11 595 534 529 529
q12 667 781 610 610
q13 3591 4182 3250 3250
q14 294 306 279 279
q15 532 503 501 501
q16 1056 1185 1063 1063
q17 1183 1505 1421 1421
q18 8098 7906 7740 7740
q19 789 782 915 782
q20 1980 1999 1814 1814
q21 4785 4341 4305 4305
q22 1097 1040 1002 1002
Total cold run time: 53200 ms
Total hot run time: 51490 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57144:
URL: https://github.com/apache/doris/pull/57144#issuecomment-3510591299
# BE UT Coverage Report
Increment line coverage `87.88% (29/33)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/20f4de1c88b0c07ad4872900829b325ebb9500aa_20f4de1c88b0c07ad4872900829b325ebb9500aa/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/20f4de1c88b0c07ad4872900829b325ebb9500aa_20f4de1c88b0c07ad4872900829b325ebb9500aa/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.79% (18231/34538) |
| Line Coverage | 38.14% (165803/434773) |
| Region Coverage | 33.15% (129042/389216) |
| Branch Coverage | 33.88% (55334/163340) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57144:
URL: https://github.com/apache/doris/pull/57144#issuecomment-3510310279
<details>
<summary>ClickBench: <b>Total hot run time: 27.51 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 20f4de1c88b0c07ad4872900829b325ebb9500aa, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.05 0.05
query3 0.25 0.08 0.09
query4 1.61 0.11 0.11
query5 0.27 0.27 0.25
query6 1.17 0.64 0.65
query7 0.03 0.02 0.02
query8 0.06 0.05 0.04
query9 0.61 0.51 0.53
query10 0.58 0.58 0.58
query11 0.17 0.11 0.11
query12 0.15 0.12 0.13
query13 0.63 0.61 0.59
query14 1.00 1.00 0.99
query15 0.86 0.86 0.85
query16 0.39 0.39 0.38
query17 1.04 1.03 1.07
query18 0.22 0.20 0.20
query19 1.93 1.80 1.79
query20 0.02 0.01 0.01
query21 15.44 0.20 0.13
query22 5.05 0.07 0.05
query23 15.66 0.28 0.10
query24 3.10 1.17 0.43
query25 0.09 0.06 0.05
query26 0.14 0.14 0.14
query27 0.09 0.06 0.06
query28 4.52 1.17 0.93
query29 12.57 3.86 3.26
query30 0.28 0.14 0.11
query31 2.82 0.60 0.37
query32 3.24 0.56 0.48
query33 3.13 3.02 3.05
query34 15.86 5.17 4.58
query35 4.56 4.55 4.59
query36 0.67 0.50 0.49
query37 0.10 0.07 0.06
query38 0.06 0.04 0.04
query39 0.04 0.03 0.03
query40 0.18 0.15 0.14
query41 0.09 0.04 0.03
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 98.91 s
Total hot run time: 27.51 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57144:
URL: https://github.com/apache/doris/pull/57144#issuecomment-3509873469
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57144:
URL: https://github.com/apache/doris/pull/57144#issuecomment-3509873568
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
Posted by "K-handle-Y (via GitHub)" <gi...@apache.org>.
K-handle-Y commented on PR #57144:
URL: https://github.com/apache/doris/pull/57144#issuecomment-3508885620
> basically good! please also add some case:
>
> 1. factorial(column) which column is nullable and non-nullable
> 2. factorial(nullable(literal))
done. not sure if its ok. looking forward to ur review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57144:
URL: https://github.com/apache/doris/pull/57144#issuecomment-3512369633
# BE Regression && UT Coverage Report
Increment line coverage `87.88% (29/33)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57144_20f4de1c88b0c07ad4872900829b325ebb9500aa_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57144_20f4de1c88b0c07ad4872900829b325ebb9500aa_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.47% (24264/33952) |
| Line Coverage | 57.97% (252468/435493) |
| Region Coverage | 53.39% (210746/394737) |
| Branch Coverage | 54.69% (89918/164423) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #57144:
URL: https://github.com/apache/doris/pull/57144#issuecomment-3420834549
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org