[jira] [Commented] (ZOOKEEPER-2368) Client watches are not disconnected on close

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512558#comment-16512558 ] 

Hadoop QA commented on ZOOKEEPER-2368:
--------------------------------------

-1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1828//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1828//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1828//console

This message is automatically generated.

> Client watches are not disconnected on close
> --------------------------------------------
>
>                 Key: ZOOKEEPER-2368
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2368
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.4.0, 3.5.0
>            Reporter: Timothy Ward
>            Assignee: Timothy Ward
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.6.0, 3.5.5
>
>         Attachments: ZOOKEEPER-2368.patch
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> If I have a ZooKeeper client connected to an ensemble then obviously I can register watches. 
> If the client is disconnected (for example by a failing ensemble member) then I get a disconnection event for all of my watches. If, on the other hand, my client is closed then I *do not* get a disconnection event. This asymmetry makes it really hard to clear up properly when using the asynchronous API, as there is no way to "fail" data reads/updates when the client is closed.
> I believe that the correct behaviour should be for all watchers to receive a disconnection event when the client is closed. The watchers can then respond as appropriate, and can differentiate between a "server disconnect" and a "client disconnect" by checking the ZooKeeper#getState() method. 
> This would not be a breaking behaviour change as Watchers are already required to handle disconnection events.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)