You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/07 15:42:31 UTC
[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1715: chore: improve Route module
juzhiyuan opened a new pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] User Friendly
**What changes will this PR take into?**
- [x] Update Route List: added route Description
- [x] Update Route List: move advanced features into Dropdown
- [ ] Route Creator: added fields description & samples (**in progress**)
- [x] Route Creator: refactor Fields into smaller component
**Related issues**
None
**Checklist:**
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
**Screenshot**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#discussion_r609843613
##########
File path: web/src/pages/Route/locales/zh-CN.ts
##########
@@ -147,5 +145,22 @@ export default {
'page.route.tooltip.pluginOrchWithoutRedirect': '当步骤一中 重定向 选择为 启用 HTTPS 时，不可使用插件编排模式。',
'page.route.tabs.normalMode': '普通模式',
- 'page.route.tabs.orchestration': '插件编排'
+ 'page.route.tabs.orchestration': '插件编排',
+
+ 'page.route.list.description': '路由（Route）是请求的入口点，它定义了客户端请求与服务之间的匹配规则。路由可以与服务（Service）、上游（Upstream）关联，一个服务可对应一组路由，一个路由可以对应一个上游对象（一组后端服务节点），因此，每个匹配到路由的请求将被网关代理到路由绑定的上游服务中。',
Review comment:
`路由（Route）` -> `路由`
`服务（Service）`-> `服务`
`上游（Upstream）`->`上游`
this may be more pure Chinese
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#discussion_r610218430
##########
File path: web/src/pages/Route/List.tsx
##########
@@ -177,6 +181,121 @@ const Page: React.FC = () => {
});
};
+ const ListToolbar = () => {
+ const tools = [
+ {
+ name: formatMessage({ id: 'page.route.pluginTemplateConfig' }),
+ icon: <PlusOutlined />,
+ onClick: () => {
+ history.push('/plugin-template/list')
+ }
+ }, {
+ name: formatMessage({ id: 'component.global.data.editor' }),
+ icon: <PlusOutlined />,
+ onClick: () => {
+ setVisible(true);
+ setEditorMode('create');
+ setRawData({});
+ }
+ }, {
+ name: formatMessage({ id: 'page.route.button.importOpenApi' }),
+ icon: <ImportOutlined />,
+ onClick: () => {
+ setUploadFileList([]);
+ setShowImportModal(true);
+ }
+ }, {
+ name: formatMessage({ id: 'page.route.onlineDebug' }),
+ icon: <BugOutlined />,
+ onClick: () => {
+ setDebugDrawVisible(true)
+ }
+ }
+ ]
+
+ return (
+ <Dropdown overlay={<Menu>
+ {
+ tools.map(item => (
+ <Menu.Item key={item.name} onClick={item.onClick}>
+ {item.icon}
+ {item.name}
+ </Menu.Item>
+ ))
+ }
+ </Menu>}>
+ <Button type="dashed">
+ <DownOutlined /> {formatMessage({ id: "menu.advanced-feature" })}
+ </Button>
+ </Dropdown>
+ )
+ }
+
+ const RecordActionDropdown: React.FC<{ record: any }> = ({ record }) => {
+ const tools: {
+ name: string;
+ onClick: () => void;
+ icon?: ReactNode;
+ }[] = [
+ {
+ name: formatMessage({ id: 'component.global.view' }),
+ onClick: () => {
+ setId(record.id);
+ setRawData(omit(record, DELETE_FIELDS));
+ setVisible(true);
+ setEditorMode('update');
+ }
+ }, {
+ name: formatMessage({ id: 'component.global.duplicate' }),
+ onClick: () => {
+ history.push(`/routes/${record.id}/duplicate`)
+ }
+ }, {
+ name: formatMessage({ id: 'component.global.delete' }),
+ onClick: () => {
+ Modal.confirm({
+ type: "warning",
+ title: formatMessage({ id: 'component.global.popconfirm.title.delete' }),
+ content: (
+ <>
+ {formatMessage({ id: 'component.global.name' })} - {record.name}<br />
+ ID - {record.id}
+ </>
+ ),
+ onOk: () => {
+ remove(record.id!).then(() => {
+ handleTableActionSuccessResponse(
+ `${formatMessage({ id: 'component.global.delete' })} ${formatMessage({
+ id: 'menu.routes',
+ })} ${formatMessage({ id: 'component.status.success' })}`,
+ );
+ });
+ }
+ })
+ }
+ }
+ ]
+
+ return (
+ <Dropdown overlay={
+ <Menu>
+ {
+ tools.map(item => (
+ <Menu.Item key={item.name} onClick={item.onClick}>
+ {item.icon && item.icon}
+ {item.name}
+ </Menu.Item>
+ ))
+ }
+ </Menu>
+ }>
+ <Button type="dashed">
Review comment:
To keep the same effect, I just added buttons on the left :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#discussion_r609855805
##########
File path: web/src/pages/Route/List.tsx
##########
@@ -177,6 +181,121 @@ const Page: React.FC = () => {
});
};
+ const ListToolbar = () => {
+ const tools = [
+ {
+ name: formatMessage({ id: 'page.route.pluginTemplateConfig' }),
+ icon: <PlusOutlined />,
+ onClick: () => {
+ history.push('/plugin-template/list')
+ }
+ }, {
+ name: formatMessage({ id: 'component.global.data.editor' }),
+ icon: <PlusOutlined />,
+ onClick: () => {
+ setVisible(true);
+ setEditorMode('create');
+ setRawData({});
+ }
+ }, {
+ name: formatMessage({ id: 'page.route.button.importOpenApi' }),
+ icon: <ImportOutlined />,
+ onClick: () => {
+ setUploadFileList([]);
+ setShowImportModal(true);
+ }
+ }, {
+ name: formatMessage({ id: 'page.route.onlineDebug' }),
+ icon: <BugOutlined />,
+ onClick: () => {
+ setDebugDrawVisible(true)
+ }
+ }
+ ]
+
+ return (
+ <Dropdown overlay={<Menu>
+ {
+ tools.map(item => (
+ <Menu.Item key={item.name} onClick={item.onClick}>
+ {item.icon}
+ {item.name}
+ </Menu.Item>
+ ))
+ }
+ </Menu>}>
+ <Button type="dashed">
+ <DownOutlined /> {formatMessage({ id: "menu.advanced-feature" })}
+ </Button>
+ </Dropdown>
+ )
+ }
+
+ const RecordActionDropdown: React.FC<{ record: any }> = ({ record }) => {
+ const tools: {
+ name: string;
+ onClick: () => void;
+ icon?: ReactNode;
+ }[] = [
+ {
+ name: formatMessage({ id: 'component.global.view' }),
+ onClick: () => {
+ setId(record.id);
+ setRawData(omit(record, DELETE_FIELDS));
+ setVisible(true);
+ setEditorMode('update');
+ }
+ }, {
+ name: formatMessage({ id: 'component.global.duplicate' }),
+ onClick: () => {
+ history.push(`/routes/${record.id}/duplicate`)
+ }
+ }, {
+ name: formatMessage({ id: 'component.global.delete' }),
+ onClick: () => {
+ Modal.confirm({
+ type: "warning",
+ title: formatMessage({ id: 'component.global.popconfirm.title.delete' }),
+ content: (
+ <>
+ {formatMessage({ id: 'component.global.name' })} - {record.name}<br />
+ ID - {record.id}
+ </>
+ ),
+ onOk: () => {
+ remove(record.id!).then(() => {
+ handleTableActionSuccessResponse(
+ `${formatMessage({ id: 'component.global.delete' })} ${formatMessage({
+ id: 'menu.routes',
+ })} ${formatMessage({ id: 'component.status.success' })}`,
+ );
+ });
+ }
+ })
+ }
+ }
+ ]
+
+ return (
+ <Dropdown overlay={
+ <Menu>
+ {
+ tools.map(item => (
+ <Menu.Item key={item.name} onClick={item.onClick}>
+ {item.icon && item.icon}
+ {item.name}
+ </Menu.Item>
+ ))
+ }
+ </Menu>
+ }>
+ <Button type="dashed">
Review comment:
would it be better to add an arrow icon to the more button?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#issuecomment-815908391
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=h1) Report
> Merging [#1715](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=desc) (b4c5cf8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/82ab89e2f208eeca1e6f03d9dae885ee7e4b19d3?el=desc) (82ab89e) will **decrease** coverage by `19.74%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1715 +/- ##
===========================================
- Coverage 72.04% 52.29% -19.75%
===========================================
Files 132 38 -94
Lines 5687 2660 -3027
Branches 660 0 -660
===========================================
- Hits 4097 1391 -2706
+ Misses 1346 1081 -265
+ Partials 244 188 -56
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `52.29% <ø> (ø)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
| [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
| [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| ... and [111 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=footer). Last update [82ab89e...b4c5cf8](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#discussion_r609849106
##########
File path: web/src/pages/Route/components/Step1/ProxyRewrite.tsx
##########
@@ -154,88 +163,137 @@ const ProxyRewrite: React.FC<RouteModule.Step1PassProps> = ({ form, disabled })
}
};
- return (
- <PanelSection title={formatMessage({ id: 'page.route.panelSection.title.requestOverride' })}>
+ const SchemeComponent: React.FC = () => {
Review comment:
more clearly, love this enhancement❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#issuecomment-815608899
for other fields, I will send a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#issuecomment-816350553
> Frontend e2e test / Frontend e2e test (pull_request)
ci failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#discussion_r610215421
##########
File path: web/src/pages/Route/components/Step1/ProxyRewrite.tsx
##########
@@ -154,88 +163,137 @@ const ProxyRewrite: React.FC<RouteModule.Step1PassProps> = ({ form, disabled })
}
};
- return (
- <PanelSection title={formatMessage({ id: 'page.route.panelSection.title.requestOverride' })}>
+ const SchemeComponent: React.FC = () => {
Review comment:
thanks! It would be more clear than before!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#discussion_r610215333
##########
File path: web/src/pages/Route/locales/zh-CN.ts
##########
@@ -147,5 +145,22 @@ export default {
'page.route.tooltip.pluginOrchWithoutRedirect': '当步骤一中 重定向 选择为 启用 HTTPS 时，不可使用插件编排模式。',
'page.route.tabs.normalMode': '普通模式',
- 'page.route.tabs.orchestration': '插件编排'
+ 'page.route.tabs.orchestration': '插件编排',
+
+ 'page.route.list.description': '路由（Route）是请求的入口点，它定义了客户端请求与服务之间的匹配规则。路由可以与服务（Service）、上游（Upstream）关联，一个服务可对应一组路由，一个路由可以对应一个上游对象（一组后端服务节点），因此，每个匹配到路由的请求将被网关代理到路由绑定的上游服务中。',
Review comment:
Due to most the users don't know what's `路由` is (maybe due to Documentaion is not good for now), so I add `Route` with Chinese.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#issuecomment-816333691
Sure, because we have many text changes, need some time to fix them haha
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#issuecomment-815908391
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=h1) Report
> Merging [#1715](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=desc) (9bb5073) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/2c158a18f31d944fdf7f28727553bbf72f3198ce?el=desc) (2c158a1) will **decrease** coverage by `19.79%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 9bb5073 differs from pull request most recent head 110662e. Consider uploading reports for the commit 110662e to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1715 +/- ##
===========================================
- Coverage 72.08% 52.29% -19.80%
===========================================
Files 130 38 -92
Lines 5649 2660 -2989
Branches 648 0 -648
===========================================
- Hits 4072 1391 -2681
+ Misses 1333 1081 -252
+ Partials 244 188 -56
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `52.29% <ø> (ø)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
| [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
| [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
| [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
| [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| ... and [109 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=footer). Last update [2c158a1...110662e](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#issuecomment-816404581
debugging, 3 tests left.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#issuecomment-815908391
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=h1) Report
> Merging [#1715](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=desc) (b4c5cf8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/82ab89e2f208eeca1e6f03d9dae885ee7e4b19d3?el=desc) (82ab89e) will **decrease** coverage by `0.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1715 +/- ##
==========================================
- Coverage 72.04% 71.67% -0.37%
==========================================
Files 132 47 -85
Lines 5687 3128 -2559
Branches 660 0 -660
==========================================
- Hits 4097 2242 -1855
+ Misses 1346 643 -703
+ Partials 244 243 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `62.53% <ø> (+0.28%)` | :arrow_up: |
| backend-e2e-test-ginkgo | `49.39% <ø> (+0.35%)` | :arrow_up: |
| backend-unit-test | `52.29% <ø> (ø)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `86.74% <0.00%> (-1.21%)` | :arrow_down: |
| [.../components/PluginOrchestration/DrawPluginStyle.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vRHJhd1BsdWdpblN0eWxlLnRz) | | |
| [web/src/pages/PluginTemplate/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9DcmVhdGUudHN4) | | |
| [web/src/pages/Upstream/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9DcmVhdGUudHN4) | | |
| [web/src/pages/Upstream/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS90cmFuc2Zvcm0udHM=) | | |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | | |
| [web/src/pages/Dashboard/Dashboard.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9EYXNoYm9hcmQvRGFzaGJvYXJkLnRzeA==) | | |
| [web/src/pages/Dashboard/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9EYXNoYm9hcmQvc2VydmljZS50cw==) | | |
| [.../src/pages/User/components/LoginMethodPassword.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL2NvbXBvbmVudHMvTG9naW5NZXRob2RQYXNzd29yZC50c3g=) | | |
| [web/src/components/IconFont/IconFont.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0ljb25Gb250L0ljb25Gb250LnRzeA==) | | |
| ... and [71 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=footer). Last update [82ab89e...b4c5cf8](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#issuecomment-815908391
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=h1) Report
> Merging [#1715](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=desc) (b4c5cf8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/82ab89e2f208eeca1e6f03d9dae885ee7e4b19d3?el=desc) (82ab89e) will **decrease** coverage by `5.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1715 +/- ##
==========================================
- Coverage 72.04% 67.00% -5.04%
==========================================
Files 132 47 -85
Lines 5687 3128 -2559
Branches 660 0 -660
==========================================
- Hits 4097 2096 -2001
+ Misses 1346 776 -570
- Partials 244 256 +12
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `46.89% <ø> (-15.35%)` | :arrow_down: |
| backend-e2e-test-ginkgo | `?` | |
| backend-unit-test | `52.29% <ø> (ø)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `5.35% <0.00%> (-71.43%)` | :arrow_down: |
| [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `81.25% <0.00%> (-18.75%)` | :arrow_down: |
| [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `40.00% <0.00%> (-10.00%)` | :arrow_down: |
| [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `90.47% <0.00%> (-9.53%)` | :arrow_down: |
| [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `68.51% <0.00%> (-9.26%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `63.55% <0.00%> (-7.48%)` | :arrow_down: |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `71.42% <0.00%> (-7.35%)` | :arrow_down: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `67.53% <0.00%> (-5.76%)` | :arrow_down: |
| ... and [85 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=footer). Last update [82ab89e...b4c5cf8](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#issuecomment-815603545
This PR mainly contains changes about i18n key & added some fields description, no logic changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#issuecomment-816397483
yes, I'm fixing those CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#issuecomment-815908391
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=h1) Report
> Merging [#1715](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=desc) (9bb5073) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/2c158a18f31d944fdf7f28727553bbf72f3198ce?el=desc) (2c158a1) will **decrease** coverage by `4.20%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 9bb5073 differs from pull request most recent head 110662e. Consider uploading reports for the commit 110662e to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1715 +/- ##
==========================================
- Coverage 72.08% 67.88% -4.21%
==========================================
Files 130 47 -83
Lines 5649 3126 -2523
Branches 648 0 -648
==========================================
- Hits 4072 2122 -1950
+ Misses 1333 758 -575
- Partials 244 246 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-e2e-test | `?` | |
| backend-e2e-test-ginkgo | `48.62% <ø> (+0.12%)` | :arrow_up: |
| backend-unit-test | `52.29% <ø> (ø)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
| [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
| [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-8.83%)` | :arrow_down: |
| [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: |
| [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: |
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: |
| [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: |
| [web/src/pages/Route/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9zZXJ2aWNlLnRz) | | |
| ... and [76 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1715/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=footer). Last update [2c158a1...110662e](https://codecov.io/gh/apache/apisix-dashboard/pull/1715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1715: chore: improve Route module
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1715:
URL: https://github.com/apache/apisix-dashboard/pull/1715#issuecomment-815533464
As for Testcases, failed due to the `Text` change. Please review Text i18n & description first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org