You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/28 15:10:00 UTC
[jira] [Commented] (METRON-1798) Add mpack support for parser
aggregation
[ https://issues.apache.org/jira/browse/METRON-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631985#comment-16631985 ]
ASF GitHub Bot commented on METRON-1798:
----------------------------------------
GitHub user anandsubbu opened a pull request:
https://github.com/apache/metron/pull/1215
METRON-1798: Add mpack support for parser aggregation
## Contributor Comments
This pull request allows users to submit an aggregated parser topology.
## Testing Steps
1. Spin up full-dev.
2. Stop the "Metron Parsers" service so that existing parser topologies are killed/stopped.
3. Go to Ambari -> Metron -> Configs -> Parsers
4. Change the "Metron Parsers" value as: "bro,snort", "yaf (For example)
5. Save changes and restart the Metron Parsers service.
6. Go to Storm UI, and verify that the aggregated topologies viz. "bro__snort" and "yaf" are started.
## Testing Done
### 1. Full Dev
* Set the Metron Parsers value as "bro,snort.yaf" and restarted the service.
* A single aggregated topology is seen to be started:
* Verified stop 'Metron Parsers' service to check that the aggregated topology is stopped properly
* Verified restart 'Metron Parsers' service to check that the aggregated topology is restarted properly
### 2. Multi-node setup
* Set the Metron Parsers value as: "bro,snort,yaf","bro,yaf","snort,yaf",yaf,snort
* The appropriate aggregated and single topologies are started:
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anandsubbu/incubator-metron METRON-1798
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1215.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1215
----
commit 8aa7c77f9d99f987d2549f3f8eed3a72f09f8bb1
Author: Anand Subramanian <as...@...>
Date: 2018-09-28T14:56:18Z
Support parser aggregation
----
> Add mpack support for parser aggregation
> ----------------------------------------
>
> Key: METRON-1798
> URL: https://issues.apache.org/jira/browse/METRON-1798
> Project: Metron
> Issue Type: Task
> Reporter: Anand Subramanian
> Assignee: Anand Subramanian
> Priority: Major
>
> Support spawning of storm topologies if a user specifies an aggregated parser configuration at:
> Ambari -> Metron -> Configs -> Parsers -> "Metron Parsers"
>
> For example, specifying the following:
> "bro,snort,yaf", "snort,yaf", yaf
> should spawn an aggregated topology for first two, and a regular topology for the 'yaf'.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)