You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "alberto-art3ch (via GitHub)" <gi...@apache.org> on 2026/08/05 04:04:45 UTC
[PR] FINERACT-1932: modularization fineract-savings - Part I [fineract]
alberto-art3ch opened a new pull request, #6229:
URL: https://github.com/apache/fineract/pull/6229
## Description
Part I (this PR) — Moves 90 files out of fineract-provider into fineract-savings via pure git mv, with no package, path or logic changes, so no import anywhere in the repo is touched.
It unifies the split portfolio.interestratechart package (45 files: api, command, data, handler, service, starter) with the domain/incentive half that already lived in fineract-savings, and moves 45 more savings files (api 17, service 8, domain 7, data 4, four complete jobs 8, cob.savings 1).
Two build dependencies are added to fineract-savings: fineract-command (the interest rate chart handlers use the typed command framework) and spring-boot-starter-batch + spring-batch-integration (the savings scheduled jobs), matching how fineract-loan already declares them.
Part II (follow-up PR) — The remaining 101 movable files: 86 portfolio.savings.handler command handlers plus 15 savings/deposit business events; a further 47 files stay in fineract-provider for now because they depend on portfolio.account, ClientRepositoryWrapper/GroupRepositoryWrapper/StaffRepositoryWrapper, NoteRepository, or the bulkimport framework.
[FINERACT-1932](https://issues.apache.org/jira/browse/FINERACT-1932)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
- [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute).
- [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1932: modularization fineract-savings - Part I [fineract]
Posted by "alberto-art3ch (via GitHub)" <gi...@apache.org>.
alberto-art3ch commented on PR #6229:
URL: https://github.com/apache/fineract/pull/6229#issuecomment-6505442551
> @alberto-art3ch Please rebase onto the latest develop and resolve the conflicts.
PR rebased, conlicts solved, Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1932: modularization fineract-savings - Part I [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #6229:
URL: https://github.com/apache/fineract/pull/6229#issuecomment-6502016766
@alberto-art3ch Please rebase onto the latest develop and resolve the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1932: modularization fineract-savings - Part I [fineract]
Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic commented on PR #6229:
URL: https://github.com/apache/fineract/pull/6229#issuecomment-5188487502
I am all for cleaning up things... but this might affect 3 GSoC projects... do we have to do this right now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1932: modularization fineract-savings - Part I [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #6229:
URL: https://github.com/apache/fineract/pull/6229#issuecomment-5759938629
@alberto-art3ch Please rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1932: modularization fineract-savings - Part I [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #6229:
URL: https://github.com/apache/fineract/pull/6229#issuecomment-6238867455
@alberto-art3ch Please rebase onto the latest `develop` and resolve the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1932: modularization fineract-savings - Part I [fineract]
Posted by "alberto-art3ch (via GitHub)" <gi...@apache.org>.
alberto-art3ch commented on PR #6229:
URL: https://github.com/apache/fineract/pull/6229#issuecomment-5191623685
> I am all for cleaning up things... but this might affect 3 GSoC projects... do we have to do this right now?
@vidakovic We can wait for that, only which is the ETA to have the chance to get this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1932: modularization fineract-savings - Part I [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #6229:
URL: https://github.com/apache/fineract/pull/6229#issuecomment-5527052294
@alberto-art3ch @vidakovic Let me know once we can circle back to this, till i moved into draft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org