You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Eugene Koontz (JIRA)" <ji...@apache.org> on 2012/08/01 21:40:03 UTC

[jira] [Created] (ZOOKEEPER-1524) use more standard junit constructs "before/after" or "beforeclass/afterclass" in SaslAuthTest and SaslAuthFailTest rather than static blocks

Eugene Koontz created ZOOKEEPER-1524:
----------------------------------------

             Summary: use more standard junit constructs "before/after" or "beforeclass/afterclass" in SaslAuthTest and SaslAuthFailTest rather than static blocks
                 Key: ZOOKEEPER-1524
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1524
             Project: ZooKeeper
          Issue Type: Improvement
          Components: tests
            Reporter: Eugene Koontz
            Assignee: Eugene Koontz
            Priority: Minor


The following tests:

AuthTest.java
SaslAuthFailTest.java
SaslAuthDesignatedClientTest.java
SaslAuthFailDesignatedClientTest.java
SaslAuthMissingClientConfigTest.java
SaslAuthTest.java

use "static {..}" blocks to initialize system properties and files prior to the test runs. As Patrick points out in ZOOKEEPER-1503, we should instead use JUnit's @Before annotation:


http://junit.sourceforge.net/javadoc/org/junit/Before.html

rather than static blocks, to make our tests more consistent and easier to understand.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1524) use more standard junit annotation "@Before" in SaslXTests rather than static blocks

Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eugene Koontz updated ZOOKEEPER-1524:
-------------------------------------

    Summary: use more standard junit annotation "@Before" in SaslXTests rather than static blocks  (was: use more standard junit annotation "@Before" in SaslAuthTest and SaslAuthFailTest rather than static blocks)
    
> use more standard junit annotation "@Before" in SaslXTests rather than static blocks
> ------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1524
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1524
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: tests
>            Reporter: Eugene Koontz
>            Assignee: Eugene Koontz
>            Priority: Minor
>
> The following tests:
> AuthTest.java
> SaslAuthFailTest.java
> SaslAuthDesignatedClientTest.java
> SaslAuthFailDesignatedClientTest.java
> SaslAuthMissingClientConfigTest.java
> SaslAuthTest.java
> use "static {..}" blocks to initialize system properties and files prior to the test runs. As Patrick points out in ZOOKEEPER-1503, we should instead use JUnit's @Before annotation:
> http://junit.sourceforge.net/javadoc/org/junit/Before.html
> rather than static blocks, to make our tests more consistent and easier to understand.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (ZOOKEEPER-1524) use more standard junit annotation "@Before" in SaslAuthTest and SaslAuthFailTest rather than static blocks

Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eugene Koontz updated ZOOKEEPER-1524:
-------------------------------------

    Summary: use more standard junit annotation "@Before" in SaslAuthTest and SaslAuthFailTest rather than static blocks  (was: use more standard junit constructs "before/after" or "beforeclass/afterclass" in SaslAuthTest and SaslAuthFailTest rather than static blocks)
    
> use more standard junit annotation "@Before" in SaslAuthTest and SaslAuthFailTest rather than static blocks
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1524
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1524
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: tests
>            Reporter: Eugene Koontz
>            Assignee: Eugene Koontz
>            Priority: Minor
>
> The following tests:
> AuthTest.java
> SaslAuthFailTest.java
> SaslAuthDesignatedClientTest.java
> SaslAuthFailDesignatedClientTest.java
> SaslAuthMissingClientConfigTest.java
> SaslAuthTest.java
> use "static {..}" blocks to initialize system properties and files prior to the test runs. As Patrick points out in ZOOKEEPER-1503, we should instead use JUnit's @Before annotation:
> http://junit.sourceforge.net/javadoc/org/junit/Before.html
> rather than static blocks, to make our tests more consistent and easier to understand.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira