You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Steven Phung <st...@gmail.com> on 2014/05/02 08:44:55 UTC
Review Request 21008: Applied four space indents (PEP8) to Python Example
Frameworks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21008/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-779
https://issues.apache.org/jira/browse/MESOS-779
Repository: mesos-git
Description
-------
Updated two of the python example frameworks to have four space indents to be consistent with PEP8.
Diffs
-----
src/examples/python/test_executor.py f34ab3f
src/examples/python/test_framework.py deca48e
Diff: https://reviews.apache.org/r/21008/diff/
Testing
-------
make check
Thanks,
Steven Phung
Re: Review Request 21008: Applied four space indents (PEP8) to Python
Example Frameworks
Posted by Steven Phung <st...@gmail.com>.
> On May 2, 2014, 2:13 p.m., Till Toenshoff wrote:
> > Diff appears to be missing?
The diff is downloadable but for some reason it doesn't show up inline in the review request. I'm not sure why... I tried recreating the request to see if I could fix that but had no luck. I wonder if it has anything to do with the fact that these are only whitespace changes.
- Steven
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21008/#review42014
-----------------------------------------------------------
On May 2, 2014, 6:44 a.m., Steven Phung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21008/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 6:44 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-779
> https://issues.apache.org/jira/browse/MESOS-779
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated two of the python example frameworks to have four space indents to be consistent with PEP8.
>
>
> Diffs
> -----
>
> src/examples/python/test_executor.py f34ab3f
> src/examples/python/test_framework.py deca48e
>
> Diff: https://reviews.apache.org/r/21008/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Steven Phung
>
>
Re: Review Request 21008: Applied four space indents (PEP8) to Python
Example Frameworks
Posted by Till Toenshoff <to...@me.com>.
> On May 2, 2014, 2:13 p.m., Till Toenshoff wrote:
> > Diff appears to be missing?
>
> Steven Phung wrote:
> The diff is downloadable but for some reason it doesn't show up inline in the review request. I'm not sure why... I tried recreating the request to see if I could fix that but had no luck. I wonder if it has anything to do with the fact that these are only whitespace changes.
Yes, sorry - I should have checked the Diff-Download feature before commenting ;). So it is all there and your fix is fine with one little nit:
test_framework.py:52 We are exceeding 80 chars per line now, could you break that into two lines?
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21008/#review42014
-----------------------------------------------------------
On May 2, 2014, 6:44 a.m., Steven Phung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21008/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 6:44 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-779
> https://issues.apache.org/jira/browse/MESOS-779
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated two of the python example frameworks to have four space indents to be consistent with PEP8.
>
>
> Diffs
> -----
>
> src/examples/python/test_executor.py f34ab3f
> src/examples/python/test_framework.py deca48e
>
> Diff: https://reviews.apache.org/r/21008/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Steven Phung
>
>
Re: Review Request 21008: Applied four space indents (PEP8) to Python
Example Frameworks
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21008/#review42014
-----------------------------------------------------------
Diff appears to be missing?
- Till Toenshoff
On May 2, 2014, 6:44 a.m., Steven Phung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21008/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 6:44 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-779
> https://issues.apache.org/jira/browse/MESOS-779
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated two of the python example frameworks to have four space indents to be consistent with PEP8.
>
>
> Diffs
> -----
>
> src/examples/python/test_executor.py f34ab3f
> src/examples/python/test_framework.py deca48e
>
> Diff: https://reviews.apache.org/r/21008/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Steven Phung
>
>
Re: Review Request 21008: Applied four space indents (PEP8) to Python
Example Frameworks
Posted by Steven Phung <st...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21008/
-----------------------------------------------------------
(Updated May 2, 2014, 4:55 p.m.)
Review request for mesos.
Changes
-------
Wrapped the line in test_framework.py line that exceeded 80 characters, good catch.
Bugs: MESOS-779
https://issues.apache.org/jira/browse/MESOS-779
Repository: mesos-git
Description
-------
Updated two of the python example frameworks to have four space indents to be consistent with PEP8.
Diffs (updated)
-----
src/examples/python/test_executor.py f34ab3f
src/examples/python/test_framework.py deca48e
Diff: https://reviews.apache.org/r/21008/diff/
Testing
-------
make check
Thanks,
Steven Phung