[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #428: [Bug] Fix potential negative preAllocatedSize variable

[GitBox <gi...@apache.org>]

jerqi commented on code in PR #428:
URL: https://github.com/apache/incubator-uniffle/pull/428#discussion_r1050348301


##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -121,6 +124,11 @@ public ShuffleTaskManager(
     leakShuffleDataCheckExecutorService.scheduleAtFixedRate(
         () -> checkLeakShuffleData(), leakShuffleDataCheckInterval,
             leakShuffleDataCheckInterval, TimeUnit.MILLISECONDS);
+    this.triggerFlushExecutorService = Executors.newSingleThreadScheduledExecutor(
+            ThreadUtils.getThreadFactory("triggerShuffleBufferManagerFlush"));
+    triggerFlushExecutorService.scheduleAtFixedRate(

Review Comment:
   Is it only useful for tests?



##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -226,26 +227,21 @@ public void sendShuffleData(SendShuffleDataRequest req,
         return;
       }
       final long start = System.currentTimeMillis();
+      manager.markBufferInUse(requireBufferId);

Review Comment:
   The gc time of our server will be a little long. Will it increase the probability of this problem?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org