You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "ocket8888 (via GitHub)" <gi...@apache.org> on 2023/05/10 19:10:27 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7459: Traffic Portal v2 CDNs table page

ocket8888 commented on code in PR #7459:
URL: https://github.com/apache/trafficcontrol/pull/7459#discussion_r1190300559


##########
experimental/traffic-portal/src/app/api/cdn.service.ts:
##########
@@ -109,4 +109,16 @@ export class CDNService extends APIService {
 
 		return this.put<ResponseCDN>(`cdns/${id}`, body).toPromise();
 	}
+
+	/**
+	 * Queues or dequeues updates on a CDN's servers.
+	 *
+	 * @param cdn The CDN to queue or dequeue updates on.
+	 * @param action The action to perform on the CDN, either "queue" or "dequeue".
+	 */
+	public async queueCDNUpdates(cdn: ResponseCDN, action: "queue" | "dequeue"): Promise<CDNQueueResponse> {

Review Comment:
   Although I'm skeptical that such a thing can be done both easily and simpler, I would certainly welcome such a refactor if it can be done. But in the meantime, we shouldn't break the existing consistency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org