You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by smarthi <gi...@git.apache.org> on 2016/07/22 19:40:45 UTC

[GitHub] incubator-pirk pull request #19: PIRK-10: Upgrade and Enforce Java 8

GitHub user smarthi opened a pull request:

    https://github.com/apache/incubator-pirk/pull/19

    PIRK-10: Upgrade and Enforce Java 8

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/smarthi/incubator-pirk sundry

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-pirk/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19
    
----
commit 9d0c3de4e054f7a3ed2f612fd6106139bd941c71
Author: smarthi <sm...@apache.org>
Date:   2016-07-22T19:39:29Z

    PIRK-10: Upgrade and Enforce Java 8

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #19: PIRK-10: Upgrade and Enforce Java 8

Posted by tellison <gi...@git.apache.org>.
Github user tellison commented on the issue:

    https://github.com/apache/incubator-pirk/pull/19
  
    Hey Suneel, this PR seems to have way more than the Java 8 upgrade.  Was that your intention?
    
    There are a number of formatting changes that are contrary to the established project style, and import  statement rearrangements (maybe Eclispe vs. IntelliJ ordering war?), etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #19: PIRK-10: Upgrade and Enforce Java 8

Posted by tellison <gi...@git.apache.org>.
Github user tellison commented on the issue:

    https://github.com/apache/incubator-pirk/pull/19
  
    +1 (non-binding)
    
    There were other, non-formatting, changes in your original change.  I hope you'll submit them as a PR too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #19: PIRK-10: Upgrade and Enforce Java 8

Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:

    https://github.com/apache/incubator-pirk/pull/19
  
    @tellison yeah i slipped in a few other code cleanups as part of this. The formatting changes r the default from other apache projects, oops sorry about that didn't notice the formatting changes. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #19: PIRK-10: Upgrade and Enforce Java 8

Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:

    https://github.com/apache/incubator-pirk/pull/19
  
    +1 
    Thanks adding back in the rat check. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-pirk pull request #19: PIRK-10: Upgrade and Enforce Java 8

Posted by Andy LoPresto <al...@gmail.com>.
Just an FYI -- the difference between binding and non-binding votes only applies to release votes, in which a PMC member/committer (depending on the project) has a binding vote; all other contributors have a non-binding vote. 

For PR reviews, all committers and PMC members can simply offer a "+1" and it has the same effect. A committer so-inclined can comment and merge the PR as an atomic action; if the submitter is also a committer, sometimes another committer will review and +1 but leave the merge process to the submitter. 

Andy LoPresto
alopresto@apache.org
alopresto.apache@gmail.com
PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4  BACE 3C6E F65B 2F7D EF69

> On Jul 22, 2016, at 23:29, asfgit <gi...@git.apache.org> wrote:
> 
> Github user asfgit closed the pull request at:
> 
>    https://github.com/apache/incubator-pirk/pull/19
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---

[GitHub] incubator-pirk pull request #19: PIRK-10: Upgrade and Enforce Java 8

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-pirk/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-pirk issue #19: PIRK-10: Upgrade and Enforce Java 8

Posted by Tim Ellison <t....@gmail.com>.
On 24/07/16 00:16, Suneel Marthi wrote:
> The code may have to go thru another round of cleanup, for eg:
> 
> In Java7>  List<String> list = new ArrayList<>();
> In Java 8> List<String> list = new ArrayList();

That's one example of coding to Java 8 syntax and libraries, rather than
simply using Java 8.  I'm assuming that now we are requiring
Java 8, all the new features are fair game.

> Also, have been cautioned by the Beam folks about using Java 8 lambdas.
> Projects like Flink and others have a separate module for Java 8 lambda
> implementations.

What was the caution?

> Hence, I wasn't sure if we wanted to change <javac.target> to 1.8.
> 
> thoughts?

I'm for changing it to target Java 8.

Regards,
Tim

> On Sat, Jul 23, 2016 at 6:49 PM, Tim Ellison <t....@gmail.com> wrote:
> 
>> On 23/07/16 23:03, Suneel Marthi wrote:
>>> yeah, wasn't sure if we wanted to retain some Java 7 compatibility.
>>>
>>> Maybe retain <maven.compiler.target> as 1.7 still.
>>
>> What do you mean?  Upgrade and enforce Java 8, but only use Java 7
>> features?
>>
>> Regards,
>> Tim
>>
>>
>>> On Sat, Jul 23, 2016 at 6:00 PM, Tim Ellison <t....@gmail.com>
>> wrote:
>>>
>>>> On 23/07/16 03:54, smarthi wrote:
>>>>> Github user smarthi commented on the issue:
>>>>>
>>>>>     https://github.com/apache/incubator-pirk/pull/19
>>>>>
>>>>>     This is good to merge now. It enforces Java 8 and Maven 3.3.9 as
>>>> also RAT checks for license headers.
>>>>
>>>> Looks like there are still some vestiges of Java 7 in the pom.xml(s)
>>>> <properties>.  Presumably these should be fixed under this JIRA too.
>>>>
>>>>   <properties>
>>>>     <maven.compiler.source>1.7</maven.compiler.source>
>>>>     <maven.compiler.target>1.7</maven.compiler.target>
>>>>     <javac.target>1.7</javac.target>
>>>>   </properties>
>>>>
>>>> Regards,
>>>> Tim
>>>>
>>>
>>
> 

Re: [GitHub] incubator-pirk issue #19: PIRK-10: Upgrade and Enforce Java 8

Posted by Suneel Marthi <su...@gmail.com>.
The code may have to go thru another round of cleanup, for eg:

In Java7>  List<String> list = new ArrayList<>();
In Java 8> List<String> list = new ArrayList();

Also, have been cautioned by the Beam folks about using Java 8 lambdas.
Projects like Flink and others have a separate module for Java 8 lambda
implementations.

Hence, I wasn't sure if we wanted to change <javac.target> to 1.8.

thoughts?

On Sat, Jul 23, 2016 at 6:49 PM, Tim Ellison <t....@gmail.com> wrote:

> On 23/07/16 23:03, Suneel Marthi wrote:
> > yeah, wasn't sure if we wanted to retain some Java 7 compatibility.
> >
> > Maybe retain <maven.compiler.target> as 1.7 still.
>
> What do you mean?  Upgrade and enforce Java 8, but only use Java 7
> features?
>
> Regards,
> Tim
>
>
> > On Sat, Jul 23, 2016 at 6:00 PM, Tim Ellison <t....@gmail.com>
> wrote:
> >
> >> On 23/07/16 03:54, smarthi wrote:
> >>> Github user smarthi commented on the issue:
> >>>
> >>>     https://github.com/apache/incubator-pirk/pull/19
> >>>
> >>>     This is good to merge now. It enforces Java 8 and Maven 3.3.9 as
> >> also RAT checks for license headers.
> >>
> >> Looks like there are still some vestiges of Java 7 in the pom.xml(s)
> >> <properties>.  Presumably these should be fixed under this JIRA too.
> >>
> >>   <properties>
> >>     <maven.compiler.source>1.7</maven.compiler.source>
> >>     <maven.compiler.target>1.7</maven.compiler.target>
> >>     <javac.target>1.7</javac.target>
> >>   </properties>
> >>
> >> Regards,
> >> Tim
> >>
> >
>

Re: [GitHub] incubator-pirk issue #19: PIRK-10: Upgrade and Enforce Java 8

Posted by Tim Ellison <t....@gmail.com>.
On 23/07/16 23:03, Suneel Marthi wrote:
> yeah, wasn't sure if we wanted to retain some Java 7 compatibility.
> 
> Maybe retain <maven.compiler.target> as 1.7 still.

What do you mean?  Upgrade and enforce Java 8, but only use Java 7 features?

Regards,
Tim


> On Sat, Jul 23, 2016 at 6:00 PM, Tim Ellison <t....@gmail.com> wrote:
> 
>> On 23/07/16 03:54, smarthi wrote:
>>> Github user smarthi commented on the issue:
>>>
>>>     https://github.com/apache/incubator-pirk/pull/19
>>>
>>>     This is good to merge now. It enforces Java 8 and Maven 3.3.9 as
>> also RAT checks for license headers.
>>
>> Looks like there are still some vestiges of Java 7 in the pom.xml(s)
>> <properties>.  Presumably these should be fixed under this JIRA too.
>>
>>   <properties>
>>     <maven.compiler.source>1.7</maven.compiler.source>
>>     <maven.compiler.target>1.7</maven.compiler.target>
>>     <javac.target>1.7</javac.target>
>>   </properties>
>>
>> Regards,
>> Tim
>>
> 

Re: [GitHub] incubator-pirk issue #19: PIRK-10: Upgrade and Enforce Java 8

Posted by Suneel Marthi <su...@gmail.com>.
yeah, wasn't sure if we wanted to retain some Java 7 compatibility.

Maybe retain <maven.compiler.target> as 1.7 still.

On Sat, Jul 23, 2016 at 6:00 PM, Tim Ellison <t....@gmail.com> wrote:

> On 23/07/16 03:54, smarthi wrote:
> > Github user smarthi commented on the issue:
> >
> >     https://github.com/apache/incubator-pirk/pull/19
> >
> >     This is good to merge now. It enforces Java 8 and Maven 3.3.9 as
> also RAT checks for license headers.
>
> Looks like there are still some vestiges of Java 7 in the pom.xml(s)
> <properties>.  Presumably these should be fixed under this JIRA too.
>
>   <properties>
>     <maven.compiler.source>1.7</maven.compiler.source>
>     <maven.compiler.target>1.7</maven.compiler.target>
>     <javac.target>1.7</javac.target>
>   </properties>
>
> Regards,
> Tim
>

Re: [GitHub] incubator-pirk issue #19: PIRK-10: Upgrade and Enforce Java 8

Posted by Tim Ellison <t....@gmail.com>.
On 23/07/16 03:54, smarthi wrote:
> Github user smarthi commented on the issue:
> 
>     https://github.com/apache/incubator-pirk/pull/19
>   
>     This is good to merge now. It enforces Java 8 and Maven 3.3.9 as also RAT checks for license headers.

Looks like there are still some vestiges of Java 7 in the pom.xml(s)
<properties>.  Presumably these should be fixed under this JIRA too.

  <properties>
    <maven.compiler.source>1.7</maven.compiler.source>
    <maven.compiler.target>1.7</maven.compiler.target>
    <javac.target>1.7</javac.target>
  </properties>

Regards,
Tim

[GitHub] incubator-pirk issue #19: PIRK-10: Upgrade and Enforce Java 8

Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:

    https://github.com/apache/incubator-pirk/pull/19
  
    This is good to merge now. It enforces Java 8 and Maven 3.3.9 as also RAT checks for license headers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #19: PIRK-10: Upgrade and Enforce Java 8

Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:

    https://github.com/apache/incubator-pirk/pull/19
  
    This PR is good to go, The travis build now runs with maven 3.3.9 and Java 8. Disabled rat check temporarily to get past travis build failures.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #19: PIRK-10: Upgrade and Enforce Java 8

Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:

    https://github.com/apache/incubator-pirk/pull/19
  
    yeah, those other changes would be part of a bigger PR later. Thanks for ur
    feedback.
    
    On Fri, Jul 22, 2016 at 4:59 PM, Tim Ellison <no...@github.com>
    wrote:
    
    > +1 (non-binding)
    >
    > There were other, non-formatting, changes in your original change. I hope
    > you'll submit them as a PR too.
    >
    > \u2014
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/incubator-pirk/pull/19#issuecomment-234655111>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/AC_fopZudcoxzNrxve3GFqCNpwK0uE8sks5qYS89gaJpZM4JTEVW>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #19: PIRK-10: Upgrade and Enforce Java 8

Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:

    https://github.com/apache/incubator-pirk/pull/19
  
    @tellison please review. Also we need to remove the Java 7 jobs on travis after merging this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---