You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/23 19:51:23 UTC

[GitHub] [airflow] meftasadat commented on issue #6173: [AIRFLOW-5542] Added BQ query results export to GCS operator

meftasadat commented on issue #6173: [AIRFLOW-5542] Added BQ query results export to GCS  operator
URL: https://github.com/apache/airflow/pull/6173#issuecomment-534256723
 
 
   > I'm not really sure I get it...
   > 1- Why can't it be an addition to the existed BigQueryToCloudStorageOperator? Why the need for a new operator for this functionality?
   > 
   > 2 - If a new operator is required then why not reuse functionality that we already have? It can be achieved by using existed operators :
   > a. BigQueryOperator Runs query and save output to table
   > b. Export table to storage with BigQueryToCloudStorageOperator
   > c. delete table with BigQueryTableDeleteOperator
   > This is pretty much the logic you tried to implement here. By using existed operators which are tested there is less chance for bugs and less code to test and maintain.
   
   Thanks for reviewing this. I completely agree with you but the main motivation for the operator is to have less client-side code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services