You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2017/01/24 21:52:29 UTC

Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.


Repository: mesos


Description
-------

This is another test fix in the chain.


Diffs
-----

  src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 

Diff: https://reviews.apache.org/r/55893/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Guangya Liu <gy...@gmail.com>.

> On \u4e00\u6708 25, 2017, 9:55 a.m., Guangya Liu wrote:
> > @Yan, I posted some comments at https://reviews.apache.org/r/51027/ for this issue with some comments as:
> > 
> > ```
> > Jacob, regaring the test failure of OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable, I think that you can disable it as DISABLED_RescindRevocableOfferWithIncreasedRevocable in your patch, and I will fix this in /r/51621
> > 
> > I found that with current logic, it is difficult to handle this case, as we cannot make sure the complete order for allocator->updateSlave and allocator->recoverResources, if allocator->recoverResources finished first, then the offer will have 3 REV resources; if allocator->updateSlave finished first, then the offer will have 2 REV resources.
> > 
> > With /r/51621 , after we enable recoverResources allocate resources, we can always make sure we get 3 REV resources in the offer, so I propose that you disable the test case first and I will fix this after we enable allocate resources when recoverResoures.
> > ```
> > 
> > As I will have a patch for `allocate resources when recoverResoures`, so how about `disable` this test first and then I can fix this when my patch ready in https://reviews.apache.org/r/51621/ ?
> 
> Jiang Yan Xu wrote:
>     Hey Guangya I took a look at your fix in /r/51621/ but had a question, when `recoverResources()` also triggers allocations. it's true that we don't need `Clock::advance` to trigger a periodic allocation anymore but the race still exists, i.e., you don't know how many `Offers` events the scheduler is going to get, right? With my fix you won't need to care about the number of events since you really only care about the number/amount of offers (you eventually get). So I think this fix will work with your patch as well?

@Yan, you are right. Your fix can also help `allocate when recoverResources`, my fix in /r/51621/ is still flaky for this. Thanks.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review162929
-----------------------------------------------------------


On \u4e00\u6708 24, 2017, 9:52 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55893/
> -----------------------------------------------------------
> 
> (Updated \u4e00\u6708 24, 2017, 9:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is another test fix in the chain.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 
> 
> Diff: https://reviews.apache.org/r/55893/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Jiang Yan Xu <ya...@jxu.me>.

> On Jan. 25, 2017, 1:55 a.m., Guangya Liu wrote:
> > @Yan, I posted some comments at https://reviews.apache.org/r/51027/ for this issue with some comments as:
> > 
> > ```
> > Jacob, regaring the test failure of OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable, I think that you can disable it as DISABLED_RescindRevocableOfferWithIncreasedRevocable in your patch, and I will fix this in /r/51621
> > 
> > I found that with current logic, it is difficult to handle this case, as we cannot make sure the complete order for allocator->updateSlave and allocator->recoverResources, if allocator->recoverResources finished first, then the offer will have 3 REV resources; if allocator->updateSlave finished first, then the offer will have 2 REV resources.
> > 
> > With /r/51621 , after we enable recoverResources allocate resources, we can always make sure we get 3 REV resources in the offer, so I propose that you disable the test case first and I will fix this after we enable allocate resources when recoverResoures.
> > ```
> > 
> > As I will have a patch for `allocate resources when recoverResoures`, so how about `disable` this test first and then I can fix this when my patch ready in https://reviews.apache.org/r/51621/ ?

Hey Guangya I took a look at your fix in /r/51621/ but had a question, when `recoverResources()` also triggers allocations. it's true that we don't need `Clock::advance` to trigger a periodic allocation anymore but the race still exists, i.e., you don't know how many `Offers` events the scheduler is going to get, right? With my fix you won't need to care about the number of events since you really only care about the number/amount of offers (you eventually get). So I think this fix will work with your patch as well?


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review162929
-----------------------------------------------------------


On Jan. 24, 2017, 1:52 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55893/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2017, 1:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is another test fix in the chain.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 
> 
> Diff: https://reviews.apache.org/r/55893/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review162929
-----------------------------------------------------------



@Yan, I posted some comments at https://reviews.apache.org/r/51027/ for this issue with some comments as:

```
Jacob, regaring the test failure of OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable, I think that you can disable it as DISABLED_RescindRevocableOfferWithIncreasedRevocable in your patch, and I will fix this in /r/51621

I found that with current logic, it is difficult to handle this case, as we cannot make sure the complete order for allocator->updateSlave and allocator->recoverResources, if allocator->recoverResources finished first, then the offer will have 3 REV resources; if allocator->updateSlave finished first, then the offer will have 2 REV resources.

With /r/51621 , after we enable recoverResources allocate resources, we can always make sure we get 3 REV resources in the offer, so I propose that you disable the test case first and I will fix this after we enable allocate resources when recoverResoures.
```

As I will have a patch for `allocate resources when recoverResoures`, so how about `disable` this test first and then I can fix this when my patch ready in https://reviews.apache.org/r/51621/ ?

- Guangya Liu


On \u4e00\u6708 24, 2017, 9:52 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55893/
> -----------------------------------------------------------
> 
> (Updated \u4e00\u6708 24, 2017, 9:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is another test fix in the chain.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 
> 
> Diff: https://reviews.apache.org/r/55893/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Jiang Yan Xu <ya...@jxu.me>.

> On Jan. 26, 2017, 1:40 a.m., Guangya Liu wrote:
> > src/tests/oversubscription_tests.cpp, line 559
> > <https://reviews.apache.org/r/55893/diff/1/?file=1613785#file1613785line559>
> >
> >     How about following?
> >     
> >     ```
> >     // The latest resource estimate should match the total offered resources.
> >     ```
> >     
> >     This can also make the comments match `resources2 and resources3`.

You mean match `EXPECT_EQ(resources2, resources3);`?

So with `EXPECT_EQ`, the signature is `EXPECT_EQ(expected, actual);` so its indeed resources3 (offered resources, actual) matches resources2 (the estimate, expected).


> On Jan. 26, 2017, 1:40 a.m., Guangya Liu wrote:
> > src/tests/oversubscription_tests.cpp, line 512
> > <https://reviews.apache.org/r/55893/diff/1/?file=1613785#file1613785line512>
> >
> >     How about s/offer1/offer as here you only have one such variable.

True but on the other hand, offer1 matches resources1, as in, the first offer. If I s/offerId/offerId1/ I guess this would be more clear.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review163111
-----------------------------------------------------------


On Jan. 24, 2017, 1:52 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55893/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2017, 1:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is another test fix in the chain.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 
> 
> Diff: https://reviews.apache.org/r/55893/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review163111
-----------------------------------------------------------



I think that your patch need depend on /r/51027 , also in `Testing Done` section, can you please make the test repeat or use `--gtest_repeat=-1 --gtest_break_on_failure` to make sure the test is not flaky?


src/tests/oversubscription_tests.cpp (line 507)
<https://reviews.apache.org/r/55893/#comment234561>

    How about s/offer1/offer as here you only have one such variable.



src/tests/oversubscription_tests.cpp (line 543)
<https://reviews.apache.org/r/55893/#comment234562>

    How about following?
    
    ```
    // The latest resource estimate should match the total offered resources.
    ```
    
    This can also make the comments match `resources2 and resources3`.


- Guangya Liu


On \u4e00\u6708 24, 2017, 9:52 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55893/
> -----------------------------------------------------------
> 
> (Updated \u4e00\u6708 24, 2017, 9:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is another test fix in the chain.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 
> 
> Diff: https://reviews.apache.org/r/55893/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Jacob Janco <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review163604
-----------------------------------------------------------



Running at --gtest_repeat=1000 failed with: 

../../src/tests/oversubscription_tests.cpp:544: Failure
Value of: resources3
  Actual: { cpus(*){REV}:2 }
Expected: resources2
Which is: { cpus(*){REV}:3 }
*** Aborted at 1485821402 (unix time) try "date -d @1485821402" if you are using GNU date ***
PC: @        0x108522f60 testing::UnitTest::AddTestPartResult()
*** SIGSEGV (@0x0) received by PID 13601 (TID 0x7fffcaede3c0) stack trace: ***
    @     0x7fffc229ebba _sigtramp
    @                0xa (unknown)
    @        0x108522767 testing::internal::AssertHelper::operator=()
    @        0x107aed3f1 mesos::internal::tests::OversubscriptionTest_RescindRevocableOfferWithIncreasedRevocable_Test::TestBody()
    @        0x107ab780a testing::internal::HandleSehExceptionsInMethodIfSupported<>()
    @        0x108534877 testing::internal::HandleExceptionsInMethodIfSupported<>()
    @        0x108534725 testing::Test::Run()
    @        0x108536278 testing::TestInfo::Run()
    @        0x1085375e7 testing::TestCase::Run()
    @        0x10854716c testing::internal::UnitTestImpl::RunAllTests()
    @        0x108582eda testing::internal::HandleSehExceptionsInMethodIfSupported<>()
    @        0x108546b97 testing::internal::HandleExceptionsInMethodIfSupported<>()
    @        0x108546a68 testing::UnitTest::Run()
    @        0x107642ee1 RUN_ALL_TESTS()
    @        0x10763ec1d main
    @     0x7fffc2091255 start
Segmentation fault: 11

- Jacob Janco


On Jan. 24, 2017, 9:52 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55893/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2017, 9:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is another test fix in the chain.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 
> 
> Diff: https://reviews.apache.org/r/55893/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review163621
-----------------------------------------------------------



Bad patch!

Reviews applied: [55893, 52534, 51027]

Failed command: python support/apply-reviews.py -n -r 52534

Error:
2017-01-31 05:03:16 URL:https://reviews.apache.org/r/52534/diff/raw/ [4204/4204] -> "52534.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.hpp:226
error: src/master/allocator/mesos/hierarchical.hpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/16923/console

- Mesos Reviewbot


On Jan. 31, 2017, 12:55 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55893/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2017, 12:55 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is another test fix in the chain.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 
> 
> Diff: https://reviews.apache.org/r/55893/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Jiang Yan Xu <xu...@apple.com>.

> On Jan. 31, 2017, 2:20 p.m., Jacob Janco wrote:
> > Ship It!
> 
> Guangya Liu wrote:
>     @Jacob, does the flaky test fixed with "--gtest_repeat=1000"?

Yes. See "Testing Done".


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review163723
-----------------------------------------------------------


On Jan. 31, 2017, 1:03 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55893/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2017, 1:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is another test fix in the chain.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 
> 
> Diff: https://reviews.apache.org/r/55893/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> ./bin/mesos-tests.sh --verbose --gtest_repeat=500 --gtest_filter=*RescindRevocableOfferWithIncreasedRevocable*
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Guangya Liu <gy...@gmail.com>.

> On \u4e00\u6708 31, 2017, 10:20 p.m., Jacob Janco wrote:
> > Ship It!
> 
> Guangya Liu wrote:
>     @Jacob, does the flaky test fixed with "--gtest_repeat=1000"?
> 
> Jiang Yan Xu wrote:
>     Yes. See "Testing Done".

Thanks @Yan, but I did not see any code update after @Jacob's flaky test result, am I missed anything?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review163723
-----------------------------------------------------------


On \u4e00\u6708 31, 2017, 9:03 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55893/
> -----------------------------------------------------------
> 
> (Updated \u4e00\u6708 31, 2017, 9:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is another test fix in the chain.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 
> 
> Diff: https://reviews.apache.org/r/55893/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> ./bin/mesos-tests.sh --verbose --gtest_repeat=500 --gtest_filter=*RescindRevocableOfferWithIncreasedRevocable*
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Jiang Yan Xu <xu...@apple.com>.

> On Jan. 31, 2017, 2:20 p.m., Jacob Janco wrote:
> > Ship It!
> 
> Guangya Liu wrote:
>     @Jacob, does the flaky test fixed with "--gtest_repeat=1000"?
> 
> Jiang Yan Xu wrote:
>     Yes. See "Testing Done".
> 
> Guangya Liu wrote:
>     Thanks @Yan, but I did not see any code update after @Jacob's flaky test result, am I missed anything?

See https://reviews.apache.org/r/55893/diff/1-2/


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review163723
-----------------------------------------------------------


On Jan. 31, 2017, 1:03 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55893/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2017, 1:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is another test fix in the chain.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 
> 
> Diff: https://reviews.apache.org/r/55893/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> ./bin/mesos-tests.sh --verbose --gtest_repeat=500 --gtest_filter=*RescindRevocableOfferWithIncreasedRevocable*
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Guangya Liu <gy...@gmail.com>.

> On \u4e00\u6708 31, 2017, 10:20 p.m., Jacob Janco wrote:
> > Ship It!

@Jacob, does the flaky test fixed with "--gtest_repeat=1000"?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review163723
-----------------------------------------------------------


On \u4e00\u6708 31, 2017, 9:03 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55893/
> -----------------------------------------------------------
> 
> (Updated \u4e00\u6708 31, 2017, 9:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is another test fix in the chain.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 
> 
> Diff: https://reviews.apache.org/r/55893/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> ./bin/mesos-tests.sh --verbose --gtest_repeat=500 --gtest_filter=*RescindRevocableOfferWithIncreasedRevocable*
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Jacob Janco <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review163723
-----------------------------------------------------------


Ship it!




Ship It!

- Jacob Janco


On Jan. 31, 2017, 9:03 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55893/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2017, 9:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is another test fix in the chain.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 
> 
> Diff: https://reviews.apache.org/r/55893/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> ./bin/mesos-tests.sh --verbose --gtest_repeat=500 --gtest_filter=*RescindRevocableOfferWithIncreasedRevocable*
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/#review163771
-----------------------------------------------------------


Ship it!




Ship It!

- Guangya Liu


On \u4e00\u6708 31, 2017, 9:03 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55893/
> -----------------------------------------------------------
> 
> (Updated \u4e00\u6708 31, 2017, 9:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is another test fix in the chain.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 
> 
> Diff: https://reviews.apache.org/r/55893/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> ./bin/mesos-tests.sh --verbose --gtest_repeat=500 --gtest_filter=*RescindRevocableOfferWithIncreasedRevocable*
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Jiang Yan Xu <xu...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/
-----------------------------------------------------------

(Updated Jan. 31, 2017, 1:03 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.


Bugs: MESOS-6904
    https://issues.apache.org/jira/browse/MESOS-6904


Repository: mesos


Description
-------

This is another test fix in the chain.


Diffs
-----

  src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 

Diff: https://reviews.apache.org/r/55893/diff/


Testing
-------

make check.

./bin/mesos-tests.sh --verbose --gtest_repeat=500 --gtest_filter=*RescindRevocableOfferWithIncreasedRevocable*


Thanks,

Jiang Yan Xu

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Jiang Yan Xu <xu...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/
-----------------------------------------------------------

(Updated Jan. 31, 2017, 1:01 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.


Bugs: MESOS-6904
    https://issues.apache.org/jira/browse/MESOS-6904


Repository: mesos


Description
-------

This is another test fix in the chain.


Diffs
-----

  src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 

Diff: https://reviews.apache.org/r/55893/diff/


Testing (updated)
-------

make check.

./bin/mesos-tests.sh --verbose --gtest_repeat=500 --gtest_filter=*RescindRevocableOfferWithIncreasedRevocable*


Thanks,

Jiang Yan Xu

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Jiang Yan Xu <xu...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/
-----------------------------------------------------------

(Updated Jan. 31, 2017, 1:01 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.


Changes
-------

Review comments.


Bugs: MESOS-6904
    https://issues.apache.org/jira/browse/MESOS-6904


Repository: mesos


Description
-------

This is another test fix in the chain.


Diffs (updated)
-----

  src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 

Diff: https://reviews.apache.org/r/55893/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Jiang Yan Xu <xu...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/
-----------------------------------------------------------

(Updated Jan. 30, 2017, 4:55 p.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.


Bugs: MESOS-6904
    https://issues.apache.org/jira/browse/MESOS-6904


Repository: mesos


Description
-------

This is another test fix in the chain.


Diffs
-----

  src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 

Diff: https://reviews.apache.org/r/55893/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 55893: Fixed OversubscriptionTest.RescindRevocableOfferWithIncreasedRevocable.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55893/
-----------------------------------------------------------

(Updated Jan. 24, 2017, 1:52 p.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco.


Bugs: MESOS-6904
    https://issues.apache.org/jira/browse/MESOS-6904


Repository: mesos


Description
-------

This is another test fix in the chain.


Diffs
-----

  src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 

Diff: https://reviews.apache.org/r/55893/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu