You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/22 08:53:07 UTC
[GitHub] [spark] tanelk opened a new pull request #31927: [SPARK-34822][SQL] Update plan stability golden files on explain change
tanelk opened a new pull request #31927:
URL: https://github.com/apache/spark/pull/31927
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Update the plan stability golden files even if only the `explain.txt` changes.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Currently only `simplified.txt` change is checked. There are some PRs, that update the `explain.txt`, that do not change the `simplified.txt`.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
The updated golden files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #31927:
URL: https://github.com/apache/spark/pull/31927#discussion_r598806204
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala
##########
@@ -101,10 +101,13 @@ trait PlanStabilitySuite extends TPCDSBase with DisableAdaptiveExecutionSuite {
new File(goldenFilePath, name)
}
- private def isApproved(dir: File, actualSimplifiedPlan: String): Boolean = {
- val file = new File(dir, "simplified.txt")
- val expected = FileUtils.readFileToString(file, StandardCharsets.UTF_8)
- expected == actualSimplifiedPlan
+ private def isApproved(
+ dir: File, actualSimplifiedPlan: String, actualExplain: String): Boolean = {
Review comment:
nit: 4 indents
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/PlanStabilitySuite.scala
##########
@@ -101,10 +101,13 @@ trait PlanStabilitySuite extends TPCDSBase with DisableAdaptiveExecutionSuite {
new File(goldenFilePath, name)
}
- private def isApproved(dir: File, actualSimplifiedPlan: String): Boolean = {
- val file = new File(dir, "simplified.txt")
- val expected = FileUtils.readFileToString(file, StandardCharsets.UTF_8)
- expected == actualSimplifiedPlan
+ private def isApproved(
+ dir: File, actualSimplifiedPlan: String, actualExplain: String): Boolean = {
+ val simplifiedFile = new File(dir, "simplified.txt")
+ val expectedSimplified = FileUtils.readFileToString(simplifiedFile, StandardCharsets.UTF_8)
+ val explainFile = new File(dir, "explain.txt")
+ val expectedExplain = FileUtils.readFileToString(explainFile, StandardCharsets.UTF_8)
+ expectedSimplified == actualSimplifiedPlan && expectedExplain == actualExplain
Review comment:
Can we avoid the comparison between explains when `expectedSimplified != actualSimplifiedPlan`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804200545
**[Test build #136355 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136355/testReport)** for PR 31927 at commit [`391a1c7`](https://github.com/apache/spark/commit/391a1c7e1d877cd3b8fcaa1eb3f26f635a5b56b8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-806337630
Let me just revert it for now. Seems like it blocks other SQL PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804483531
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136357/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804281615
**[Test build #136357 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136357/testReport)** for PR 31927 at commit [`1093f3e`](https://github.com/apache/spark/commit/1093f3e006bd1cbdae25db84f4dc79fc5089e66e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31927:
URL: https://github.com/apache/spark/pull/31927#discussion_r598897440
##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v2_7/q70a.sf100/explain.txt
##########
@@ -207,7 +207,7 @@ Arguments: [rank(_w2#17) windowspecdefinition(s_state#10, _w2#17 DESC NULLS LAST
(32) Filter [codegen id : 7]
Input [4]: [s_state#16, s_state#10, _w2#17, ranking#19]
-Condition : (isnotnull(ranking#19) AND (ranking#19 <= 5))
Review comment:
Maybe we should include more perf-sensitive information in `simplified.txt`. `explain.txt` is too verbose and may change frequently (alias name changes, expr ID changes, etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804728543
I'm OK to merge this first and see how frequently the explain files are changed. We can revisit the decision later. Also cc @maropu @viirya @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804205276
AFAIK this behavior is intentional to avoid hitting too many minor changes. What's the reason to change it? Do you have an example that changes in `explain.txt` is un-captured but is perf-significant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804143214
cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804356586
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136352/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804278671
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40940/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #31927:
URL: https://github.com/apache/spark/pull/31927#discussion_r598935673
##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v2_7/q70a.sf100/explain.txt
##########
@@ -207,7 +207,7 @@ Arguments: [rank(_w2#17) windowspecdefinition(s_state#10, _w2#17 DESC NULLS LAST
(32) Filter [codegen id : 7]
Input [4]: [s_state#16, s_state#10, _w2#17, ranking#19]
-Condition : (isnotnull(ranking#19) AND (ranking#19 <= 5))
Review comment:
To me it seems beneficial to see, that how your PR affects real query plans. From the diff of this PR it looks like there are about 4 changes to the `explain.txt`, that did not show up in the `simplified.txt`:
- Some filter conditions are deduplicated - `GreaterThan(hd_vehicle_count,0)` from q34.
- There are some odd whitespace changes - perhaps it would have been useful to catch them during the PR, that caused them.
- The date representation has changed 0 -> 1970-01-01
- the `isnotnull` change from my PR.
Perhaps I missed some, but it does not seem like the `explain.txt` changes too often.
But my main argument for this change is that it is very confusing if you make a change, that should show up in the `explain.txt` after running `SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *PlanStability[WithStats]Suite"`, but it does not. As was the case, when I changed the `Rank` to be not nullable.
And now if someone else would make a change, that impacts the `simplified.txt`, then they would get some unexpected/unrelated changes also to their `explain.txt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804083616
**[Test build #136338 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136338/testReport)** for PR 31927 at commit [`3d9b64d`](https://github.com/apache/spark/commit/3d9b64d45b9726a23a0e39d1685d23f0bb13dc4d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804280070
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40940/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804353727
**[Test build #136352 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136352/testReport)** for PR 31927 at commit [`bfd51a4`](https://github.com/apache/spark/commit/bfd51a430e812ada5946491467359fd894a3ea4c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class WriteToStream(`
* `case class WriteToStreamStatement(`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804357574
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40941/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804281615
**[Test build #136357 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136357/testReport)** for PR 31927 at commit [`1093f3e`](https://github.com/apache/spark/commit/1093f3e006bd1cbdae25db84f4dc79fc5089e66e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804356586
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136352/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31927:
URL: https://github.com/apache/spark/pull/31927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804483531
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136357/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804391898
**[Test build #136355 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136355/testReport)** for PR 31927 at commit [`391a1c7`](https://github.com/apache/spark/commit/391a1c7e1d877cd3b8fcaa1eb3f26f635a5b56b8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804272224
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40940/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804200545
**[Test build #136355 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136355/testReport)** for PR 31927 at commit [`391a1c7`](https://github.com/apache/spark/commit/391a1c7e1d877cd3b8fcaa1eb3f26f635a5b56b8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804280070
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40940/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804211992
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40936/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-803947395
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40922/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-806357600
@tanelk can you resubmit the PR? It also means that there is a plan change in `explain.txt` between the test pass and PR merging (2 days).
We should probably trigger test for this PR per day and see how frequently `explain.txt` changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804090399
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136338/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-803895337
**[Test build #136338 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136338/testReport)** for PR 31927 at commit [`3d9b64d`](https://github.com/apache/spark/commit/3d9b64d45b9726a23a0e39d1685d23f0bb13dc4d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-803895337
**[Test build #136338 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136338/testReport)** for PR 31927 at commit [`3d9b64d`](https://github.com/apache/spark/commit/3d9b64d45b9726a23a0e39d1685d23f0bb13dc4d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804141773
**[Test build #136352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136352/testReport)** for PR 31927 at commit [`bfd51a4`](https://github.com/apache/spark/commit/bfd51a430e812ada5946491467359fd894a3ea4c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-803947173
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40922/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-805874466
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804141773
**[Test build #136352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136352/testReport)** for PR 31927 at commit [`bfd51a4`](https://github.com/apache/spark/commit/bfd51a430e812ada5946491467359fd894a3ea4c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804395713
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136355/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-803940228
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40922/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804357814
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40941/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804204224
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40936/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804090399
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136338/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804944559
We need the two files (`explain.txt` an `simplified.txt`) for tracking plan changes? If the updates of `explain.txt` is less frequently, I think its okay just to keep that file only (drop `simplified.txt`). Anyway, its fine to merge this and see how frequently it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-803947395
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40922/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-806337027
Looks like this commit is causing a test failure:
```
2021-03-24T16:49:17.4087634Z [info] Plans did not match:
2021-03-24T16:49:17.4089534Z [info] last approved simplified plan: /home/runner/work/spark/spark/sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q17/simplified.txt
2021-03-24T16:49:17.4092788Z [info] last approved explain plan: /home/runner/work/spark/spark/sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q17/explain.txt
2021-03-24T16:49:17.4108624Z [info]
2021-03-24T16:49:17.4111690Z [info] TakeOrderedAndProject [i_item_id,i_item_desc,s_state,store_sales_quantitycount,store_sales_quantityave,store_sales_quantitystdev,store_sales_quantitycov,as_store_returns_quantitycount,as_store_returns_quantityave,as_store_returns_quantitystdev,store_returns_quantitycov,catalog_sales_quantitycount,catalog_sales_quantityave,catalog_sales_quantitystdev,catalog_sales_quantitycov]
2021-03-24T16:49:17.4114611Z [info] WholeStageCodegen (9)
2021-03-24T16:49:17.4121850Z [info] HashAggregate [i_item_id,i_item_desc,s_state,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2] [count(ss_quantity),avg(ss_quantity),stddev_samp(cast(ss_quantity as double)),count(sr_return_quantity),avg(sr_return_quantity),stddev_samp(cast(sr_return_quantity as double)),count(cs_quantity),avg(cs_quantity),stddev_samp(cast(cs_quantity as double)),store_sales_quantitycount,store_sales_quantityave,store_sales_quantitystdev,store_sales_quantitycov,as_store_returns_quantitycount,as_store_returns_quantityave,as_store_returns_quantitystdev,store_returns_quantitycov,catalog_sales_quantitycount,catalog_sales_quantityave,catalog_sales_quantitystdev,catalog_sales_quantitycov,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2]
2021-03-24T16:49:17.4128742Z [info] InputAdapter
2021-03-24T16:49:17.4129613Z [info] Exchange [i_item_id,i_item_desc,s_state] #1
2021-03-24T16:49:17.4130663Z [info] WholeStageCodegen (8)
2021-03-24T16:49:17.4136559Z [info] HashAggregate [i_item_id,i_item_desc,s_state,ss_quantity,sr_return_quantity,cs_quantity] [count,sum,count,n,avg,m2,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2]
2021-03-24T16:49:17.4142484Z [info] Project [ss_quantity,sr_return_quantity,cs_quantity,s_state,i_item_id,i_item_desc]
2021-03-24T16:49:17.4143625Z [info] BroadcastHashJoin [ss_item_sk,i_item_sk]
2021-03-24T16:49:17.4144743Z [info] Project [ss_item_sk,ss_quantity,sr_return_quantity,cs_quantity,s_state]
2021-03-24T16:49:17.4145976Z [info] BroadcastHashJoin [ss_store_sk,s_store_sk]
2021-03-24T16:49:17.4147126Z [info] Project [ss_item_sk,ss_store_sk,ss_quantity,sr_return_quantity,cs_quantity]
2021-03-24T16:49:17.4148379Z [info] BroadcastHashJoin [cs_sold_date_sk,d_date_sk]
2021-03-24T16:49:17.4149601Z [info] Project [ss_item_sk,ss_store_sk,ss_quantity,sr_return_quantity,cs_quantity,cs_sold_date_sk]
2021-03-24T16:49:17.4150944Z [info] BroadcastHashJoin [sr_returned_date_sk,d_date_sk]
2021-03-24T16:49:17.4152343Z [info] Project [ss_item_sk,ss_store_sk,ss_quantity,sr_return_quantity,sr_returned_date_sk,cs_quantity,cs_sold_date_sk]
2021-03-24T16:49:17.4153764Z [info] BroadcastHashJoin [ss_sold_date_sk,d_date_sk]
2021-03-24T16:49:17.4155306Z [info] Project [ss_item_sk,ss_store_sk,ss_quantity,ss_sold_date_sk,sr_return_quantity,sr_returned_date_sk,cs_quantity,cs_sold_date_sk]
2021-03-24T16:49:17.4156898Z [info] BroadcastHashJoin [sr_customer_sk,sr_item_sk,cs_bill_customer_sk,cs_item_sk]
2021-03-24T16:49:17.4158410Z [info] Project [ss_item_sk,ss_store_sk,ss_quantity,ss_sold_date_sk,sr_item_sk,sr_customer_sk,sr_return_quantity,sr_returned_date_sk]
2021-03-24T16:49:17.4160113Z [info] BroadcastHashJoin [ss_customer_sk,ss_item_sk,ss_ticket_number,sr_customer_sk,sr_item_sk,sr_ticket_number]
2021-03-24T16:49:17.4162184Z [info] Filter [ss_customer_sk,ss_item_sk,ss_ticket_number,ss_store_sk]
2021-03-24T16:49:17.4178858Z [info] ColumnarToRow
2021-03-24T16:49:17.4181258Z [info] InputAdapter
2021-03-24T16:49:17.4234810Z [info] Scan parquet default.store_sales [ss_item_sk,ss_customer_sk,ss_store_sk,ss_ticket_number,ss_quantity,ss_sold_date_sk]
2021-03-24T16:49:17.4241053Z [info] SubqueryBroadcast [d_date_sk] #1
2021-03-24T16:49:17.4242229Z [info] ReusedExchange [d_date_sk] #2
2021-03-24T16:49:17.4243115Z [info] InputAdapter
2021-03-24T16:49:17.4244207Z [info] BroadcastExchange #3
2021-03-24T16:49:17.4251484Z [info] WholeStageCodegen (1)
2021-03-24T16:49:17.4255436Z [info] Filter [sr_customer_sk,sr_item_sk,sr_ticket_number]
2021-03-24T16:49:17.4256502Z [info] ColumnarToRow
2021-03-24T16:49:17.4265489Z [info] InputAdapter
2021-03-24T16:49:17.4267239Z [info] Scan parquet default.store_returns [sr_item_sk,sr_customer_sk,sr_ticket_number,sr_return_quantity,sr_returned_date_sk]
2021-03-24T16:49:17.4269024Z [info] SubqueryBroadcast [d_date_sk] #2
2021-03-24T16:49:17.4270110Z [info] ReusedExchange [d_date_sk] #4
2021-03-24T16:49:17.4270994Z [info] InputAdapter
2021-03-24T16:49:17.4274032Z [info] BroadcastExchange #5
2021-03-24T16:49:17.4278098Z [info] WholeStageCodegen (2)
2021-03-24T16:49:17.4281563Z [info] Filter [cs_bill_customer_sk,cs_item_sk]
2021-03-24T16:49:17.4282608Z [info] ColumnarToRow
2021-03-24T16:49:17.4286437Z [info] InputAdapter
2021-03-24T16:49:17.4287792Z [info] Scan parquet default.catalog_sales [cs_bill_customer_sk,cs_item_sk,cs_quantity,cs_sold_date_sk]
2021-03-24T16:49:17.4291513Z [info] SubqueryBroadcast [d_date_sk] #3
2021-03-24T16:49:17.4294654Z [info] ReusedExchange [d_date_sk] #4
2021-03-24T16:49:17.4295557Z [info] InputAdapter
2021-03-24T16:49:17.4296422Z [info] BroadcastExchange #2
2021-03-24T16:49:17.4303409Z [info] WholeStageCodegen (3)
2021-03-24T16:49:17.4304716Z [info] Project [d_date_sk]
2021-03-24T16:49:17.4305677Z [info] Filter [d_quarter_name,d_date_sk]
2021-03-24T16:49:17.4309030Z [info] ColumnarToRow
2021-03-24T16:49:17.4309906Z [info] InputAdapter
2021-03-24T16:49:17.4313363Z [info] Scan parquet default.date_dim [d_date_sk,d_quarter_name]
2021-03-24T16:49:17.4314538Z [info] InputAdapter
2021-03-24T16:49:17.4319580Z [info] BroadcastExchange #4
2021-03-24T16:49:17.4359424Z [info] WholeStageCodegen (4)
2021-03-24T16:49:17.4360357Z [info] Project [d_date_sk]
2021-03-24T16:49:17.4367342Z [info] Filter [d_quarter_name,d_date_sk]
2021-03-24T16:49:17.4372450Z [info] ColumnarToRow
2021-03-24T16:49:17.4374035Z [info] InputAdapter
2021-03-24T16:49:17.4375066Z [info] Scan parquet default.date_dim [d_date_sk,d_quarter_name]
2021-03-24T16:49:17.4380541Z [info] InputAdapter
2021-03-24T16:49:17.4381858Z [info] ReusedExchange [d_date_sk] #4
2021-03-24T16:49:17.4382722Z [info] InputAdapter
2021-03-24T16:49:17.4389327Z [info] BroadcastExchange #6
2021-03-24T16:49:17.4390305Z [info] WholeStageCodegen (6)
2021-03-24T16:49:17.4391277Z [info] Filter [s_store_sk]
2021-03-24T16:49:17.4392200Z [info] ColumnarToRow
2021-03-24T16:49:17.4393197Z [info] InputAdapter
2021-03-24T16:49:17.4396840Z [info] Scan parquet default.store [s_store_sk,s_state]
2021-03-24T16:49:17.4397864Z [info] InputAdapter
2021-03-24T16:49:17.4401263Z [info] BroadcastExchange #7
2021-03-24T16:49:17.4402168Z [info] WholeStageCodegen (7)
2021-03-24T16:49:17.4403104Z [info] Filter [i_item_sk]
2021-03-24T16:49:17.4404042Z [info] ColumnarToRow
2021-03-24T16:49:17.4404824Z [info] InputAdapter
2021-03-24T16:49:17.4405772Z [info] Scan parquet default.item [i_item_sk,i_item_id,i_item_desc]
2021-03-24T16:49:17.4406538Z [info]
2021-03-24T16:49:17.4407068Z [info]
2021-03-24T16:49:17.4408081Z [info] actual simplified plan: /home/runner/work/spark/spark/target/tmp/q17.actual.simplified.txt
2021-03-24T16:49:17.4409559Z [info] actual explain plan: /home/runner/work/spark/spark/target/tmp/q17.actual.explain.txt
2021-03-24T16:49:17.4410459Z [info]
2021-03-24T16:49:17.4427593Z [info] TakeOrderedAndProject [i_item_id,i_item_desc,s_state,store_sales_quantitycount,store_sales_quantityave,store_sales_quantitystdev,store_sales_quantitycov,as_store_returns_quantitycount,as_store_returns_quantityave,as_store_returns_quantitystdev,store_returns_quantitycov,catalog_sales_quantitycount,catalog_sales_quantityave,catalog_sales_quantitystdev,catalog_sales_quantitycov]
2021-03-24T16:49:17.4436570Z [info] WholeStageCodegen (9)
2021-03-24T16:49:17.4451461Z [info] HashAggregate [i_item_id,i_item_desc,s_state,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2] [count(ss_quantity),avg(ss_quantity),stddev_samp(cast(ss_quantity as double)),count(sr_return_quantity),avg(sr_return_quantity),stddev_samp(cast(sr_return_quantity as double)),count(cs_quantity),avg(cs_quantity),stddev_samp(cast(cs_quantity as double)),store_sales_quantitycount,store_sales_quantityave,store_sales_quantitystdev,store_sales_quantitycov,as_store_returns_quantitycount,as_store_returns_quantityave,as_store_returns_quantitystdev,store_returns_quantitycov,catalog_sales_quantitycount,catalog_sales_quantityave,catalog_sales_quantitystdev,catalog_sales_quantitycov,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2]
2021-03-24T16:49:17.4466195Z [info] InputAdapter
2021-03-24T16:49:17.4467068Z [info] Exchange [i_item_id,i_item_desc,s_state] #1
2021-03-24T16:49:17.4472369Z [info] WholeStageCodegen (8)
2021-03-24T16:49:17.4486333Z [info] HashAggregate [i_item_id,i_item_desc,s_state,ss_quantity,sr_return_quantity,cs_quantity] [count,sum,count,n,avg,m2,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2,count,sum,count,n,avg,m2]
2021-03-24T16:49:17.4499839Z [info] Project [ss_quantity,sr_return_quantity,cs_quantity,s_state,i_item_id,i_item_desc]
2021-03-24T16:49:17.4501476Z [info] BroadcastHashJoin [ss_item_sk,i_item_sk]
2021-03-24T16:49:17.4507299Z [info] Project [ss_item_sk,ss_quantity,sr_return_quantity,cs_quantity,s_state]
2021-03-24T16:49:17.4508579Z [info] BroadcastHashJoin [ss_store_sk,s_store_sk]
2021-03-24T16:49:17.4513208Z [info] Project [ss_item_sk,ss_store_sk,ss_quantity,sr_return_quantity,cs_quantity]
2021-03-24T16:49:17.4514357Z [info] BroadcastHashJoin [cs_sold_date_sk,d_date_sk]
2021-03-24T16:49:17.4520316Z [info] Project [ss_item_sk,ss_store_sk,ss_quantity,sr_return_quantity,cs_quantity,cs_sold_date_sk]
2021-03-24T16:49:17.4521672Z [info] BroadcastHashJoin [sr_returned_date_sk,d_date_sk]
2021-03-24T16:49:17.4524297Z [info] Project [ss_item_sk,ss_store_sk,ss_quantity,sr_return_quantity,sr_returned_date_sk,cs_quantity,cs_sold_date_sk]
2021-03-24T16:49:17.4528499Z [info] BroadcastHashJoin [ss_sold_date_sk,d_date_sk]
2021-03-24T16:49:17.4532223Z [info] Project [ss_item_sk,ss_store_sk,ss_quantity,ss_sold_date_sk,sr_return_quantity,sr_returned_date_sk,cs_quantity,cs_sold_date_sk]
2021-03-24T16:49:17.4536301Z [info] BroadcastHashJoin [sr_customer_sk,sr_item_sk,cs_bill_customer_sk,cs_item_sk]
2021-03-24T16:49:17.4541387Z [info] Project [ss_item_sk,ss_store_sk,ss_quantity,ss_sold_date_sk,sr_item_sk,sr_customer_sk,sr_return_quantity,sr_returned_date_sk]
2021-03-24T16:49:17.4545968Z [info] BroadcastHashJoin [ss_customer_sk,ss_item_sk,ss_ticket_number,sr_customer_sk,sr_item_sk,sr_ticket_number]
2021-03-24T16:49:17.4547589Z [info] Filter [ss_customer_sk,ss_item_sk,ss_ticket_number,ss_store_sk]
2021-03-24T16:49:17.4551357Z [info] ColumnarToRow
2021-03-24T16:49:17.4554525Z [info] InputAdapter
2021-03-24T16:49:17.4558013Z [info] Scan parquet default.store_sales [ss_item_sk,ss_customer_sk,ss_store_sk,ss_ticket_number,ss_quantity,ss_sold_date_sk]
2021-03-24T16:49:17.4559423Z [info] SubqueryBroadcast [d_date_sk] #1
2021-03-24T16:49:17.4562945Z [info] ReusedExchange [d_date_sk] #2
2021-03-24T16:49:17.4564070Z [info] InputAdapter
2021-03-24T16:49:17.4567528Z [info] BroadcastExchange #3
2021-03-24T16:49:17.4568478Z [info] WholeStageCodegen (1)
2021-03-24T16:49:17.4569503Z [info] Filter [sr_customer_sk,sr_item_sk,sr_ticket_number]
2021-03-24T16:49:17.4584293Z [info] ColumnarToRow
2021-03-24T16:49:17.4585502Z [info] InputAdapter
2021-03-24T16:49:17.4587383Z [info] Scan parquet default.store_returns [sr_item_sk,sr_customer_sk,sr_ticket_number,sr_return_quantity,sr_returned_date_sk]
2021-03-24T16:49:17.4589177Z [info] SubqueryBroadcast [d_date_sk] #2
2021-03-24T16:49:17.4590277Z [info] ReusedExchange [d_date_sk] #4
2021-03-24T16:49:17.4591158Z [info] InputAdapter
2021-03-24T16:49:17.4592023Z [info] BroadcastExchange #5
2021-03-24T16:49:17.4593416Z [info] WholeStageCodegen (2)
2021-03-24T16:49:17.4594397Z [info] Filter [cs_bill_customer_sk,cs_item_sk]
2021-03-24T16:49:17.4595712Z [info] ColumnarToRow
2021-03-24T16:49:17.4596554Z [info] InputAdapter
2021-03-24T16:49:17.4605139Z [info] Scan parquet default.catalog_sales [cs_bill_customer_sk,cs_item_sk,cs_quantity,cs_sold_date_sk]
2021-03-24T16:49:17.4606912Z [info] SubqueryBroadcast [d_date_sk] #3
2021-03-24T16:49:17.4610282Z [info] ReusedExchange [d_date_sk] #4
2021-03-24T16:49:17.4611202Z [info] InputAdapter
2021-03-24T16:49:17.4615666Z [info] BroadcastExchange #2
2021-03-24T16:49:17.4616803Z [info] WholeStageCodegen (3)
2021-03-24T16:49:17.4617806Z [info] Project [d_date_sk]
2021-03-24T16:49:17.4618649Z [info] Filter [d_quarter_name,d_date_sk]
2021-03-24T16:49:17.4619612Z [info] ColumnarToRow
2021-03-24T16:49:17.4625794Z [info] InputAdapter
2021-03-24T16:49:17.4629069Z [info] Scan parquet default.date_dim [d_date_sk,d_quarter_name]
2021-03-24T16:49:17.4636412Z [info] InputAdapter
2021-03-24T16:49:17.4640905Z [info] BroadcastExchange #4
2021-03-24T16:49:17.4657981Z [info] WholeStageCodegen (4)
2021-03-24T16:49:17.4659058Z [info] Project [d_date_sk]
2021-03-24T16:49:17.4662642Z [info] Filter [d_quarter_name,d_date_sk]
2021-03-24T16:49:17.4670052Z [info] ColumnarToRow
2021-03-24T16:49:17.4674612Z [info] InputAdapter
2021-03-24T16:49:17.4675899Z [info] Scan parquet default.date_dim [d_date_sk,d_quarter_name]
2021-03-24T16:49:17.4676890Z [info] InputAdapter
2021-03-24T16:49:17.4681403Z [info] ReusedExchange [d_date_sk] #4
2021-03-24T16:49:17.4682250Z [info] InputAdapter
2021-03-24T16:49:17.4683092Z [info] BroadcastExchange #6
2021-03-24T16:49:17.4691981Z [info] WholeStageCodegen (6)
2021-03-24T16:49:17.4692841Z [info] Filter [s_store_sk]
2021-03-24T16:49:17.4694559Z [info] ColumnarToRow
2021-03-24T16:49:17.4695388Z [info] InputAdapter
2021-03-24T16:49:17.4696340Z [info] Scan parquet default.store [s_store_sk,s_state]
2021-03-24T16:49:17.4704172Z [info] InputAdapter
2021-03-24T16:49:17.4705183Z [info] BroadcastExchange #7
2021-03-24T16:49:17.4706069Z [info] WholeStageCodegen (7)
2021-03-24T16:49:17.4707425Z [info] Filter [i_item_sk]
2021-03-24T16:49:17.4708225Z [info] ColumnarToRow
2021-03-24T16:49:17.4714903Z [info] InputAdapter
2021-03-24T16:49:17.4716146Z [info] Scan parquet default.item [i_item_sk,i_item_id,i_item_desc] (PlanStabilitySuite.scala:156)
2021-03-24T16:49:17.4718112Z [info] org.scalatest.exceptions.TestFailedException:
2021-03-24T16:49:17.4720505Z [info] at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
2021-03-24T16:49:17.4722896Z [info] at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
2021-03-24T16:49:17.4735803Z [info] at org.scalatest.funsuite.AnyFunSuite.newAssertionFailedException(AnyFunSuite.scala:1563)
2021-03-24T16:49:17.4738412Z [info] at org.scalatest.Assertions.fail(Assertions.scala:933)
2021-03-24T16:49:17.4739768Z [info] at org.scalatest.Assertions.fail$(Assertions.scala:929)
2021-03-24T16:49:17.4746717Z [info] at org.scalatest.funsuite.AnyFunSuite.fail(AnyFunSuite.scala:1563)
2021-03-24T16:49:17.4753070Z [info] at org.apache.spark.sql.PlanStabilitySuite.checkWithApproved(PlanStabilitySuite.scala:156)
2021-03-24T16:49:17.4759435Z [info] at org.apache.spark.sql.PlanStabilitySuite.testQuery(PlanStabilitySuite.scala:258)
2021-03-24T16:49:17.4766268Z [info] at org.apache.spark.sql.PlanStabilitySuite.testQuery$(PlanStabilitySuite.scala:248)
2021-03-24T16:49:17.4768527Z [info] at org.apache.spark.sql.TPCDSV1_4_PlanStabilitySuite.testQuery(PlanStabilitySuite.scala:263)
2021-03-24T16:49:17.4778918Z [info] at org.apache.spark.sql.TPCDSV1_4_PlanStabilitySuite.$anonfun$new$2(PlanStabilitySuite.scala:269)
2021-03-24T16:49:17.4780917Z [info] at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
2021-03-24T16:49:17.4783682Z [info] at org.apache.spark.sql.execution.adaptive.DisableAdaptiveExecutionSuite.$anonfun$test$5(AdaptiveTestUtils.scala:65)
2021-03-24T16:49:17.4797175Z [info] at org.apache.spark.sql.catalyst.plans.SQLHelper.withSQLConf(SQLHelper.scala:54)
2021-03-24T16:49:17.4805467Z [info] at org.apache.spark.sql.catalyst.plans.SQLHelper.withSQLConf$(SQLHelper.scala:38)
2021-03-24T16:49:17.4812447Z [info] at org.apache.spark.sql.TPCDSV1_4_PlanStabilitySuite.org$apache$spark$sql$test$SQLTestUtilsBase$$super$withSQLConf(PlanStabilitySuite.scala:263)
2021-03-24T16:49:17.4818922Z [info] at org.apache.spark.sql.test.SQLTestUtilsBase.withSQLConf(SQLTestUtils.scala:246)
2021-03-24T16:49:17.4827655Z [info] at org.apache.spark.sql.test.SQLTestUtilsBase.withSQLConf$(SQLTestUtils.scala:244)
2021-03-24T16:49:17.4833355Z [info] at org.apache.spark.sql.TPCDSV1_4_PlanStabilitySuite.withSQLConf(PlanStabilitySuite.scala:263)
2021-03-24T16:49:17.4844380Z [info] at org.apache.spark.sql.execution.adaptive.DisableAdaptiveExecutionSuite.$anonfun$test$4(AdaptiveTestUtils.scala:65)
2021-03-24T16:49:17.4849880Z [info] at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
2021-03-24T16:49:17.4873178Z [info] at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
2021-03-24T16:49:17.4879962Z [info] at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
2021-03-24T16:49:17.4881657Z [info] at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
2021-03-24T16:49:17.4924828Z [info] at org.scalatest.Transformer.apply(Transformer.scala:22)
2021-03-24T16:49:17.4926580Z [info] at org.scalatest.Transformer.apply(Transformer.scala:20)
2021-03-24T16:49:17.4928883Z [info] at org.scalatest.funsuite.AnyFunSuiteLike$$anon$1.apply(AnyFunSuiteLike.scala:190)
2021-03-24T16:49:17.4931051Z [info] at org.apache.spark.SparkFunSuite.withFixture(SparkFunSuite.scala:178)
2021-03-24T16:49:17.4933709Z [info] at org.scalatest.funsuite.AnyFunSuiteLike.invokeWithFixture$1(AnyFunSuiteLike.scala:188)
2021-03-24T16:49:17.4936276Z [info] at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$runTest$1(AnyFunSuiteLike.scala:200)
2021-03-24T16:49:17.4938354Z [info] at org.scalatest.SuperEngine.runTestImpl(Engine.scala:306)
2021-03-24T16:49:17.4940426Z [info] at org.scalatest.funsuite.AnyFunSuiteLike.runTest(AnyFunSuiteLike.scala:200)
2021-03-24T16:49:17.4943884Z [info] at org.scalatest.funsuite.AnyFunSuiteLike.runTest$(AnyFunSuiteLike.scala:182)
2021-03-24T16:49:17.4946315Z [info] at org.apache.spark.SparkFunSuite.org$scalatest$BeforeAndAfterEach$$super$runTest(SparkFunSuite.scala:61)
2021-03-24T16:49:17.4948485Z [info] at org.scalatest.BeforeAndAfterEach.runTest(BeforeAndAfterEach.scala:234)
2021-03-24T16:49:17.4950615Z [info] at org.scalatest.BeforeAndAfterEach.runTest$(BeforeAndAfterEach.scala:227)
2021-03-24T16:49:17.4952488Z [info] at org.apache.spark.SparkFunSuite.runTest(SparkFunSuite.scala:61)
2021-03-24T16:49:18.2786470Z [info] at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$runTests$1(AnyFunSuiteLike.scala:233)
2021-03-24T16:49:18.2798743Z [info] at org.scalatest.SuperEngine.$anonfun$runTestsInBranch$1(Engine.scala:413)
2021-03-24T16:49:18.2800664Z [info] at scala.collection.immutable.List.foreach(List.scala:392)
2021-03-24T16:49:18.2802587Z [info] at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:401)
2021-03-24T16:49:18.2804870Z [info] at org.scalatest.SuperEngine.runTestsInBranch(Engine.scala:396)
2021-03-24T16:49:18.2806732Z [info] at org.scalatest.SuperEngine.runTestsImpl(Engine.scala:475)
2021-03-24T16:49:18.2810689Z [info] at org.scalatest.funsuite.AnyFunSuiteLike.runTests(AnyFunSuiteLike.scala:233)
2021-03-24T16:49:18.2813109Z [info] at org.scalatest.funsuite.AnyFunSuiteLike.runTests$(AnyFunSuiteLike.scala:232)
2021-03-24T16:49:18.2815348Z [info] at org.scalatest.funsuite.AnyFunSuite.runTests(AnyFunSuite.scala:1563)
2021-03-24T16:49:18.2817075Z [info] at org.scalatest.Suite.run(Suite.scala:1112)
2021-03-24T16:49:18.2818357Z [info] at org.scalatest.Suite.run$(Suite.scala:1094)
2021-03-24T16:49:18.2820179Z [info] at org.scalatest.funsuite.AnyFunSuite.org$scalatest$funsuite$AnyFunSuiteLike$$super$run(AnyFunSuite.scala:1563)
2021-03-24T16:49:18.2822379Z [info] at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$run$1(AnyFunSuiteLike.scala:237)
2021-03-24T16:49:18.2824233Z [info] at org.scalatest.SuperEngine.runImpl(Engine.scala:535)
2021-03-24T16:49:18.2826095Z [info] at org.scalatest.funsuite.AnyFunSuiteLike.run(AnyFunSuiteLike.scala:237)
2021-03-24T16:49:18.2828216Z [info] at org.scalatest.funsuite.AnyFunSuiteLike.run$(AnyFunSuiteLike.scala:236)
2021-03-24T16:49:18.2830388Z [info] at org.apache.spark.SparkFunSuite.org$scalatest$BeforeAndAfterAll$$super$run(SparkFunSuite.scala:61)
2021-03-24T16:49:18.2832883Z [info] at org.scalatest.BeforeAndAfterAll.liftedTree1$1(BeforeAndAfterAll.scala:213)
2021-03-24T16:49:18.2834984Z [info] at org.scalatest.BeforeAndAfterAll.run(BeforeAndAfterAll.scala:210)
2021-03-24T16:49:18.2836922Z [info] at org.scalatest.BeforeAndAfterAll.run$(BeforeAndAfterAll.scala:208)
2021-03-24T16:49:18.2838772Z [info] at org.apache.spark.SparkFunSuite.run(SparkFunSuite.scala:61)
2021-03-24T16:49:18.2840631Z [info] at org.scalatest.tools.Framework.org$scalatest$tools$Framework$$runSuite(Framework.scala:318)
2021-03-24T16:49:18.2842499Z [info] at org.scalatest.tools.Framework$ScalaTestTask.execute(Framework.scala:513)
2021-03-24T16:49:18.2924800Z [info] at sbt.ForkMain$Run.lambda$runTest$1(ForkMain.java:413)
2021-03-24T16:49:18.2927316Z [info] at java.util.concurrent.FutureTask.run(FutureTask.java:266)
2021-03-24T16:49:18.2930021Z [info] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
2021-03-24T16:49:18.2932567Z [info] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
2021-03-24T16:49:18.2935644Z [info] at java.lang.Thread.run(Thread.java:748)
```
in GitHub Actions, e.g.) https://github.com/apache/spark/runs/2185109393 https://github.com/apache/spark/runs/2188934778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804327805
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40941/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804357814
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40941/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804474333
**[Test build #136357 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136357/testReport)** for PR 31927 at commit [`1093f3e`](https://github.com/apache/spark/commit/1093f3e006bd1cbdae25db84f4dc79fc5089e66e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804211943
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40936/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804211992
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40936/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804395713
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136355/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #31927:
URL: https://github.com/apache/spark/pull/31927#discussion_r598885067
##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v2_7/q70a.sf100/explain.txt
##########
@@ -207,7 +207,7 @@ Arguments: [rank(_w2#17) windowspecdefinition(s_state#10, _w2#17 DESC NULLS LAST
(32) Filter [codegen id : 7]
Input [4]: [s_state#16, s_state#10, _w2#17, ranking#19]
-Condition : (isnotnull(ranking#19) AND (ranking#19 <= 5))
Review comment:
@cloud-fan This change here was the reason I started this PR. During #31924 it was quite confusing why the `isnotnull` check was removed from some plans and not from others. I spent quite a bit of time debuging, only to discover that plan stability suite just did not update this plan, even though it was changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #31927:
URL: https://github.com/apache/spark/pull/31927#discussion_r598935673
##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v2_7/q70a.sf100/explain.txt
##########
@@ -207,7 +207,7 @@ Arguments: [rank(_w2#17) windowspecdefinition(s_state#10, _w2#17 DESC NULLS LAST
(32) Filter [codegen id : 7]
Input [4]: [s_state#16, s_state#10, _w2#17, ranking#19]
-Condition : (isnotnull(ranking#19) AND (ranking#19 <= 5))
Review comment:
To me it seems beneficial to see, that how your PR affects real query plans. From the diff of this PR it looks like there are about 4 changes to the `explain.txt`, that did not show up in the `simplified.txt`:
- Some filter conditions are deduplicated - `GreaterThan(hd_vehicle_count,0)` from q34.
- There are some odd whitespace changes - perhaps it would have been useful to catch them during the PR, that caused them.
- The date representation has changed 0 -> 1970-01-01
- the `isnotnull` change from my PR.
Perhaps I missed some, but it does not seem like the `explain.txt` changes too often.
But my main argument for this change is that it is very confusing if you make a change, that should show up in the `explain.txt` after running `SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *PlanStability[WithStats]Suite"`, but it does not. As was the case, when I changed the `Rank` to be not nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org