You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/07/11 23:23:03 UTC
[GitHub] [samza] dnishimura commented on a change in pull request #1104:
SAMZA-2266: Introduce a backoff when there are repeated failures for
host-affinity allocations
dnishimura commented on a change in pull request #1104: SAMZA-2266: Introduce a backoff when there are repeated failures for host-affinity allocations
URL: https://github.com/apache/samza/pull/1104#discussion_r302778544
##########
File path: samza-core/src/main/java/org/apache/samza/config/ClusterManagerConfig.java
##########
@@ -87,7 +88,10 @@
*/
public static final String CONTAINER_RETRY_COUNT = "yarn.container.retry.count";
public static final String CLUSTER_MANAGER_CONTAINER_RETRY_COUNT = "cluster-manager.container.retry.count";
- private static final int DEFAULT_CONTAINER_RETRY_COUNT = 8;
+ public static final int DEFAULT_CONTAINER_RETRY_COUNT = 8;
+
+ public static final String CLUSTER_MANAGER_CONTAINER_RETRY_MAX_DELAY_MS = "cluster-manager.container.host-affinity-retry.max.delay.ms";
+ public static final long DEFAULT_CONTAINER_RETRY_MAX_DELAY_MS = Duration.ofSeconds(120).toMillis();
Review comment:
Debating if this should be a non-configurable constant. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services