[GitHub] [helix] lei-xia commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.

[GitBox <gi...@apache.org>]

lei-xia commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.
URL: https://github.com/apache/helix/pull/363#discussion_r308836082
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/dataproviders/ResourceControllerDataProvider.java
 ##########
 @@ -108,18 +111,19 @@ public String getObjName(ExternalView obj) {
 
   public synchronized void refresh(HelixDataAccessor accessor) {
     long startTime = System.currentTimeMillis();
+    Set<HelixConstants.ChangeType> propertyRefreshed = new HashSet<>();
+
+    // Refresh base
+    super.refresh(accessor, propertyRefreshed);
 
 Review comment:
   minor: why not return the propertyRefreshed from the refresh() call? Pass a parameter and expect it being changed in the method is a bit not-clear.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services