You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/08 03:22:06 UTC
[GitHub] [dubbo] plusmancn commented on a change in pull request #8721: [3.0] Judge whether success or not by user's perspective in interface-appName mapping.
plusmancn commented on a change in pull request #8721:
URL: https://github.com/apache/dubbo/pull/8721#discussion_r703994941
##########
File path: dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/metadata/MetadataServiceNameMapping.java
##########
@@ -53,38 +53,40 @@ public MetadataServiceNameMapping() {
@Override
public boolean map(URL url) {
- if (CollectionUtils.isEmpty(applicationModel.getApplicationConfigManager().getMetadataConfigs())) {
- return false;
- }
- String serviceInterface = url.getServiceInterface();
- if (IGNORED_SERVICE_INTERFACES.contains(serviceInterface)) {
- return false;
- }
- String registryCluster = getRegistryCluster(url);
- MetadataReport metadataReport = metadataReportInstance.getMetadataReport(registryCluster);
+ if (CollectionUtils.isEmpty(applicationModel.getApplicationConfigManager().getMetadataConfigs())) {
+ return false;
+ }
+ String serviceInterface = url.getServiceInterface();
+ if (IGNORED_SERVICE_INTERFACES.contains(serviceInterface)) {
+ return false;
+ }
+ String registryCluster = getRegistryCluster(url);
+ MetadataReport metadataReport = metadataReportInstance.getMetadataReport(registryCluster);
- String appName = applicationModel.getApplicationName();
- if (metadataReport.registerServiceAppMapping(serviceInterface, appName, url)) {
- // MetadataReport support directly register service-app mapping
- return true;
- }
+ String appName = applicationModel.getApplicationName();
+ if (metadataReport.registerServiceAppMapping(serviceInterface, appName, url)) {
+ // MetadataReport support directly register service-app mapping
+ return true;
+ }
- int currentRetryTimes = 1;
- boolean succeeded = false;
- String newConfigContent = appName;
- do {
- ConfigItem configItem = metadataReport.getConfigItem(serviceInterface, DEFAULT_MAPPING_GROUP);
- String oldConfigContent = configItem.getContent();
- if (StringUtils.isNotEmpty(oldConfigContent)) {
- boolean contains = StringUtils.isContains(oldConfigContent, appName);
- if (contains) {
- break;
- }
- newConfigContent = oldConfigContent + COMMA_SEPARATOR + appName;
+ int currentRetryTimes = 1;
+ boolean succeeded = false;
+ String newConfigContent = appName;
+ do {
+ ConfigItem configItem = metadataReport.getConfigItem(serviceInterface, DEFAULT_MAPPING_GROUP);
+ String oldConfigContent = configItem.getContent();
+ if (StringUtils.isNotEmpty(oldConfigContent)) {
+ boolean contains = StringUtils.isContains(oldConfigContent, appName);
+ if (contains) {
+ // From the user's perspective, it means successful when the oldConfigContent has contained the current appName. So we should not throw an Exception to user, it will confuse the user.
+ succeeded = true;
Review comment:
According to the original function, setting the `succeeded` variable may be better.
The latter code may do something base on `succeeded` status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org