You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/07/05 14:39:51 UTC

[GitHub] [commons-lang] garydgregory commented on a diff in pull request #869: Add missing exception javadoc/tests for some null arguments

garydgregory commented on code in PR #869:
URL: https://github.com/apache/commons-lang/pull/869#discussion_r913877942


##########
src/main/java/org/apache/commons/lang3/ArrayUtils.java:
##########
@@ -3790,6 +3790,7 @@ public static <T extends Comparable<? super T>> boolean isSorted(final T[] array
      * @param comparator the {@code Comparator} to compare over
      * @param <T> the datatype of the array
      * @return whether the array is sorted
+     * @throws IllegalArgumentException if {@code comparator == null}

Review Comment:
   This is a NullPointerExcception in git master. In general, please update the comment format to:
   ```
   * @throws IllegalArgumentException if {@code comparator} is null
   ```
   or
   ```
   * @throws IllegalArgumentException if {@code comparator} is {@code null}
   ```
   This reads more like a comment than code.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org