You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/05 07:36:49 UTC
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #967: feat: support ApisixTls v2
tao12345666333 commented on code in PR #967:
URL: https://github.com/apache/apisix-ingress-controller/pull/967#discussion_r861021526
##########
pkg/ingress/controller.go:
##########
@@ -259,6 +263,17 @@ func (c *Controller) initWhenStartLeading() {
apisixRouteInformer = apisixFactory.Apisix().V2beta3().ApisixRoutes().Informer()
case config.ApisixRouteV2:
apisixRouteInformer = apisixFactory.Apisix().V2().ApisixRoutes().Informer()
+ default:
+ panic(fmt.Errorf("unsupported ApisixRoute version %s", c.cfg.Kubernetes.ApisixTlsVersion))
Review Comment:
```suggestion
panic(fmt.Errorf("unsupported ApisixRoute version %s", c.cfg.Kubernetes.ApisixRouteVersion))
```
```suggestion
panic(fmt.Errorf("unsupported ApisixRoute version %s", c.cfg.Kubernetes.ApisixTlsVersion))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org