You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Zuyu Zhang <hi...@gmail.com> on 2014/08/18 20:49:44 UTC
Review Request 24810: Added Resources support to return the port
range for the given number of ports.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24810/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
Added Resources support to return the port range for the given number of ports.
Diffs
-----
include/mesos/resources.hpp 12adedc4429519b90f4975036f7359c20608708a
src/common/resources.cpp edf36b154174af18981db163b2a43d1255e2cc43
Diff: https://reviews.apache.org/r/24810/diff/
Testing
-------
Thanks,
Zuyu Zhang
Re: Review Request 24810: Added Resources support to return the port
range for the given number of ports.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24810/#review50940
-----------------------------------------------------------
include/mesos/resources.hpp
<https://reviews.apache.org/r/24810/#comment88824>
How about?
Helper function to extract the given number of ports from the "ports" resource.
src/common/resources.cpp
<https://reviews.apache.org/r/24810/#comment88825>
Can you add a test(s) for this?
- Vinod Kone
On Aug. 18, 2014, 6:49 p.m., Zuyu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24810/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2014, 6:49 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added Resources support to return the port range for the given number of ports.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 12adedc4429519b90f4975036f7359c20608708a
> src/common/resources.cpp edf36b154174af18981db163b2a43d1255e2cc43
>
> Diff: https://reviews.apache.org/r/24810/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zuyu Zhang
>
>
Re: Review Request 24810: Added Resources support to return the port
range for the given number of ports.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24810/#review50934
-----------------------------------------------------------
Patch looks great!
Reviews applied: [24810]
All tests passed.
- Mesos ReviewBot
On Aug. 18, 2014, 6:49 p.m., Zuyu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24810/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2014, 6:49 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added Resources support to return the port range for the given number of ports.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 12adedc4429519b90f4975036f7359c20608708a
> src/common/resources.cpp edf36b154174af18981db163b2a43d1255e2cc43
>
> Diff: https://reviews.apache.org/r/24810/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zuyu Zhang
>
>
Re: Review Request 24810: Added Resources support to return the port
range for the given number of ports.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24810/#review52033
-----------------------------------------------------------
src/common/resources.cpp
<https://reviews.apache.org/r/24810/#comment90756>
redundant check as size_t is unsigned.
src/tests/resources_tests.cpp
<https://reviews.apache.org/r/24810/#comment90757>
does Value::Ranges not have an operator==?
- Dominic Hamon
On Aug. 31, 2014, 8:26 p.m., Zuyu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24810/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2014, 8:26 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1643
> https://issues.apache.org/jira/browse/MESOS-1643
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added support to extract the given number of ports from the "ports" resources.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 12adedc4429519b90f4975036f7359c20608708a
> src/common/resources.cpp edf36b154174af18981db163b2a43d1255e2cc43
> src/tests/resources_tests.cpp b5f2e8bdc664f6f49504f131722e554a0fdcebc2
>
> Diff: https://reviews.apache.org/r/24810/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER="*ResourcesTest*"
>
>
> Thanks,
>
> Zuyu Zhang
>
>
Re: Review Request 24810: Added Resources support to return the port
range for the given number of ports.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24810/#review52010
-----------------------------------------------------------
Patch looks great!
Reviews applied: [24810]
All tests passed.
- Mesos ReviewBot
On Sept. 1, 2014, 3:26 a.m., Zuyu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24810/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2014, 3:26 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1643
> https://issues.apache.org/jira/browse/MESOS-1643
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added support to extract the given number of ports from the "ports" resources.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 12adedc4429519b90f4975036f7359c20608708a
> src/common/resources.cpp edf36b154174af18981db163b2a43d1255e2cc43
> src/tests/resources_tests.cpp b5f2e8bdc664f6f49504f131722e554a0fdcebc2
>
> Diff: https://reviews.apache.org/r/24810/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER="*ResourcesTest*"
>
>
> Thanks,
>
> Zuyu Zhang
>
>
Re: Review Request 24810: Added Resources support to return the port
range for the given number of ports.
Posted by Zuyu Zhang <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24810/
-----------------------------------------------------------
(Updated Sept. 2, 2014, 5:30 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-1643
https://issues.apache.org/jira/browse/MESOS-1643
Repository: mesos-git
Description
-------
Added support to extract the given number of ports from the "ports" resources.
Diffs (updated)
-----
include/mesos/resources.hpp 12adedc4429519b90f4975036f7359c20608708a
src/common/resources.cpp edf36b154174af18981db163b2a43d1255e2cc43
src/tests/resources_tests.cpp b5f2e8bdc664f6f49504f131722e554a0fdcebc2
Diff: https://reviews.apache.org/r/24810/diff/
Testing
-------
make check GTEST_FILTER="*ResourcesTest*"
Thanks,
Zuyu Zhang
Re: Review Request 24810: Added Resources support to return the port
range for the given number of ports.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24810/#review52039
-----------------------------------------------------------
src/common/resources.cpp
<https://reviews.apache.org/r/24810/#comment90766>
use camelcase.
s/last_range/lastRange/
src/common/resources.cpp
<https://reviews.apache.org/r/24810/#comment90768>
s/MergeFrom/CopyFrom/
src/tests/resources_tests.cpp
<https://reviews.apache.org/r/24810/#comment90769>
Instead of manually converting to ostringstream, just use "stringify()".
Option<Value::Ranges> ports = r.ports(5);
EXPECT_SOME(ports);
EXPECT_EQ("[10000-10004]", stringify(ports.get()));
src/tests/resources_tests.cpp
<https://reviews.apache.org/r/24810/#comment90765>
s/No/Not/
- Vinod Kone
On Sept. 1, 2014, 3:26 a.m., Zuyu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24810/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2014, 3:26 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1643
> https://issues.apache.org/jira/browse/MESOS-1643
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added support to extract the given number of ports from the "ports" resources.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 12adedc4429519b90f4975036f7359c20608708a
> src/common/resources.cpp edf36b154174af18981db163b2a43d1255e2cc43
> src/tests/resources_tests.cpp b5f2e8bdc664f6f49504f131722e554a0fdcebc2
>
> Diff: https://reviews.apache.org/r/24810/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER="*ResourcesTest*"
>
>
> Thanks,
>
> Zuyu Zhang
>
>
Re: Review Request 24810: Added Resources support to return the port
range for the given number of ports.
Posted by Zuyu Zhang <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24810/
-----------------------------------------------------------
(Updated Aug. 31, 2014, 10:26 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-1643
https://issues.apache.org/jira/browse/MESOS-1643
Repository: mesos-git
Description (updated)
-------
Added support to extract the given number of ports from the "ports" resources.
Diffs (updated)
-----
include/mesos/resources.hpp 12adedc4429519b90f4975036f7359c20608708a
src/common/resources.cpp edf36b154174af18981db163b2a43d1255e2cc43
src/tests/resources_tests.cpp b5f2e8bdc664f6f49504f131722e554a0fdcebc2
Diff: https://reviews.apache.org/r/24810/diff/
Testing (updated)
-------
make check GTEST_FILTER="*ResourcesTest*"
Thanks,
Zuyu Zhang