You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/23 13:54:37 UTC

[GitHub] [hadoop-ozone] sadanand48 opened a new pull request #864: HDDS-3405.Tool for Listing keys from the OpenKeyTable

sadanand48 opened a new pull request #864:
URL: https://github.com/apache/hadoop-ozone/pull/864


   ## What changes were proposed in this pull request?
   The tool lists keys present in the Open Key Table and can be used to debug when keys are written into ozone. There is a chance that the key might not have gotten committed into the OM (KeyTable) and will be present in the OpenKeyTable which will be displayed by the tool.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-3405
   
   ## How was this patch tested?
   written unit test in TestOmMetadataManager
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] sadanand48 commented on pull request #864: HDDS-3405. Tool for Listing keys from the OpenKeyTable

Posted by GitBox <gi...@apache.org>.
sadanand48 commented on pull request #864:
URL: https://github.com/apache/hadoop-ozone/pull/864#issuecomment-642019017


   > Do we need this patch? It seems to be more easy to extend #945 / [HDDS-3622](https://issues.apache.org/jira/browse/HDDS-3622) with supporting OM...
   > 
   > What do you think?
   Yes . I will close the pr.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] elek commented on pull request #864: HDDS-3405. Tool for Listing keys from the OpenKeyTable

Posted by GitBox <gi...@apache.org>.
elek commented on pull request #864:
URL: https://github.com/apache/hadoop-ozone/pull/864#issuecomment-619882327


   Thanks to open this issue @sadanand48, I have some question regarding the concept itself.
   
   Based on the description it seems to be debug option. I don't think that we need to extend the client RPC just for a debug tool.
   
   There are two options, what I would prefer:
   
    * Use a generic tool which reads the local rocksdb. We had this one earlier (`ozone sql`) but it doesn't work. I would suggest to fix it and provide a generic way to select any table. I think it would add the power for the admins without adding more methods to the RPC.
   
    * An other option if we **really** need to get this info from remote host, to separate the admin and client calls and add this method to the admin calls. It was discussed earlier that we need a better separation of RPC calls:
   
    1. Client calls are available from any machine and public
    2. Admin calls can be published on different port, used by the admin tools and can be blocked for security reason (only for localhost)
    3. Server calls are intra-service calls  
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] sadanand48 closed pull request #864: HDDS-3405. Tool for Listing keys from the OpenKeyTable

Posted by GitBox <gi...@apache.org>.
sadanand48 closed pull request #864:
URL: https://github.com/apache/hadoop-ozone/pull/864


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] sadanand48 edited a comment on pull request #864: HDDS-3405. Tool for Listing keys from the OpenKeyTable

Posted by GitBox <gi...@apache.org>.
sadanand48 edited a comment on pull request #864:
URL: https://github.com/apache/hadoop-ozone/pull/864#issuecomment-642019017


   > Do we need this patch? It seems to be more easy to extend #945 / [HDDS-3622](https://issues.apache.org/jira/browse/HDDS-3622) with supporting OM...
   > 
   > What do you think?
   
   Yes . I will close the pr.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] elek commented on pull request #864: HDDS-3405. Tool for Listing keys from the OpenKeyTable

Posted by GitBox <gi...@apache.org>.
elek commented on pull request #864:
URL: https://github.com/apache/hadoop-ozone/pull/864#issuecomment-642015500


   Do we need this patch? It seems to be more easy to extend #945 / HDDS-3622 with supporting OM...
   
   What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] elek removed a comment on pull request #864: HDDS-3405. Tool for Listing keys from the OpenKeyTable

Posted by GitBox <gi...@apache.org>.
elek removed a comment on pull request #864:
URL: https://github.com/apache/hadoop-ozone/pull/864#issuecomment-619882327


   Thanks to open this issue @sadanand48, I have some question regarding the concept itself.
   
   Based on the description it seems to be debug option. I don't think that we need to extend the client RPC just for a debug tool.
   
   There are two options, what I would prefer:
   
    * Use a generic tool which reads the local rocksdb. We had this one earlier (`ozone sql`) but it doesn't work. I would suggest to fix it and provide a generic way to select any table. I think it would add the power for the admins without adding more methods to the RPC.
   
    * An other option if we **really** need to get this info from remote host, to separate the admin and client calls and add this method to the admin calls. It was discussed earlier that we need a better separation of RPC calls:
   
    1. Client calls are available from any machine and public
    2. Admin calls can be published on different port, used by the admin tools and can be blocked for security reason (only for localhost)
    3. Server calls are intra-service calls  
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org