[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1467: [CELEBORN-562][REFACTOR] Rename Destroy and DestroyResponse to make it more clear

["FMX (via GitHub)" <gi...@apache.org>]

FMX commented on code in PR #1467:
URL: https://github.com/apache/incubator-celeborn/pull/1467#discussion_r1178608875


##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1060,7 +1060,9 @@ class LifecycleManager(appId: String, val conf: CelebornConf) extends RpcEndpoin
     }
   }
 
-  private def requestDestroy(endpoint: RpcEndpointRef, message: Destroy): DestroyResponse = {
+  private def requestDestroy(

Review Comment:
   The function name looks really wired. How about requestWorkerDestroySlots?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org