You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/09/14 00:16:40 UTC

[GitHub] [spark] zhengruifeng commented on pull request #42891: [SPARK-45135][PYTHON][TESTS] Make `utils.eventually` a parameterized decorator

zhengruifeng commented on PR #42891:
URL: https://github.com/apache/spark/pull/42891#issuecomment-1718474420

   In the download log artifact, the added 3 UT:
   
   ```
   <?xml version="1.0" encoding="UTF-8"?>
   <testsuite name="pyspark.tests.test_util.UtilTests-20230913111701" tests="6" file="pyspark/tests/test_util.py" time="7.334" timestamp="2023-09-13T11:17:09" failures="0" errors="0" skipped="0">
   	<testcase classname="pyspark.tests.test_util.UtilTests" name="test_eventually_decorator" time="4.326" timestamp="2023-09-13T11:17:06" file="python/pyspark/tests/test_util.py" line="87">
   		<system-out><![CDATA[
   Attempt #1 failed!
   False is not true
   
   Attempt #2 failed!
   False is not true
   
   Attempt #3 failed!
   False is not true
   
   Attempt #4 failed!
   False is not true
   
   Attempt #5 failed!
   False is not true
   
   Attempt #6 failed!
   False is not true
   
   Attempt #7 failed!
   False is not true
   
   Attempt #8 failed!
   False is not true
   
   Attempt #9 failed!
   False is not true
   
   Attempt #10 failed!
   False is not true
   
   Attempt #11 failed!
   False is not true
   
   Attempt #12 failed!
   False is not true
   
   Attempt #13 failed!
   False is not true
   ]]></system-out>
   	</testcase>
   	<testcase classname="pyspark.tests.test_util.UtilTests" name="test_eventually_function" time="0.610" timestamp="2023-09-13T11:17:06" file="python/pyspark/tests/test_util.py" line="93">
   		<system-out><![CDATA[
   Attempt #1 failed!
   False is not true
   
   Attempt #2 failed!
   False is not true
   
   Attempt #3 failed!
   False is not true
   
   Attempt #4 failed!
   False is not true
   ]]></system-out>
   	</testcase>
   	<testcase classname="pyspark.tests.test_util.UtilTests" name="test_eventually_lambda" time="0.602" timestamp="2023-09-13T11:17:07" file="python/pyspark/tests/test_util.py" line="101">
   		<system-out><![CDATA[
   Attempt #1 failed!
   False is not true
   
   Attempt #2 failed!
   False is not true
   
   Attempt #3 failed!
   False is not true
   
   Attempt #4 failed!
   False is not true
   
   Attempt #5 failed!
   False is not true
   
   Attempt #6 failed!
   False is not true
   
   Attempt #7 failed!
   False is not true
   
   Attempt #8 failed!
   False is not true
   
   Attempt #9 failed!
   False is not true
   
   Attempt #10 failed!
   False is not true
   ]]></system-out>
   	</testcase>
   	<testcase classname="pyspark.tests.test_util.UtilTests" name="test_find_spark_home" time="0.595" timestamp="2023-09-13T11:17:08" file="python/pyspark/tests/test_util.py" line="78"/>
   	<testcase classname="pyspark.tests.test_util.UtilTests" name="test_parsing_version_string" time="0.617" timestamp="2023-09-13T11:17:08" file="python/pyspark/tests/test_util.py" line="73"/>
   	<testcase classname="pyspark.tests.test_util.UtilTests" name="test_py4j_str" time="0.584" timestamp="2023-09-13T11:17:09" file="python/pyspark/tests/test_util.py" line="66"/>
   </testsuite>
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org