[GitHub] [hadoop-ozone] nandakumar131 commented on issue #700: HDDS-3172. Use DBStore instead of MetadataStore in SCM

[GitBox <gi...@apache.org>]

nandakumar131 commented on issue #700:
URL: https://github.com/apache/hadoop-ozone/pull/700#issuecomment-617344219


   Thanks @elek  for updating the patch.
   
   > Do you prefer rename or removal? I am not sure if it's required or not.
   
   I'm leaning more towards renaming and using it, as it will give us easy to use API.
   If we are going with renaming and using it, it's better to use `SCMMetadataStoreRDBImpl` in all the places rather than `DBStoreBuilder.createDBStore(conf, new SCMDBDefinition()`
   
   Instead of this:
   ```
   DBStore dbStore = DBStoreBuilder.createDBStore(conf, new SCMDBDefinition());
   Table<PipelineID, Pipeline> pipelineTable = SCMDBDefinition.PIPELINES.getTable(dbStore);
   dbStore.close();
   ```
   
   we can use this:
   ```
   SCMMetadataStore scmMetadataStore = new SCMMetadataStoreRDBImpl(conf);
   Table<PipelineID, Pipeline> pipelineTable = scmMetadataStore.getPipelineTable();
   scmMetadataStore.close();
   ```
   
   > Re-create the debug tool (ozone sql If I remember well) which can list/read keys in any DBStore.
   
   +1 on fixing ozone sql tool
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org