You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "KKcorps (via GitHub)" <gi...@apache.org> on 2023/07/28 14:58:58 UTC

[GitHub] [pinot] KKcorps commented on a diff in pull request #11195: Make Preload Integration test more extensible

KKcorps commented on code in PR #11195:
URL: https://github.com/apache/pinot/pull/11195#discussion_r1277668775


##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/UpsertTableSegmentPreloadIntegrationTest.java:
##########
@@ -211,7 +226,7 @@ public void testSegmentAssignment()
                 serverStarter.getConfig().getProperty(CommonConstants.Server.CONFIG_OF_INSTANCE_DATA_DIR);
             File[] files = new File(segmentDir, getTableName() + "_REALTIME").listFiles();
             for (File file : files) {
-              if (file.getName().contains("tmp") || file.getName().contains("consumer")) {
+              if (!file.getName().startsWith(getTableName())) {

Review Comment:
   aah, basically apart from the segment directories, pinot also creates multiple other directories. I simply wanted to exclude them as they don't contain immutable segments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org