You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/03 06:18:40 UTC
[GitHub] [flink] caidezhi commented on a change in pull request #10328:
[FLINK-14962] fix findbugs WMI_WRONG_MAP_ITERATOR warning
caidezhi commented on a change in pull request #10328: [FLINK-14962] fix findbugs WMI_WRONG_MAP_ITERATOR warning
URL: https://github.com/apache/flink/pull/10328#discussion_r353000554
##########
File path: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
##########
@@ -893,11 +892,10 @@ private void handlePendingFilesForPreviousCheckpoints(Map<Long, List<String>> pe
LOG.debug("Moving pending files to final location on restore.");
- Set<Long> pastCheckpointIds = pendingFilesPerCheckpoint.keySet();
- for (Long pastCheckpointId : pastCheckpointIds) {
- // All the pending files are buckets that have been completed but are waiting to be renamed
- // to their final name
- for (String filename : pendingFilesPerCheckpoint.get(pastCheckpointId)) {
+ for (Map.Entry<Long, List<String>> entry : pendingFilesPerCheckpoint.entrySet()) {
+ Long pastCheckpointId = entry.getKey();
Review comment:
Kurt, thanks for reviewing. I add back the original comments as you suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services