[GitHub] stevedlawrence commented on a change in pull request #26: Daffodil 1773 - ambiguous names rebase changes - extension of PR 23

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #26: Daffodil 1773 - ambiguous names rebase changes - extension of PR 23
URL: https://github.com/apache/incubator-daffodil/pull/26#discussion_r161835003
 
 

 ##########
 File path: daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/dsom/CompiledExpression1.scala
 ##########
 @@ -383,13 +392,61 @@ class DPathElementCompileInfo(
         matchesERD
       }
 
+    //
+    // We must indicate for all children having this path step as their name
 
 Review comment:
   I'm kindof iffy on this. Technically, I'm not sure findNamedMatch is the right place for this, since there could be code that's trying to find a named match but for whatever reason they aren't used in an expression. I don't think that's the case, but the name doesn't really imply there will be side effects.
   
   Perhaps just add a TODO to remove this when query-style expressions are supported? I think when query style expression are supported this function will return a Seq of matches, and then the caller can mark isReferencedByExpression as appropriate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services