You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2023/01/30 06:45:48 UTC
[GitHub] [hudi] yihua opened a new pull request, #7790: [HUDI-5632] Fix failure launching Spark jobs from `hudi-cli-bundle`
yihua opened a new pull request, #7790:
URL: https://github.com/apache/hudi/pull/7790
### Change Logs
The Hudi CLI commands which require launching Spark cannot be executed in Hudi CLI shell with hudi-cli-bundle:
```
savepoint create --commit <latest-commit-timestamp> --sparkMaster local
savepoint delete --commit <latest-commit-timestamp> --sparkMaster local
savepoint create --commit <latest-commit-timestamp> --sparkMaster local
downgrade table --toVersion 3 --sparkMaster local
upgrade table --toVersion 5 --sparkMaster local
compaction schedule --hoodieConfigs hoodie.compact.inline.max.delta.commits=1
```
Sample error message:
```
30977 [Thread-4] INFO org.apache.hudi.cli.utils.InputStreamConsumer [] - Error: Failed to load org.apache.hudi.cli.commands.SparkMain: org/apache/hudi/common/engine/HoodieEngineContext
```
The root cause is that the `hudi-cli-bundle` excludes the classes already in `hudi-spark*-bundle`, such as in `hudi-common` module, and the `hudi-spark*-bundle` is not added to the Spark launcher, so that the Spark job fails due to class not found.
This PR fixes the problem by adding the `hudi-spark*-bundle` specified by env variable `SPARK_BUNDLE_JAR` to the Spark launcher. Note that `SPARK_BUNDLE_JAR` is required when using `hudi-cli-bundle`.
### Impact
Ensures that Hudi CLI commands which require launching Spark can be executed with `hudi-cli-bundle`. The above CLI commands are tested to be working locally when this fix.
### Risk level
low
### Documentation Update
N/A
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7790: [HUDI-5632] Fix failure launching Spark jobs from `hudi-cli-bundle`
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7790:
URL: https://github.com/apache/hudi/pull/7790#issuecomment-1408084890
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8e01aae6f0dfb7b11e73cdff30fcbd17536ac8cf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8e01aae6f0dfb7b11e73cdff30fcbd17536ac8cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8e01aae6f0dfb7b11e73cdff30fcbd17536ac8cf UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7790: [HUDI-5632] Fix failure launching Spark jobs from `hudi-cli-bundle`
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7790:
URL: https://github.com/apache/hudi/pull/7790#issuecomment-1408297096
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8e01aae6f0dfb7b11e73cdff30fcbd17536ac8cf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14764",
"triggerID" : "8e01aae6f0dfb7b11e73cdff30fcbd17536ac8cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8e01aae6f0dfb7b11e73cdff30fcbd17536ac8cf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14764)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7790: [HUDI-5632] Fix failure launching Spark jobs from `hudi-cli-bundle`
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7790:
URL: https://github.com/apache/hudi/pull/7790#issuecomment-1408150732
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8e01aae6f0dfb7b11e73cdff30fcbd17536ac8cf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14764",
"triggerID" : "8e01aae6f0dfb7b11e73cdff30fcbd17536ac8cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8e01aae6f0dfb7b11e73cdff30fcbd17536ac8cf Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14764)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #7790: [HUDI-5632] Fix failure launching Spark jobs from `hudi-cli-bundle`
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #7790:
URL: https://github.com/apache/hudi/pull/7790#issuecomment-1408078217
@rahil-c could you review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #7790: [HUDI-5632] Fix failure launching Spark jobs from `hudi-cli-bundle`
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan merged PR #7790:
URL: https://github.com/apache/hudi/pull/7790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] rahil-c commented on pull request #7790: [HUDI-5632] Fix failure launching Spark jobs from `hudi-cli-bundle`
Posted by "rahil-c (via GitHub)" <gi...@apache.org>.
rahil-c commented on PR #7790:
URL: https://github.com/apache/hudi/pull/7790#issuecomment-1409098376
Thanks for helping with this @yihua
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org