You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/04/10 04:45:25 UTC
Review Request 70441: Made CSI volume managers no longer maintain a
list of services.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70441/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
Since the service manager is passed in, there is no need for the volume
manager to maintain a separated list of services provided by the service
manager. This patch cleans up this part and make the service manager
exposes the list of services it contains. It also add more validation
in the service manager to make the code more cohesive.
Diffs
-----
src/csi/service_manager.hpp 5dd6bc7e044670c7416e2fc452ef46a2a50a6cf5
src/csi/service_manager.cpp 0a3663cfd0dae2672a11eebcb6ffa3f8fad68ae0
src/csi/v0_volume_manager.hpp 6c15f290389dfa150edf073c6033f0580e2e32b3
src/csi/v0_volume_manager.cpp 02de17ee33193a078617210959a944501132fd5c
src/csi/v0_volume_manager_process.hpp c3cd6caa0e53bdb19213e1383f458ce7aab9485d
src/csi/v1_volume_manager.hpp f8e609501253de37b9a9fa3ae0c760329e6ecfd4
src/csi/v1_volume_manager.cpp bd334f1340be7fc3ef3faba56dfff8ffa69c2ea0
src/csi/v1_volume_manager_process.hpp 1c80399be434781401acda753ed5d69e1dc12a32
src/csi/volume_manager.hpp cc20f461868b6b578b7e55ca0df66fbe26d8cd49
src/csi/volume_manager.cpp cbe45cb439defbdd22bc57648b455e69679bdb4f
src/resource_provider/storage/provider.cpp 2dc5c26b11f3fff179b4357b0dcc149e93d4e12f
Diff: https://reviews.apache.org/r/70441/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70441: Made CSI volume managers no longer maintain
a list of services.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70441/#review214645
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70468, 70431, 70441]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 10, 2019, 12:45 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70441/
> -----------------------------------------------------------
>
> (Updated April 10, 2019, 12:45 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the service manager is passed in, there is no need for the volume
> manager to maintain a separated list of services provided by the service
> manager. This patch cleans up this part and make the service manager
> exposes the list of services it contains. It also add more validation
> in the service manager to make the code more cohesive.
>
>
> Diffs
> -----
>
> src/csi/service_manager.hpp 5dd6bc7e044670c7416e2fc452ef46a2a50a6cf5
> src/csi/service_manager.cpp 0a3663cfd0dae2672a11eebcb6ffa3f8fad68ae0
> src/csi/v0_volume_manager.hpp 6c15f290389dfa150edf073c6033f0580e2e32b3
> src/csi/v0_volume_manager.cpp 02de17ee33193a078617210959a944501132fd5c
> src/csi/v0_volume_manager_process.hpp c3cd6caa0e53bdb19213e1383f458ce7aab9485d
> src/csi/v1_volume_manager.hpp f8e609501253de37b9a9fa3ae0c760329e6ecfd4
> src/csi/v1_volume_manager.cpp bd334f1340be7fc3ef3faba56dfff8ffa69c2ea0
> src/csi/v1_volume_manager_process.hpp 1c80399be434781401acda753ed5d69e1dc12a32
> src/csi/volume_manager.hpp cc20f461868b6b578b7e55ca0df66fbe26d8cd49
> src/csi/volume_manager.cpp cbe45cb439defbdd22bc57648b455e69679bdb4f
> src/resource_provider/storage/provider.cpp 2dc5c26b11f3fff179b4357b0dcc149e93d4e12f
>
>
> Diff: https://reviews.apache.org/r/70441/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70441: Made CSI volume managers no longer maintain
a list of services.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70441/#review215009
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70468, 70431, 70441]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 9, 2019, 9:45 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70441/
> -----------------------------------------------------------
>
> (Updated April 9, 2019, 9:45 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the service manager is passed in, there is no need for the volume
> manager to maintain a separated list of services provided by the service
> manager. This patch cleans up this part and make the service manager
> exposes the list of services it contains. It also add more validation
> in the service manager to make the code more cohesive.
>
>
> Diffs
> -----
>
> src/csi/service_manager.hpp 5dd6bc7e044670c7416e2fc452ef46a2a50a6cf5
> src/csi/service_manager.cpp 0a3663cfd0dae2672a11eebcb6ffa3f8fad68ae0
> src/csi/v0_volume_manager.hpp 6c15f290389dfa150edf073c6033f0580e2e32b3
> src/csi/v0_volume_manager.cpp 02de17ee33193a078617210959a944501132fd5c
> src/csi/v0_volume_manager_process.hpp c3cd6caa0e53bdb19213e1383f458ce7aab9485d
> src/csi/v1_volume_manager.hpp f8e609501253de37b9a9fa3ae0c760329e6ecfd4
> src/csi/v1_volume_manager.cpp bd334f1340be7fc3ef3faba56dfff8ffa69c2ea0
> src/csi/v1_volume_manager_process.hpp 1c80399be434781401acda753ed5d69e1dc12a32
> src/csi/volume_manager.hpp cc20f461868b6b578b7e55ca0df66fbe26d8cd49
> src/csi/volume_manager.cpp cbe45cb439defbdd22bc57648b455e69679bdb4f
> src/resource_provider/storage/provider.cpp 2dc5c26b11f3fff179b4357b0dcc149e93d4e12f
>
>
> Diff: https://reviews.apache.org/r/70441/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70441: Made CSI volume managers no longer maintain
a list of services.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70441/#review214567
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70431', '70441']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3151/mesos-review-70441
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3151/mesos-review-70441/logs/mesos-tests.log):
```
I0411 05:52:35.225239 51544 master.cpp:1295] Agent b1b42f6a-61ea-414a-9d92-eb0a3cb81d38-S0 at slave(501)@192.10.1.4:61911 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0411 05:52:35.226070 51544 master.cpp:3333] Disconnecting agent b1b42f6a-61ea-414a-9d92-eb0a3cb81d38-S0 at slave(501)@192.10.1.4:61911 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0411 05:52:35.226070 51544 master.cpp:3352] Deactivating agent b1b42f6a-61ea-414a-9d92-eb0a3cb81d38-S0 at slave(501)@192.10.1.4:61911 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0411 05:52:35.226070 47260 containerizer.cpp:2576] Destroying container 64b55d90-154d-4c81-b5a1-d0dc6d2e2c92 in RUNNING state
I0411 05:52:35.226070 47260 containerizer.cpp:3278] Transitioning the state of container 64b55d90-154d-4c81-b5a1-d0dc6d2e2c92 from RUNNING to DESTROYING
I0411 05:52:35.226070 45916 hierarchical.cpp:392] Removed framework b1b42f6a-61ea-414a-9d92-eb0a3cb81d38-0000
I0411 05:52:35.227079 45916 hierarchical.cpp:829] Agent b1b42f6a-61ea-414a-9d92-eb0a3cb81d38-S0 deactivated
I0411 05:52:35.227079 47260 launcher.cpp:161] Asked to destroy container 64b55d90-154d-4c81-b5a1-d0dc6d2e2c92
W0411 05:52:35.228080 51848 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=12508 to peer '192.10.1.4:64315': IO failed with error code: The specified network name is no longer available.
W0411 05:52:35.229076 51848 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=12504 to pe[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (791 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (809 ms total)
[----------] Global test environment tear-down
[==========] 1159 tests from 108 test cases ran. (595085 ms total)
[ PASSED ] 1157 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName
2 FAILED TESTS
YOU HAVE 233 DISABLED TESTS
er '192.10.1.4:64316': IO failed with error code: The specified network name is no longer available.
I0411 05:52:35.300120 45828 containerizer.cpp:3117] Container 64b55d90-154d-4c81-b5a1-d0dc6d2e2c92 has exited
I0411 05:52:35.331094 49124 master.cpp:1135] Master terminating
I0411 05:52:35.333611 49404 hierarchical.cpp:680] Removed agent b1b42f6a-61ea-414a-9d92-eb0a3cb81d38-S0
I0411 05:52:35.992130 51848 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On April 10, 2019, 4:45 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70441/
> -----------------------------------------------------------
>
> (Updated April 10, 2019, 4:45 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the service manager is passed in, there is no need for the volume
> manager to maintain a separated list of services provided by the service
> manager. This patch cleans up this part and make the service manager
> exposes the list of services it contains. It also add more validation
> in the service manager to make the code more cohesive.
>
>
> Diffs
> -----
>
> src/csi/service_manager.hpp 5dd6bc7e044670c7416e2fc452ef46a2a50a6cf5
> src/csi/service_manager.cpp 0a3663cfd0dae2672a11eebcb6ffa3f8fad68ae0
> src/csi/v0_volume_manager.hpp 6c15f290389dfa150edf073c6033f0580e2e32b3
> src/csi/v0_volume_manager.cpp 02de17ee33193a078617210959a944501132fd5c
> src/csi/v0_volume_manager_process.hpp c3cd6caa0e53bdb19213e1383f458ce7aab9485d
> src/csi/v1_volume_manager.hpp f8e609501253de37b9a9fa3ae0c760329e6ecfd4
> src/csi/v1_volume_manager.cpp bd334f1340be7fc3ef3faba56dfff8ffa69c2ea0
> src/csi/v1_volume_manager_process.hpp 1c80399be434781401acda753ed5d69e1dc12a32
> src/csi/volume_manager.hpp cc20f461868b6b578b7e55ca0df66fbe26d8cd49
> src/csi/volume_manager.cpp cbe45cb439defbdd22bc57648b455e69679bdb4f
> src/resource_provider/storage/provider.cpp 2dc5c26b11f3fff179b4357b0dcc149e93d4e12f
>
>
> Diff: https://reviews.apache.org/r/70441/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70441: Made CSI volume managers no longer maintain
a list of services.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70441/#review214644
-----------------------------------------------------------
PASS: Mesos patch 70441 was successfully built and tested.
Reviews applied: `['70468', '70431', '70441']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3158/mesos-review-70441
- Mesos Reviewbot Windows
On April 9, 2019, 9:45 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70441/
> -----------------------------------------------------------
>
> (Updated April 9, 2019, 9:45 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the service manager is passed in, there is no need for the volume
> manager to maintain a separated list of services provided by the service
> manager. This patch cleans up this part and make the service manager
> exposes the list of services it contains. It also add more validation
> in the service manager to make the code more cohesive.
>
>
> Diffs
> -----
>
> src/csi/service_manager.hpp 5dd6bc7e044670c7416e2fc452ef46a2a50a6cf5
> src/csi/service_manager.cpp 0a3663cfd0dae2672a11eebcb6ffa3f8fad68ae0
> src/csi/v0_volume_manager.hpp 6c15f290389dfa150edf073c6033f0580e2e32b3
> src/csi/v0_volume_manager.cpp 02de17ee33193a078617210959a944501132fd5c
> src/csi/v0_volume_manager_process.hpp c3cd6caa0e53bdb19213e1383f458ce7aab9485d
> src/csi/v1_volume_manager.hpp f8e609501253de37b9a9fa3ae0c760329e6ecfd4
> src/csi/v1_volume_manager.cpp bd334f1340be7fc3ef3faba56dfff8ffa69c2ea0
> src/csi/v1_volume_manager_process.hpp 1c80399be434781401acda753ed5d69e1dc12a32
> src/csi/volume_manager.hpp cc20f461868b6b578b7e55ca0df66fbe26d8cd49
> src/csi/volume_manager.cpp cbe45cb439defbdd22bc57648b455e69679bdb4f
> src/resource_provider/storage/provider.cpp 2dc5c26b11f3fff179b4357b0dcc149e93d4e12f
>
>
> Diff: https://reviews.apache.org/r/70441/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>