You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by MLnick <gi...@git.apache.org> on 2018/01/17 10:13:39 UTC

[GitHub] spark pull request #20293: [SPARK-23127][DOC] Update FeatureHasher guide for...

GitHub user MLnick opened a pull request:

    https://github.com/apache/spark/pull/20293

    [SPARK-23127][DOC] Update FeatureHasher guide for categoricalCols parameter

    Update user guide entry for `FeatureHasher` to match the Scala / Python doc, to describe the `categoricalCols` parameter.
    
    ## How was this patch tested?
    
    Doc only


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MLnick/spark SPARK-23127-catCol-userguide

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20293.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20293
    
----
commit a6c11d9f92729ec6cb42ad345d3ef9d0b46719bd
Author: Nick Pentreath <ni...@...>
Date:   2018-01-17T10:10:53Z

    Update FeatureHasher guide for categoricalCols param

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20293: [SPARK-23127][DOC] Update FeatureHasher guide for catego...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20293
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86261/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20293: [SPARK-23127][DOC] Update FeatureHasher guide for catego...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20293
  
    **[Test build #86261 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86261/testReport)** for PR 20293 at commit [`a6c11d9`](https://github.com/apache/spark/commit/a6c11d9f92729ec6cb42ad345d3ef9d0b46719bd).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20293: [SPARK-23127][DOC] Update FeatureHasher guide for catego...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20293
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20293: [SPARK-23127][DOC] Update FeatureHasher guide for catego...

Posted by MLnick <gi...@git.apache.org>.

Github user MLnick commented on the issue:

    https://github.com/apache/spark/pull/20293
  
    Merged to master / branch-2.3


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20293: [SPARK-23127][DOC] Update FeatureHasher guide for catego...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20293
  
    **[Test build #86261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86261/testReport)** for PR 20293 at commit [`a6c11d9`](https://github.com/apache/spark/commit/a6c11d9f92729ec6cb42ad345d3ef9d0b46719bd).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20293: [SPARK-23127][DOC] Update FeatureHasher guide for...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/20293


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org