You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/02/05 19:53:04 UTC
[GitHub] saandrews commented on a change in pull request #1169: Proxy forward auth data
saandrews commented on a change in pull request #1169: Proxy forward auth data
URL: https://github.com/apache/incubator-pulsar/pull/1169#discussion_r166090076
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -385,8 +465,11 @@ protected void handleConnect(CommandConnect connect) {
if (sslHandler != null) {
sslSession = ((SslHandler) sslHandler).engine().getSession();
}
-
- originalPrincipal = connect.hasOriginalPrincipal() ? connect.getOriginalPrincipal() : null;
+ originalPrincipal = getOriginalPrincipal(
+ connect.hasOriginalAuthData() ? connect.getOriginalAuthData() : null,
+ connect.hasOriginalAuthMethod() ? connect.getOriginalAuthMethod() : null,
+ connect.hasOriginalPrincipal() ? connect.getOriginalPrincipal() : null,
+ sslSession);
Review comment:
What happens if sslSession is null ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services