You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/22 14:07:00 UTC

[GitHub] [arrow] romainfrancois commented on a change in pull request #11751: ARROW-14694: [R] Let me dput a schema

romainfrancois commented on a change in pull request #11751:
URL: https://github.com/apache/arrow/pull/11751#discussion_r754310306



##########
File path: r/R/type.R
##########
@@ -40,7 +40,8 @@ DataType <- R6Class("DataType",
     fields = function() {
       DataType__fields(self)
     },
-    export_to_c = function(ptr) ExportType(self, ptr)
+    export_to_c = function(ptr) ExportType(self, ptr),
+    code = function() call2("unknown_type", self$ToString())

Review comment:
       Probably no longer needed. 
   
   It's just so that when it's not implemented for a type, at least you get something. Perhaps that can be replaced by a call to `abort()` instead of giving a call to a function that does not exist ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org