You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/22 00:34:13 UTC

[GitHub] [beam] apilloud commented on pull request #12389: [BEAM-10587] Support Maps in BigQuery

apilloud commented on pull request #12389:
URL: https://github.com/apache/beam/pull/12389#issuecomment-696452519


   Still looks good, here are the remaining items:
   1. We need to figure out [implicitly converting RECORD/STRUCT type to MAP](https://github.com/apache/beam/pull/12389#discussion_r470756034). This has some far reaching impacts, so about sending a email to dev@beam.apache.org explaining what you are doing?
   2. Add this to an integration test with BigQuery. This file would probably be an easy place to add tests (it also includes Beam SQL):
   https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BigQueryReadWriteIT.java


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org