[GitHub] mehulhirpara commented on issue #160: Added fixes to make NimBLE work with all ported OS

[GitBox <gi...@apache.org>]

mehulhirpara commented on issue #160:  Added fixes to make NimBLE work with all ported OS
URL: https://github.com/apache/mynewt-nimble/pull/160#issuecomment-411992766
 
 
   Yes, you are right. I do have extra code in my porting layer to handle minimum requirements of config module. Following is the structure for the same:
   
   npl/<os>/include/config/config.h
   npl/<os>/src/nimble_config_settings.c
   
   nimble_config_settings.c implements only following APIs in different way than config module in Mynewt.
   
   conf_init()
   conf_register()
   conf_save_one()
   conf_load()
   
   Apart from this, glue.c also needs base64.h from base64 module. Since base64 module is independent of  OS, I am use it as it is from ext/base64.
   
   Regarding version change, I could not able to understand how it went with pull request as I was seeing only two file changes while committing. Let me check how I can exclude it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services