You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Matt <mi...@gmail.com> on 2016/03/04 03:05:15 UTC
Review Request 44375: Add theme and meta-data for HAWQ configurations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44375/
-----------------------------------------------------------
Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Lav Jain, and Newton Alex.
Bugs: AMBARI-15107
https://issues.apache.org/jira/browse/AMBARI-15107
Repository: ambari
Description
-------
Add theme for HAWQ
Diffs
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml 58bfa27
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-limits-env.xml d8917e6
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml 457c1d2
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml 32ae5a5
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml 053f108
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/yarn-client.xml a2296a1
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml a772839
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json PRE-CREATION
Diff: https://reviews.apache.org/r/44375/diff/
Testing
-------
Manully Tested on live cluster.
Thanks,
Matt
Re: Review Request 44375: Add theme and meta-data for HAWQ
configurations
Posted by Matt <mi...@gmail.com>.
> On March 4, 2016, 5:41 p.m., jun aoki wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml, line 153
> > <https://reviews.apache.org/r/44375/diff/1/?file=1280362#file1280362line153>
> >
> > Could we have <description> ?
Will be coming back for updating descriptions on this JIRA: https://issues.apache.org/jira/browse/AMBARI-15311
Besides, the description nested under <entry> doesn't show up on the UI. I've added the information to the property description, which shows up as a tooltip.
> On March 4, 2016, 5:41 p.m., jun aoki wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml, line 251
> > <https://reviews.apache.org/r/44375/diff/1/?file=1280363#file1280363line251>
> >
> > Trivial, but HAWQ users are so used to talk about "vm.overcommit_memory", and they may Ctrl-F or search that exact keyword, instead of "VM Overcommit". Did you want to add "aka vm.overcommit_memory" in somewhere? It could be in <description>
Users cannot do Ctrl-F on the webpage (UI) and expect to find vm.overcommit_memory even if I add it in the description - the description comes up as a tooltip which is not accesible by Ctrl-F. Users will be able to search for vm.overcommit_memory in Ambari's config search box.
> On March 4, 2016, 5:41 p.m., jun aoki wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml, line 203
> > <https://reviews.apache.org/r/44375/diff/1/?file=1280364#file1280364line203>
> >
> > Could we have <description> ?
Will be coming back for updating descriptions on this JIRA: https://issues.apache.org/jira/browse/AMBARI-15311
The description nested under <entry> doesn't show up on the UI.
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44375/#review122164
-----------------------------------------------------------
On March 3, 2016, 6:05 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44375/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 6:05 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Lav Jain, and Newton Alex.
>
>
> Bugs: AMBARI-15107
> https://issues.apache.org/jira/browse/AMBARI-15107
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add theme for HAWQ
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml 58bfa27
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-limits-env.xml d8917e6
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml 457c1d2
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml 32ae5a5
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml 053f108
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/yarn-client.xml a2296a1
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml a772839
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44375/diff/
>
>
> Testing
> -------
>
> Manully Tested on live cluster.
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 44375: Add theme and meta-data for HAWQ
configurations
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44375/#review122164
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml (line 153)
<https://reviews.apache.org/r/44375/#comment184062>
Could we have <description> ?
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml (line 249)
<https://reviews.apache.org/r/44375/#comment184065>
Trivial, but HAWQ users are so used to talk about "vm.overcommit_memory", and they may Ctrl-F or search that exact keyword, instead of "VM Overcommit". Did you want to add "aka vm.overcommit_memory" in somewhere? It could be in <description>
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml (line 153)
<https://reviews.apache.org/r/44375/#comment184064>
trivial but indentation seems off.
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml (line 203)
<https://reviews.apache.org/r/44375/#comment184061>
Could we have <description> ?
- jun aoki
On March 4, 2016, 2:05 a.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44375/
> -----------------------------------------------------------
>
> (Updated March 4, 2016, 2:05 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Lav Jain, and Newton Alex.
>
>
> Bugs: AMBARI-15107
> https://issues.apache.org/jira/browse/AMBARI-15107
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add theme for HAWQ
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml 58bfa27
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-limits-env.xml d8917e6
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml 457c1d2
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml 32ae5a5
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml 053f108
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/yarn-client.xml a2296a1
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml a772839
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44375/diff/
>
>
> Testing
> -------
>
> Manully Tested on live cluster.
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 44375: Add theme and meta-data for HAWQ
configurations
Posted by jun aoki <ju...@gmail.com>.
> On March 5, 2016, 1:41 a.m., jun aoki wrote:
> > Ship It!
LGTM except comments above.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44375/#review122166
-----------------------------------------------------------
On March 4, 2016, 2:05 a.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44375/
> -----------------------------------------------------------
>
> (Updated March 4, 2016, 2:05 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Lav Jain, and Newton Alex.
>
>
> Bugs: AMBARI-15107
> https://issues.apache.org/jira/browse/AMBARI-15107
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add theme for HAWQ
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml 58bfa27
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-limits-env.xml d8917e6
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml 457c1d2
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml 32ae5a5
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml 053f108
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/yarn-client.xml a2296a1
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml a772839
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44375/diff/
>
>
> Testing
> -------
>
> Manully Tested on live cluster.
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 44375: Add theme and meta-data for HAWQ
configurations
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44375/#review122166
-----------------------------------------------------------
Ship it!
Ship It!
- jun aoki
On March 4, 2016, 2:05 a.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44375/
> -----------------------------------------------------------
>
> (Updated March 4, 2016, 2:05 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, jun aoki, Lav Jain, and Newton Alex.
>
>
> Bugs: AMBARI-15107
> https://issues.apache.org/jira/browse/AMBARI-15107
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add theme for HAWQ
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-check-env.xml 58bfa27
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-limits-env.xml d8917e6
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml 457c1d2
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml 32ae5a5
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hdfs-client.xml 053f108
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/yarn-client.xml a2296a1
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml a772839
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44375/diff/
>
>
> Testing
> -------
>
> Manully Tested on live cluster.
>
>
> Thanks,
>
> Matt
>
>