You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/07/01 07:15:03 UTC
Re: Review Request 70891: Wrapped launcher in `LauncherTracker`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70891/#review216262
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp
Lines 347-349 (patched)
<https://reviews.apache.org/r/70891/#comment303392>
Can we merge these into a single line?
- Qian Zhang
On June 19, 2019, 10:49 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70891/
> -----------------------------------------------------------
>
> (Updated June 19, 2019, 10:49 p.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-9841
> https://issues.apache.org/jira/browse/MESOS-9841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch wraps a container launcher in instance of `LauncherTracker`
> class. If the launcher gets stuck in some operation, `pendingFutures`
> will return the method name along with its arguments such as
> `containerId`, `pid`, etc.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 043244841a73fa3f5f7119bc38f6d3a04be8990b
>
>
> Diff: https://reviews.apache.org/r/70891/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 70891: Wrapped launcher in `LauncherTracker`.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On Июль 1, 2019, 7:15 д.п., Qian Zhang wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Lines 347-349 (patched)
> > <https://reviews.apache.org/r/70891/diff/1/?file=2151369#file2151369line347>
> >
> > Can we merge these into a single line?
Updated this code a bit. Not sure if we need to merge these into a single line now. Could you please take a look at this code once again?
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70891/#review216262
-----------------------------------------------------------
On Июнь 19, 2019, 2:49 п.п., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70891/
> -----------------------------------------------------------
>
> (Updated Июнь 19, 2019, 2:49 п.п.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-9841
> https://issues.apache.org/jira/browse/MESOS-9841
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch wraps a container launcher in instance of `LauncherTracker`
> class. If the launcher gets stuck in some operation, `pendingFutures`
> will return the method name along with its arguments such as
> `containerId`, `pid`, etc.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp c9a369bcdbfc1676912430c3e84fa567bbd7f766
>
>
> Diff: https://reviews.apache.org/r/70891/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>