[jira] Commented: (QPID-1528) Get/Set attributes on objects

["Rob Godfrey (JIRA)" <qp...@incubator.apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662323#action_12662323 ] 

Rob Godfrey commented on QPID-1528:
-----------------------------------

CommandLineInterpreter.java:

+                    if (args[i].compareTo("list") == 0 ||
+                        args[i].compareTo("info") == 0 ||
+                        args[i].compareTo("view") == 0 ||
+                        args[i].compareTo("viewcontent") == 0 ||
+                        args[i].compareTo("delete") == 0 ||
+                        args[i].compareTo("move") == 0 ||
+                        args[i].compareTo("set") == 0 ||
+                        args[i].compareTo("get") == 0)
+                    {

1) Surely these names should be constants
2) Maybe define a constant HashSet and then if(permiitedCommandsSet.contains(args[i]))

+                    new SimpleCompletor(new String[]{"get","set","list", "info", "exit", "quit", "delete", "move", "view",
+                                                     "viewcontent", "queue", "exchange", "connection", "usermanagement",
+                                                     "virtualhost"})));

Again, surely these should be constants?  And the array itself a constant too?


ObjectNames.java:

+            return mbsc.getAttribute(object, attribute);
+        }
+        catch (Exception e)
+        {
+            e.printStackTrace();
+        }

is this the appropriate way to handle exceptions here?



> Get/Set attributes on objects
> -----------------------------
>
>                 Key: QPID-1528
>                 URL: https://issues.apache.org/jira/browse/QPID-1528
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Management : CLI Tool
>            Reporter: Aidan Skinner
>            Assignee: Aidan Skinner
>
> It would be useful to be able to get and set attributes on objects via the CLI such as MaximumMessageAge etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.