You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Hongchao Deng <hd...@cloudera.com> on 2015/02/03 20:09:51 UTC
Review Request 30573: ZOOKEEPER-1366: Zookeeper should be tolerant of
clock adjustments
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30573/
-----------------------------------------------------------
Review request for zookeeper.
Repository: zookeeper-git
Description
-------
Zookeeper should be tolerant of clock adjustments
Diffs
-----
src/java/main/org/apache/zookeeper/ClientCnxn.java c85cc8d1b6dae0c0d0850d758420fb31a8dd1dcc
src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 16cb9120686bf982b4c68a0172600d23b6119042
src/java/main/org/apache/zookeeper/Login.java 6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b
src/java/main/org/apache/zookeeper/Shell.java 62169d797a7a103d921634c4676fffea878def51
src/java/main/org/apache/zookeeper/ZKUtil.java 4713a08a934175c2b297f69740e204c7288c078c
src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION
src/java/main/org/apache/zookeeper/server/ExpiryQueue.java a037bf49235e386cc20ee68633ec162b1db013d1
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java a97be4a5452006fbd85d355c0dcb16276cbf1c59
src/java/main/org/apache/zookeeper/server/RateLogger.java fc951cf5147bedbf1786ff1047a1e1a5fd7f5121
src/java/main/org/apache/zookeeper/server/Request.java ee01dcfa63784a9dd380f91d768e1b3f28b9cce9
src/java/main/org/apache/zookeeper/server/ServerStats.java c3246293e409d863412144ed76b2a91ca1ac98f2
src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 0c2c042e276c557a86f47d7ab5333e6860e12bd9
src/java/main/org/apache/zookeeper/server/WorkerService.java c55ff48f92e5e3ae7783ad5be0262a5d9899c521
src/java/main/org/apache/zookeeper/server/ZKDatabase.java f336049f0afb7b539460223b4903d323e2558aed
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 30a0ed390bb7473ddb36757da97bc7d5f4281887
src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f
src/java/main/org/apache/zookeeper/server/quorum/Follower.java 6dbb0b22a4e0658a6b04629e6efdf1ac722375e5
src/java/main/org/apache/zookeeper/server/quorum/Leader.java 20589045752a7ba4ae9c9090055a4fcbe86a8eda
src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java 97b48915321aab6ea31bd7db8fe1197165507feb
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de
src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 4092c760f2cc4eda410ac6125e58ec399d1a6ca4
src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 809fa4819eed61aee3fcee1b5641ec85b967d479
src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3
src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 9abe47910f5d73195c57e9f33d9d2150a4861141
src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb
src/java/test/org/apache/zookeeper/test/ClientHammerTest.java b807dbb0f4350b29190b5d5862c418de84a168c5
src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 563c77c41c86c692edfd95ea48d397bc25154d26
src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ab84146f58e8f97ef24517703c30ef6015a71c84
src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 0579858659cec892aee3fa4362d0c55d175d87a7
src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java bf1dcef7fbca91fee6128096e8413013fa11e0e0
src/java/test/org/apache/zookeeper/test/TestHammer.java 09a678b28c1915d419d586dfc6a523060b1df1aa
src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 5386a7a910686a44cbe33f5ac18674d92b6aad44
Diff: https://reviews.apache.org/r/30573/diff/
Testing
-------
Thanks,
Hongchao Deng
Re: Review Request 30573: ZOOKEEPER-1366: Zookeeper should be
tolerant of clock adjustments
Posted by Hongchao Deng <hd...@cloudera.com>.
> On Feb. 5, 2015, 4:12 p.m., Marshall McMullen wrote:
> > src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 321
> > <https://reviews.apache.org/r/30573/diff/5/?file=849386#file849386line321>
> >
> > Is it worth changing callers of ZooKeeperServer.java's getTime to instead call into the new Time.currentWallTime for increased clarity? Or is that a LOT of refactoring? I confess I didn't look.
I agree with it!
- Hongchao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30573/#review71222
-----------------------------------------------------------
On Feb. 5, 2015, 12:37 a.m., Hongchao Deng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30573/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 12:37 a.m.)
>
>
> Review request for zookeeper.
>
>
> Repository: zookeeper-git
>
>
> Description
> -------
>
> Zookeeper should be tolerant of clock adjustments
>
>
> Diffs
> -----
>
> src/java/main/org/apache/zookeeper/ClientCnxn.java c85cc8d1b6dae0c0d0850d758420fb31a8dd1dcc
> src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 16cb9120686bf982b4c68a0172600d23b6119042
> src/java/main/org/apache/zookeeper/Login.java 6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b
> src/java/main/org/apache/zookeeper/Shell.java 62169d797a7a103d921634c4676fffea878def51
> src/java/main/org/apache/zookeeper/ZKUtil.java 4713a08a934175c2b297f69740e204c7288c078c
> src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION
> src/java/main/org/apache/zookeeper/server/ConnectionBean.java 917aacfdcdcd50576029faab65ca98b89cfb2df9
> src/java/main/org/apache/zookeeper/server/ExpiryQueue.java a037bf49235e386cc20ee68633ec162b1db013d1
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java a97be4a5452006fbd85d355c0dcb16276cbf1c59
> src/java/main/org/apache/zookeeper/server/RateLogger.java fc951cf5147bedbf1786ff1047a1e1a5fd7f5121
> src/java/main/org/apache/zookeeper/server/Request.java ee01dcfa63784a9dd380f91d768e1b3f28b9cce9
> src/java/main/org/apache/zookeeper/server/ServerStats.java c3246293e409d863412144ed76b2a91ca1ac98f2
> src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 0c2c042e276c557a86f47d7ab5333e6860e12bd9
> src/java/main/org/apache/zookeeper/server/WorkerService.java c55ff48f92e5e3ae7783ad5be0262a5d9899c521
> src/java/main/org/apache/zookeeper/server/ZKDatabase.java f336049f0afb7b539460223b4903d323e2558aed
> src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 30a0ed390bb7473ddb36757da97bc7d5f4281887
> src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a
> src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f
> src/java/main/org/apache/zookeeper/server/quorum/Follower.java 6dbb0b22a4e0658a6b04629e6efdf1ac722375e5
> src/java/main/org/apache/zookeeper/server/quorum/Leader.java 20589045752a7ba4ae9c9090055a4fcbe86a8eda
> src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java 97b48915321aab6ea31bd7db8fe1197165507feb
> src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de
> src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 4092c760f2cc4eda410ac6125e58ec399d1a6ca4
> src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 809fa4819eed61aee3fcee1b5641ec85b967d479
> src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3
> src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION
> src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 9abe47910f5d73195c57e9f33d9d2150a4861141
> src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb
> src/java/test/org/apache/zookeeper/test/ClientHammerTest.java b807dbb0f4350b29190b5d5862c418de84a168c5
> src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 563c77c41c86c692edfd95ea48d397bc25154d26
> src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ab84146f58e8f97ef24517703c30ef6015a71c84
> src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 0579858659cec892aee3fa4362d0c55d175d87a7
> src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java bf1dcef7fbca91fee6128096e8413013fa11e0e0
> src/java/test/org/apache/zookeeper/test/TestHammer.java 09a678b28c1915d419d586dfc6a523060b1df1aa
> src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 5386a7a910686a44cbe33f5ac18674d92b6aad44
>
> Diff: https://reviews.apache.org/r/30573/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hongchao Deng
>
>
Re: Review Request 30573: ZOOKEEPER-1366: Zookeeper should be
tolerant of clock adjustments
Posted by Marshall McMullen <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30573/#review71222
-----------------------------------------------------------
src/java/main/org/apache/zookeeper/common/Time.java
<https://reviews.apache.org/r/30573/#comment116890>
I *REALLY* like the addition of the Time class. Nice abstraction layer.
src/java/main/org/apache/zookeeper/common/Time.java
<https://reviews.apache.org/r/30573/#comment116891>
Can you please format the body of this method like we normally do so it's not all on one line?
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
<https://reviews.apache.org/r/30573/#comment116893>
Is it worth changing callers of ZooKeeperServer.java's getTime to instead call into the new Time.currentWallTime for increased clarity? Or is that a LOT of refactoring? I confess I didn't look.
- Marshall McMullen
On Feb. 5, 2015, 12:37 a.m., Hongchao Deng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30573/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 12:37 a.m.)
>
>
> Review request for zookeeper.
>
>
> Repository: zookeeper-git
>
>
> Description
> -------
>
> Zookeeper should be tolerant of clock adjustments
>
>
> Diffs
> -----
>
> src/java/main/org/apache/zookeeper/ClientCnxn.java c85cc8d1b6dae0c0d0850d758420fb31a8dd1dcc
> src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 16cb9120686bf982b4c68a0172600d23b6119042
> src/java/main/org/apache/zookeeper/Login.java 6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b
> src/java/main/org/apache/zookeeper/Shell.java 62169d797a7a103d921634c4676fffea878def51
> src/java/main/org/apache/zookeeper/ZKUtil.java 4713a08a934175c2b297f69740e204c7288c078c
> src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION
> src/java/main/org/apache/zookeeper/server/ConnectionBean.java 917aacfdcdcd50576029faab65ca98b89cfb2df9
> src/java/main/org/apache/zookeeper/server/ExpiryQueue.java a037bf49235e386cc20ee68633ec162b1db013d1
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java a97be4a5452006fbd85d355c0dcb16276cbf1c59
> src/java/main/org/apache/zookeeper/server/RateLogger.java fc951cf5147bedbf1786ff1047a1e1a5fd7f5121
> src/java/main/org/apache/zookeeper/server/Request.java ee01dcfa63784a9dd380f91d768e1b3f28b9cce9
> src/java/main/org/apache/zookeeper/server/ServerStats.java c3246293e409d863412144ed76b2a91ca1ac98f2
> src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 0c2c042e276c557a86f47d7ab5333e6860e12bd9
> src/java/main/org/apache/zookeeper/server/WorkerService.java c55ff48f92e5e3ae7783ad5be0262a5d9899c521
> src/java/main/org/apache/zookeeper/server/ZKDatabase.java f336049f0afb7b539460223b4903d323e2558aed
> src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 30a0ed390bb7473ddb36757da97bc7d5f4281887
> src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a
> src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f
> src/java/main/org/apache/zookeeper/server/quorum/Follower.java 6dbb0b22a4e0658a6b04629e6efdf1ac722375e5
> src/java/main/org/apache/zookeeper/server/quorum/Leader.java 20589045752a7ba4ae9c9090055a4fcbe86a8eda
> src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java 97b48915321aab6ea31bd7db8fe1197165507feb
> src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de
> src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 4092c760f2cc4eda410ac6125e58ec399d1a6ca4
> src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 809fa4819eed61aee3fcee1b5641ec85b967d479
> src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3
> src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION
> src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 9abe47910f5d73195c57e9f33d9d2150a4861141
> src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb
> src/java/test/org/apache/zookeeper/test/ClientHammerTest.java b807dbb0f4350b29190b5d5862c418de84a168c5
> src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 563c77c41c86c692edfd95ea48d397bc25154d26
> src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ab84146f58e8f97ef24517703c30ef6015a71c84
> src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 0579858659cec892aee3fa4362d0c55d175d87a7
> src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java bf1dcef7fbca91fee6128096e8413013fa11e0e0
> src/java/test/org/apache/zookeeper/test/TestHammer.java 09a678b28c1915d419d586dfc6a523060b1df1aa
> src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 5386a7a910686a44cbe33f5ac18674d92b6aad44
>
> Diff: https://reviews.apache.org/r/30573/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hongchao Deng
>
>
Re: Review Request 30573: ZOOKEEPER-1366: Zookeeper should be
tolerant of clock adjustments
Posted by Hongchao Deng <hd...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30573/
-----------------------------------------------------------
(Updated Feb. 5, 2015, 5:31 p.m.)
Review request for zookeeper.
Repository: zookeeper-git
Description
-------
Zookeeper should be tolerant of clock adjustments
Diffs (updated)
-----
CHANGES.txt bc587349866843af3fe43a70cd3c674338495926
build.xml bb5ff4f70dc7cf93d42b67b80885c13fd4c4f13c
src/docs/src/documentation/content/xdocs/recipes.xml f977a543be9b8a7bb9529ebc102b8a04980acac7
src/docs/src/documentation/content/xdocs/releasenotes.xml 41f079450f3f1067c12344daf9a869a3607ce8a6
src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 202051f1f7f517b1e1a3c561c0008449ab3c48a6
src/docs/src/documentation/content/xdocs/zookeeperInternals.xml 4954123387ae69c19d2592208b663388120e445a
src/docs/src/documentation/content/xdocs/zookeeperObservers.xml 99f80250438699c9568d651f16afa4a7fee31b13
src/docs/src/documentation/content/xdocs/zookeeperOver.xml a2961d334d38e9752be5d7ade6eedb8c9f5fa669
src/docs/src/documentation/content/xdocs/zookeeperTutorial.xml 10b3606c842e1bd9cbcf626bfdf1ccb8c4d1ad49
src/java/main/org/apache/zookeeper/ClientCnxn.java b4ece07735d13f1114dc79add6d5f306f6916988
src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 5ca0ba77bccfcaa799e42e98f5a5f04d3f0cf0d3
src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java adb27ee843cd7ba310807dd777376a3c244ca30f
src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java PRE-CREATION
src/java/main/org/apache/zookeeper/Login.java 6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b
src/java/main/org/apache/zookeeper/Shell.java 62169d797a7a103d921634c4676fffea878def51
src/java/main/org/apache/zookeeper/ZKUtil.java 4713a08a934175c2b297f69740e204c7288c078c
src/java/main/org/apache/zookeeper/ZooKeeperTestable.java 775d1a26d881ec77eb403fc3268f14f6be26719f
src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java dbc108019493ce13cc76a0965c4a3b2cf08353d5
src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION
src/java/main/org/apache/zookeeper/server/ConnectionBean.java 917aacfdcdcd50576029faab65ca98b89cfb2df9
src/java/main/org/apache/zookeeper/server/ExpiryQueue.java a037bf49235e386cc20ee68633ec162b1db013d1
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java a97be4a5452006fbd85d355c0dcb16276cbf1c59
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 41268805fe16244aeea4db3f35f13a6987b30187
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 7a03b4b4f4f7b60fd16eca60423202006ad5833d
src/java/main/org/apache/zookeeper/server/RateLogger.java fc951cf5147bedbf1786ff1047a1e1a5fd7f5121
src/java/main/org/apache/zookeeper/server/Request.java ee01dcfa63784a9dd380f91d768e1b3f28b9cce9
src/java/main/org/apache/zookeeper/server/ServerStats.java c3246293e409d863412144ed76b2a91ca1ac98f2
src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 0c2c042e276c557a86f47d7ab5333e6860e12bd9
src/java/main/org/apache/zookeeper/server/WorkerService.java c55ff48f92e5e3ae7783ad5be0262a5d9899c521
src/java/main/org/apache/zookeeper/server/ZKDatabase.java f336049f0afb7b539460223b4903d323e2558aed
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 30a0ed390bb7473ddb36757da97bc7d5f4281887
src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f
src/java/main/org/apache/zookeeper/server/quorum/Follower.java 6dbb0b22a4e0658a6b04629e6efdf1ac722375e5
src/java/main/org/apache/zookeeper/server/quorum/Leader.java 20589045752a7ba4ae9c9090055a4fcbe86a8eda
src/java/main/org/apache/zookeeper/server/quorum/Learner.java 4dd1e947357080f3e055f3e7e2a78c979daa6ea7
src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java 97b48915321aab6ea31bd7db8fe1197165507feb
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de
src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 4092c760f2cc4eda410ac6125e58ec399d1a6ca4
src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 809fa4819eed61aee3fcee1b5641ec85b967d479
src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3
src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java 1eeca4329b8c9c0454888a629a7deba222bc6279
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 9abe47910f5d73195c57e9f33d9d2150a4861141
src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb
src/java/test/org/apache/zookeeper/test/ClientHammerTest.java b807dbb0f4350b29190b5d5862c418de84a168c5
src/java/test/org/apache/zookeeper/test/ClientTest.java dbe595c83c36f57dba6636918e2cdf9f011655e5
src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 563c77c41c86c692edfd95ea48d397bc25154d26
src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ab84146f58e8f97ef24517703c30ef6015a71c84
src/java/test/org/apache/zookeeper/test/NettyNettySuiteBase.java PRE-CREATION
src/java/test/org/apache/zookeeper/test/NettyNettySuiteHammerTest.java PRE-CREATION
src/java/test/org/apache/zookeeper/test/NettyNettySuiteTest.java PRE-CREATION
src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 0579858659cec892aee3fa4362d0c55d175d87a7
src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java bf1dcef7fbca91fee6128096e8413013fa11e0e0
src/java/test/org/apache/zookeeper/test/TestHammer.java 09a678b28c1915d419d586dfc6a523060b1df1aa
src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 5386a7a910686a44cbe33f5ac18674d92b6aad44
Diff: https://reviews.apache.org/r/30573/diff/
Testing
-------
Thanks,
Hongchao Deng
Re: Review Request 30573: ZOOKEEPER-1366: Zookeeper should be
tolerant of clock adjustments
Posted by Hongchao Deng <hd...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30573/
-----------------------------------------------------------
(Updated Feb. 5, 2015, 12:37 a.m.)
Review request for zookeeper.
Repository: zookeeper-git
Description
-------
Zookeeper should be tolerant of clock adjustments
Diffs (updated)
-----
src/java/main/org/apache/zookeeper/ClientCnxn.java c85cc8d1b6dae0c0d0850d758420fb31a8dd1dcc
src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 16cb9120686bf982b4c68a0172600d23b6119042
src/java/main/org/apache/zookeeper/Login.java 6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b
src/java/main/org/apache/zookeeper/Shell.java 62169d797a7a103d921634c4676fffea878def51
src/java/main/org/apache/zookeeper/ZKUtil.java 4713a08a934175c2b297f69740e204c7288c078c
src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION
src/java/main/org/apache/zookeeper/server/ConnectionBean.java 917aacfdcdcd50576029faab65ca98b89cfb2df9
src/java/main/org/apache/zookeeper/server/ExpiryQueue.java a037bf49235e386cc20ee68633ec162b1db013d1
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java a97be4a5452006fbd85d355c0dcb16276cbf1c59
src/java/main/org/apache/zookeeper/server/RateLogger.java fc951cf5147bedbf1786ff1047a1e1a5fd7f5121
src/java/main/org/apache/zookeeper/server/Request.java ee01dcfa63784a9dd380f91d768e1b3f28b9cce9
src/java/main/org/apache/zookeeper/server/ServerStats.java c3246293e409d863412144ed76b2a91ca1ac98f2
src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 0c2c042e276c557a86f47d7ab5333e6860e12bd9
src/java/main/org/apache/zookeeper/server/WorkerService.java c55ff48f92e5e3ae7783ad5be0262a5d9899c521
src/java/main/org/apache/zookeeper/server/ZKDatabase.java f336049f0afb7b539460223b4903d323e2558aed
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 30a0ed390bb7473ddb36757da97bc7d5f4281887
src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f
src/java/main/org/apache/zookeeper/server/quorum/Follower.java 6dbb0b22a4e0658a6b04629e6efdf1ac722375e5
src/java/main/org/apache/zookeeper/server/quorum/Leader.java 20589045752a7ba4ae9c9090055a4fcbe86a8eda
src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java 97b48915321aab6ea31bd7db8fe1197165507feb
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de
src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 4092c760f2cc4eda410ac6125e58ec399d1a6ca4
src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 809fa4819eed61aee3fcee1b5641ec85b967d479
src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3
src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 9abe47910f5d73195c57e9f33d9d2150a4861141
src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb
src/java/test/org/apache/zookeeper/test/ClientHammerTest.java b807dbb0f4350b29190b5d5862c418de84a168c5
src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 563c77c41c86c692edfd95ea48d397bc25154d26
src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ab84146f58e8f97ef24517703c30ef6015a71c84
src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 0579858659cec892aee3fa4362d0c55d175d87a7
src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java bf1dcef7fbca91fee6128096e8413013fa11e0e0
src/java/test/org/apache/zookeeper/test/TestHammer.java 09a678b28c1915d419d586dfc6a523060b1df1aa
src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 5386a7a910686a44cbe33f5ac18674d92b6aad44
Diff: https://reviews.apache.org/r/30573/diff/
Testing
-------
Thanks,
Hongchao Deng
Re: Review Request 30573: ZOOKEEPER-1366: Zookeeper should be
tolerant of clock adjustments
Posted by Hongchao Deng <hd...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30573/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 11:15 p.m.)
Review request for zookeeper.
Repository: zookeeper-git
Description
-------
Zookeeper should be tolerant of clock adjustments
Diffs (updated)
-----
src/java/main/org/apache/zookeeper/ClientCnxn.java c85cc8d1b6dae0c0d0850d758420fb31a8dd1dcc
src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 16cb9120686bf982b4c68a0172600d23b6119042
src/java/main/org/apache/zookeeper/Login.java 6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b
src/java/main/org/apache/zookeeper/Shell.java 62169d797a7a103d921634c4676fffea878def51
src/java/main/org/apache/zookeeper/ZKUtil.java 4713a08a934175c2b297f69740e204c7288c078c
src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION
src/java/main/org/apache/zookeeper/server/ConnectionBean.java 917aacfdcdcd50576029faab65ca98b89cfb2df9
src/java/main/org/apache/zookeeper/server/ExpiryQueue.java a037bf49235e386cc20ee68633ec162b1db013d1
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java a97be4a5452006fbd85d355c0dcb16276cbf1c59
src/java/main/org/apache/zookeeper/server/RateLogger.java fc951cf5147bedbf1786ff1047a1e1a5fd7f5121
src/java/main/org/apache/zookeeper/server/Request.java ee01dcfa63784a9dd380f91d768e1b3f28b9cce9
src/java/main/org/apache/zookeeper/server/ServerStats.java c3246293e409d863412144ed76b2a91ca1ac98f2
src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 0c2c042e276c557a86f47d7ab5333e6860e12bd9
src/java/main/org/apache/zookeeper/server/WorkerService.java c55ff48f92e5e3ae7783ad5be0262a5d9899c521
src/java/main/org/apache/zookeeper/server/ZKDatabase.java f336049f0afb7b539460223b4903d323e2558aed
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 30a0ed390bb7473ddb36757da97bc7d5f4281887
src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f
src/java/main/org/apache/zookeeper/server/quorum/Follower.java 6dbb0b22a4e0658a6b04629e6efdf1ac722375e5
src/java/main/org/apache/zookeeper/server/quorum/Leader.java 20589045752a7ba4ae9c9090055a4fcbe86a8eda
src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java 97b48915321aab6ea31bd7db8fe1197165507feb
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de
src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 4092c760f2cc4eda410ac6125e58ec399d1a6ca4
src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 809fa4819eed61aee3fcee1b5641ec85b967d479
src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3
src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 9abe47910f5d73195c57e9f33d9d2150a4861141
src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb
src/java/test/org/apache/zookeeper/test/ClientHammerTest.java b807dbb0f4350b29190b5d5862c418de84a168c5
src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 563c77c41c86c692edfd95ea48d397bc25154d26
src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ab84146f58e8f97ef24517703c30ef6015a71c84
src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 0579858659cec892aee3fa4362d0c55d175d87a7
src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java bf1dcef7fbca91fee6128096e8413013fa11e0e0
src/java/test/org/apache/zookeeper/test/TestHammer.java 09a678b28c1915d419d586dfc6a523060b1df1aa
src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 5386a7a910686a44cbe33f5ac18674d92b6aad44
Diff: https://reviews.apache.org/r/30573/diff/
Testing
-------
Thanks,
Hongchao Deng
Re: Review Request 30573: ZOOKEEPER-1366: Zookeeper should be
tolerant of clock adjustments
Posted by Hongchao Deng <hd...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30573/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 9:37 p.m.)
Review request for zookeeper.
Repository: zookeeper-git
Description
-------
Zookeeper should be tolerant of clock adjustments
Diffs (updated)
-----
src/java/main/org/apache/zookeeper/ClientCnxn.java c85cc8d1b6dae0c0d0850d758420fb31a8dd1dcc
src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 16cb9120686bf982b4c68a0172600d23b6119042
src/java/main/org/apache/zookeeper/Login.java 6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b
src/java/main/org/apache/zookeeper/Shell.java 62169d797a7a103d921634c4676fffea878def51
src/java/main/org/apache/zookeeper/ZKUtil.java 4713a08a934175c2b297f69740e204c7288c078c
src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION
src/java/main/org/apache/zookeeper/server/ConnectionBean.java 917aacfdcdcd50576029faab65ca98b89cfb2df9
src/java/main/org/apache/zookeeper/server/ExpiryQueue.java a037bf49235e386cc20ee68633ec162b1db013d1
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java a97be4a5452006fbd85d355c0dcb16276cbf1c59
src/java/main/org/apache/zookeeper/server/RateLogger.java fc951cf5147bedbf1786ff1047a1e1a5fd7f5121
src/java/main/org/apache/zookeeper/server/Request.java ee01dcfa63784a9dd380f91d768e1b3f28b9cce9
src/java/main/org/apache/zookeeper/server/ServerStats.java c3246293e409d863412144ed76b2a91ca1ac98f2
src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 0c2c042e276c557a86f47d7ab5333e6860e12bd9
src/java/main/org/apache/zookeeper/server/WorkerService.java c55ff48f92e5e3ae7783ad5be0262a5d9899c521
src/java/main/org/apache/zookeeper/server/ZKDatabase.java f336049f0afb7b539460223b4903d323e2558aed
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 30a0ed390bb7473ddb36757da97bc7d5f4281887
src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f
src/java/main/org/apache/zookeeper/server/quorum/Follower.java 6dbb0b22a4e0658a6b04629e6efdf1ac722375e5
src/java/main/org/apache/zookeeper/server/quorum/Leader.java 20589045752a7ba4ae9c9090055a4fcbe86a8eda
src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java 97b48915321aab6ea31bd7db8fe1197165507feb
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de
src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 4092c760f2cc4eda410ac6125e58ec399d1a6ca4
src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 809fa4819eed61aee3fcee1b5641ec85b967d479
src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3
src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 9abe47910f5d73195c57e9f33d9d2150a4861141
src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb
src/java/test/org/apache/zookeeper/test/ClientHammerTest.java b807dbb0f4350b29190b5d5862c418de84a168c5
src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 563c77c41c86c692edfd95ea48d397bc25154d26
src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ab84146f58e8f97ef24517703c30ef6015a71c84
src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 0579858659cec892aee3fa4362d0c55d175d87a7
src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java bf1dcef7fbca91fee6128096e8413013fa11e0e0
src/java/test/org/apache/zookeeper/test/TestHammer.java 09a678b28c1915d419d586dfc6a523060b1df1aa
src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 5386a7a910686a44cbe33f5ac18674d92b6aad44
Diff: https://reviews.apache.org/r/30573/diff/
Testing
-------
Thanks,
Hongchao Deng
Re: Review Request 30573: ZOOKEEPER-1366: Zookeeper should be
tolerant of clock adjustments
Posted by Hongchao Deng <hd...@cloudera.com>.
> On Feb. 4, 2015, 10:22 a.m., Rakesh R wrote:
> > src/java/main/org/apache/zookeeper/server/ExpiryQueue.java, line 53
> > <https://reviews.apache.org/r/30573/diff/2/?file=847280#file847280line53>
> >
> > There are few occurance where its using the Time#currentElapsedTime() to new Date(). This will give wrong Calendar date, how do we handle this case?
> >
> > Few examples are,
> >
> > 1) ExpiryQueue#dump(PrintWriter pwriter)
> > pwriter.print(new Date(time));
> >
> > 2) ServerBean#getLastResponseTime()
> > new Date(stats.getLastResponseTime()).toString();
>
> Hongchao Deng wrote:
> Remove them!
Addressed this by adding a new static func Time#elapsedTimeToDate().
- Hongchao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30573/#review70939
-----------------------------------------------------------
On Feb. 4, 2015, 9:37 p.m., Hongchao Deng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30573/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 9:37 p.m.)
>
>
> Review request for zookeeper.
>
>
> Repository: zookeeper-git
>
>
> Description
> -------
>
> Zookeeper should be tolerant of clock adjustments
>
>
> Diffs
> -----
>
> src/java/main/org/apache/zookeeper/ClientCnxn.java c85cc8d1b6dae0c0d0850d758420fb31a8dd1dcc
> src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 16cb9120686bf982b4c68a0172600d23b6119042
> src/java/main/org/apache/zookeeper/Login.java 6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b
> src/java/main/org/apache/zookeeper/Shell.java 62169d797a7a103d921634c4676fffea878def51
> src/java/main/org/apache/zookeeper/ZKUtil.java 4713a08a934175c2b297f69740e204c7288c078c
> src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION
> src/java/main/org/apache/zookeeper/server/ConnectionBean.java 917aacfdcdcd50576029faab65ca98b89cfb2df9
> src/java/main/org/apache/zookeeper/server/ExpiryQueue.java a037bf49235e386cc20ee68633ec162b1db013d1
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java a97be4a5452006fbd85d355c0dcb16276cbf1c59
> src/java/main/org/apache/zookeeper/server/RateLogger.java fc951cf5147bedbf1786ff1047a1e1a5fd7f5121
> src/java/main/org/apache/zookeeper/server/Request.java ee01dcfa63784a9dd380f91d768e1b3f28b9cce9
> src/java/main/org/apache/zookeeper/server/ServerStats.java c3246293e409d863412144ed76b2a91ca1ac98f2
> src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 0c2c042e276c557a86f47d7ab5333e6860e12bd9
> src/java/main/org/apache/zookeeper/server/WorkerService.java c55ff48f92e5e3ae7783ad5be0262a5d9899c521
> src/java/main/org/apache/zookeeper/server/ZKDatabase.java f336049f0afb7b539460223b4903d323e2558aed
> src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 30a0ed390bb7473ddb36757da97bc7d5f4281887
> src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a
> src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f
> src/java/main/org/apache/zookeeper/server/quorum/Follower.java 6dbb0b22a4e0658a6b04629e6efdf1ac722375e5
> src/java/main/org/apache/zookeeper/server/quorum/Leader.java 20589045752a7ba4ae9c9090055a4fcbe86a8eda
> src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java 97b48915321aab6ea31bd7db8fe1197165507feb
> src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de
> src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 4092c760f2cc4eda410ac6125e58ec399d1a6ca4
> src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 809fa4819eed61aee3fcee1b5641ec85b967d479
> src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3
> src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION
> src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 9abe47910f5d73195c57e9f33d9d2150a4861141
> src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb
> src/java/test/org/apache/zookeeper/test/ClientHammerTest.java b807dbb0f4350b29190b5d5862c418de84a168c5
> src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 563c77c41c86c692edfd95ea48d397bc25154d26
> src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ab84146f58e8f97ef24517703c30ef6015a71c84
> src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 0579858659cec892aee3fa4362d0c55d175d87a7
> src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java bf1dcef7fbca91fee6128096e8413013fa11e0e0
> src/java/test/org/apache/zookeeper/test/TestHammer.java 09a678b28c1915d419d586dfc6a523060b1df1aa
> src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 5386a7a910686a44cbe33f5ac18674d92b6aad44
>
> Diff: https://reviews.apache.org/r/30573/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hongchao Deng
>
>
Re: Review Request 30573: ZOOKEEPER-1366: Zookeeper should be
tolerant of clock adjustments
Posted by Hongchao Deng <hd...@cloudera.com>.
> On Feb. 4, 2015, 10:22 a.m., Rakesh R wrote:
> > src/java/test/org/apache/zookeeper/common/TimeTest.java, line 45
> > <https://reviews.apache.org/r/30573/diff/2/?file=847298#file847298line45>
> >
> > I didn't understand this test case. For me its failing.
The test was in previous work. I think it's used to verify the time elapse in nanoTime() and currentTimeMillis() are not very different in test machine. It seems unnecessary to me and I will remove it.
> On Feb. 4, 2015, 10:22 a.m., Rakesh R wrote:
> > src/java/main/org/apache/zookeeper/server/ExpiryQueue.java, line 53
> > <https://reviews.apache.org/r/30573/diff/2/?file=847280#file847280line53>
> >
> > There are few occurance where its using the Time#currentElapsedTime() to new Date(). This will give wrong Calendar date, how do we handle this case?
> >
> > Few examples are,
> >
> > 1) ExpiryQueue#dump(PrintWriter pwriter)
> > pwriter.print(new Date(time));
> >
> > 2) ServerBean#getLastResponseTime()
> > new Date(stats.getLastResponseTime()).toString();
Remove them!
- Hongchao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30573/#review70939
-----------------------------------------------------------
On Feb. 4, 2015, 6:23 a.m., Hongchao Deng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30573/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 6:23 a.m.)
>
>
> Review request for zookeeper.
>
>
> Repository: zookeeper-git
>
>
> Description
> -------
>
> Zookeeper should be tolerant of clock adjustments
>
>
> Diffs
> -----
>
> src/java/main/org/apache/zookeeper/ClientCnxn.java c85cc8d1b6dae0c0d0850d758420fb31a8dd1dcc
> src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 16cb9120686bf982b4c68a0172600d23b6119042
> src/java/main/org/apache/zookeeper/Login.java 6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b
> src/java/main/org/apache/zookeeper/Shell.java 62169d797a7a103d921634c4676fffea878def51
> src/java/main/org/apache/zookeeper/ZKUtil.java 4713a08a934175c2b297f69740e204c7288c078c
> src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION
> src/java/main/org/apache/zookeeper/server/ExpiryQueue.java a037bf49235e386cc20ee68633ec162b1db013d1
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java a97be4a5452006fbd85d355c0dcb16276cbf1c59
> src/java/main/org/apache/zookeeper/server/RateLogger.java fc951cf5147bedbf1786ff1047a1e1a5fd7f5121
> src/java/main/org/apache/zookeeper/server/Request.java ee01dcfa63784a9dd380f91d768e1b3f28b9cce9
> src/java/main/org/apache/zookeeper/server/ServerStats.java c3246293e409d863412144ed76b2a91ca1ac98f2
> src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 0c2c042e276c557a86f47d7ab5333e6860e12bd9
> src/java/main/org/apache/zookeeper/server/WorkerService.java c55ff48f92e5e3ae7783ad5be0262a5d9899c521
> src/java/main/org/apache/zookeeper/server/ZKDatabase.java f336049f0afb7b539460223b4903d323e2558aed
> src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 30a0ed390bb7473ddb36757da97bc7d5f4281887
> src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a
> src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f
> src/java/main/org/apache/zookeeper/server/quorum/Follower.java 6dbb0b22a4e0658a6b04629e6efdf1ac722375e5
> src/java/main/org/apache/zookeeper/server/quorum/Leader.java 20589045752a7ba4ae9c9090055a4fcbe86a8eda
> src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java 97b48915321aab6ea31bd7db8fe1197165507feb
> src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de
> src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 4092c760f2cc4eda410ac6125e58ec399d1a6ca4
> src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 809fa4819eed61aee3fcee1b5641ec85b967d479
> src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3
> src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION
> src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 9abe47910f5d73195c57e9f33d9d2150a4861141
> src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb
> src/java/test/org/apache/zookeeper/test/ClientHammerTest.java b807dbb0f4350b29190b5d5862c418de84a168c5
> src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 563c77c41c86c692edfd95ea48d397bc25154d26
> src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ab84146f58e8f97ef24517703c30ef6015a71c84
> src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 0579858659cec892aee3fa4362d0c55d175d87a7
> src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java bf1dcef7fbca91fee6128096e8413013fa11e0e0
> src/java/test/org/apache/zookeeper/test/TestHammer.java 09a678b28c1915d419d586dfc6a523060b1df1aa
> src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 5386a7a910686a44cbe33f5ac18674d92b6aad44
>
> Diff: https://reviews.apache.org/r/30573/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hongchao Deng
>
>
Re: Review Request 30573: ZOOKEEPER-1366: Zookeeper should be
tolerant of clock adjustments
Posted by Rakesh R <ra...@huawei.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30573/#review70939
-----------------------------------------------------------
src/java/main/org/apache/zookeeper/common/Time.java
<https://reviews.apache.org/r/30573/#comment116401>
add @return current time in msec.
src/java/main/org/apache/zookeeper/common/Time.java
<https://reviews.apache.org/r/30573/#comment116402>
add @return current time in msec.
src/java/main/org/apache/zookeeper/server/ExpiryQueue.java
<https://reviews.apache.org/r/30573/#comment116405>
There are few occurance where its using the Time#currentElapsedTime() to new Date(). This will give wrong Calendar date, how do we handle this case?
Few examples are,
1) ExpiryQueue#dump(PrintWriter pwriter)
pwriter.print(new Date(time));
2) ServerBean#getLastResponseTime()
new Date(stats.getLastResponseTime()).toString();
src/java/test/org/apache/zookeeper/common/TimeTest.java
<https://reviews.apache.org/r/30573/#comment116400>
I didn't understand this test case. For me its failing.
- Rakesh R
On Feb. 4, 2015, 6:23 a.m., Hongchao Deng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30573/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 6:23 a.m.)
>
>
> Review request for zookeeper.
>
>
> Repository: zookeeper-git
>
>
> Description
> -------
>
> Zookeeper should be tolerant of clock adjustments
>
>
> Diffs
> -----
>
> src/java/main/org/apache/zookeeper/ClientCnxn.java c85cc8d1b6dae0c0d0850d758420fb31a8dd1dcc
> src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 16cb9120686bf982b4c68a0172600d23b6119042
> src/java/main/org/apache/zookeeper/Login.java 6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b
> src/java/main/org/apache/zookeeper/Shell.java 62169d797a7a103d921634c4676fffea878def51
> src/java/main/org/apache/zookeeper/ZKUtil.java 4713a08a934175c2b297f69740e204c7288c078c
> src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION
> src/java/main/org/apache/zookeeper/server/ExpiryQueue.java a037bf49235e386cc20ee68633ec162b1db013d1
> src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java a97be4a5452006fbd85d355c0dcb16276cbf1c59
> src/java/main/org/apache/zookeeper/server/RateLogger.java fc951cf5147bedbf1786ff1047a1e1a5fd7f5121
> src/java/main/org/apache/zookeeper/server/Request.java ee01dcfa63784a9dd380f91d768e1b3f28b9cce9
> src/java/main/org/apache/zookeeper/server/ServerStats.java c3246293e409d863412144ed76b2a91ca1ac98f2
> src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 0c2c042e276c557a86f47d7ab5333e6860e12bd9
> src/java/main/org/apache/zookeeper/server/WorkerService.java c55ff48f92e5e3ae7783ad5be0262a5d9899c521
> src/java/main/org/apache/zookeeper/server/ZKDatabase.java f336049f0afb7b539460223b4903d323e2558aed
> src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 30a0ed390bb7473ddb36757da97bc7d5f4281887
> src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a
> src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f
> src/java/main/org/apache/zookeeper/server/quorum/Follower.java 6dbb0b22a4e0658a6b04629e6efdf1ac722375e5
> src/java/main/org/apache/zookeeper/server/quorum/Leader.java 20589045752a7ba4ae9c9090055a4fcbe86a8eda
> src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java 97b48915321aab6ea31bd7db8fe1197165507feb
> src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de
> src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 4092c760f2cc4eda410ac6125e58ec399d1a6ca4
> src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 809fa4819eed61aee3fcee1b5641ec85b967d479
> src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3
> src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION
> src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 9abe47910f5d73195c57e9f33d9d2150a4861141
> src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb
> src/java/test/org/apache/zookeeper/test/ClientHammerTest.java b807dbb0f4350b29190b5d5862c418de84a168c5
> src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 563c77c41c86c692edfd95ea48d397bc25154d26
> src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ab84146f58e8f97ef24517703c30ef6015a71c84
> src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 0579858659cec892aee3fa4362d0c55d175d87a7
> src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java bf1dcef7fbca91fee6128096e8413013fa11e0e0
> src/java/test/org/apache/zookeeper/test/TestHammer.java 09a678b28c1915d419d586dfc6a523060b1df1aa
> src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 5386a7a910686a44cbe33f5ac18674d92b6aad44
>
> Diff: https://reviews.apache.org/r/30573/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hongchao Deng
>
>
Re: Review Request 30573: ZOOKEEPER-1366: Zookeeper should be
tolerant of clock adjustments
Posted by Hongchao Deng <hd...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30573/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 6:23 a.m.)
Review request for zookeeper.
Repository: zookeeper-git
Description
-------
Zookeeper should be tolerant of clock adjustments
Diffs (updated)
-----
src/java/main/org/apache/zookeeper/ClientCnxn.java c85cc8d1b6dae0c0d0850d758420fb31a8dd1dcc
src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 16cb9120686bf982b4c68a0172600d23b6119042
src/java/main/org/apache/zookeeper/Login.java 6d248ab37a0a6b11358f5f3adc9dc363b1a9c73b
src/java/main/org/apache/zookeeper/Shell.java 62169d797a7a103d921634c4676fffea878def51
src/java/main/org/apache/zookeeper/ZKUtil.java 4713a08a934175c2b297f69740e204c7288c078c
src/java/main/org/apache/zookeeper/common/Time.java PRE-CREATION
src/java/main/org/apache/zookeeper/server/ExpiryQueue.java a037bf49235e386cc20ee68633ec162b1db013d1
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java a97be4a5452006fbd85d355c0dcb16276cbf1c59
src/java/main/org/apache/zookeeper/server/RateLogger.java fc951cf5147bedbf1786ff1047a1e1a5fd7f5121
src/java/main/org/apache/zookeeper/server/Request.java ee01dcfa63784a9dd380f91d768e1b3f28b9cce9
src/java/main/org/apache/zookeeper/server/ServerStats.java c3246293e409d863412144ed76b2a91ca1ac98f2
src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 0c2c042e276c557a86f47d7ab5333e6860e12bd9
src/java/main/org/apache/zookeeper/server/WorkerService.java c55ff48f92e5e3ae7783ad5be0262a5d9899c521
src/java/main/org/apache/zookeeper/server/ZKDatabase.java f336049f0afb7b539460223b4903d323e2558aed
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 30a0ed390bb7473ddb36757da97bc7d5f4281887
src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 6cd0af88292d9cb89652f1c6d2a80ec2726b5b6a
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java dfe692f4889a11b8a8eb3a4cbbd150ed5cac6a9f
src/java/main/org/apache/zookeeper/server/quorum/Follower.java 6dbb0b22a4e0658a6b04629e6efdf1ac722375e5
src/java/main/org/apache/zookeeper/server/quorum/Leader.java 20589045752a7ba4ae9c9090055a4fcbe86a8eda
src/java/main/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottler.java 97b48915321aab6ea31bd7db8fe1197165507feb
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 388ceeb45bd18c7cb8f0766a96ebd4a54a9e76de
src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java 4092c760f2cc4eda410ac6125e58ec399d1a6ca4
src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 809fa4819eed61aee3fcee1b5641ec85b967d479
src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java 9cdf4d912a29e8a5341e4a9700fd07e1eeb015f3
src/java/test/org/apache/zookeeper/common/TimeTest.java PRE-CREATION
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 9abe47910f5d73195c57e9f33d9d2150a4861141
src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b50b4a4486b443daa6b3b92ac4ab5cf94cb
src/java/test/org/apache/zookeeper/test/ClientHammerTest.java b807dbb0f4350b29190b5d5862c418de84a168c5
src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 563c77c41c86c692edfd95ea48d397bc25154d26
src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ab84146f58e8f97ef24517703c30ef6015a71c84
src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java 0579858659cec892aee3fa4362d0c55d175d87a7
src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java bf1dcef7fbca91fee6128096e8413013fa11e0e0
src/java/test/org/apache/zookeeper/test/TestHammer.java 09a678b28c1915d419d586dfc6a523060b1df1aa
src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 5386a7a910686a44cbe33f5ac18674d92b6aad44
Diff: https://reviews.apache.org/r/30573/diff/
Testing
-------
Thanks,
Hongchao Deng