You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by Michael Moser <mo...@gmail.com> on 2018/07/24 21:13:09 UTC
unit test failures on master
Greetings NiFi dev:
I'm getting unit test failures trying to build the master branch.
[INFO]
------------------------------------------------------------------------
[INFO] Building nifi-runtime 1.8.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] --- maven-surefire-plugin:2.20.1:test (default-test) @ nifi-runtime
---
[INFO]
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.nifi.NiFiGroovyTest
[ERROR] Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
1.037 s <<< FAILURE! - in org.apache.nifi.NiFiGroovyTest
[ERROR]
testInitializePropertiesShouldSetBootstrapKeyFromFile(org.apache.nifi.NiFiGroovyTest)
Time elapsed: 0.121 s <<< ERROR!
java.lang.IllegalArgumentException: There was an issue decrypting protected
properties
at
org.apache.nifi.NiFiGroovyTest.testInitializePropertiesShouldSetBootstrapKeyFromFile(NiFiGroovyTest.groovy:166)
Caused by: org.apache.nifi.properties.SensitivePropertyProtectionException:
The key must be a valid hexadecimal key
at
org.apache.nifi.NiFiGroovyTest.testInitializePropertiesShouldSetBootstrapKeyFromFile(NiFiGroovyTest.groovy:166)
$ mvn -version
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T16:41:47+00:00)
Maven home: /opt/apache-maven-3.3.9
Java version: 1.8.0_144, vendor: Oracle Corporation
Java home: /opt/jdk1.8.0_144/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-1062-aws", arch: "amd64", family: "unix"
I believe this is related to NIFI-5341 which turned on the NiFiGroovyTest
in nifi-framework/nifi-runtime. That unit test tries to decrypt a
aes/gcm/256 protected value from nifi.propertes. My Oracle JDK does not
have Unlimited Strength JCE policy files installed. If I install the JCE
policy files, then the unit test passes.
Should we rework this unit test to use aes/gcm/128 crypto so that someone
without the JCE policy files can build and run unit tests?
Thanks,
-- Mike
Re: unit test failures on master
Posted by Michael Moser <mo...@gmail.com>.
Thanks Andy, I wrote NIFI-5451.
On Tue, Jul 24, 2018 at 5:22 PM Andy LoPresto <al...@apache.org> wrote:
> Mike,
>
> Please raise a Jira and I will take it (or I can raise it if you are
> unavailable). I believe Jeff Storck reactivated that test, and I verified
> and merged it. Both of us have JCE unlimited enabled on our machines. While
> the restriction is a legacy artifact of political decisions, we should
> still keep it in mind during PR reviews. Thanks for pointing this out.
>
>
> Andy LoPresto
> alopresto@apache.org
> *alopresto.apache@gmail.com <al...@gmail.com>*
> PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69
>
> On Jul 24, 2018, at 2:13 PM, Michael Moser <mo...@gmail.com> wrote:
>
> Greetings NiFi dev:
>
> I'm getting unit test failures trying to build the master branch.
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Building nifi-runtime 1.8.0-SNAPSHOT
> [INFO]
> ------------------------------------------------------------------------
> [INFO]
> [INFO] --- maven-surefire-plugin:2.20.1:test (default-test) @ nifi-runtime
> ---
> [INFO]
> [INFO] -------------------------------------------------------
> [INFO] T E S T S
> [INFO] -------------------------------------------------------
> [INFO] Running org.apache.nifi.NiFiGroovyTest
> [ERROR] Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 1.037 s <<< FAILURE! - in org.apache.nifi.NiFiGroovyTest
> [ERROR]
>
> testInitializePropertiesShouldSetBootstrapKeyFromFile(org.apache.nifi.NiFiGroovyTest)
> Time elapsed: 0.121 s <<< ERROR!
> java.lang.IllegalArgumentException: There was an issue decrypting protected
> properties
> at
>
> org.apache.nifi.NiFiGroovyTest.testInitializePropertiesShouldSetBootstrapKeyFromFile(NiFiGroovyTest.groovy:166)
> Caused by: org.apache.nifi.properties.SensitivePropertyProtectionException:
> The key must be a valid hexadecimal key
> at
>
> org.apache.nifi.NiFiGroovyTest.testInitializePropertiesShouldSetBootstrapKeyFromFile(NiFiGroovyTest.groovy:166)
>
> $ mvn -version
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T16:41:47+00:00)
> Maven home: /opt/apache-maven-3.3.9
> Java version: 1.8.0_144, vendor: Oracle Corporation
> Java home: /opt/jdk1.8.0_144/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-1062-aws", arch: "amd64", family: "unix"
>
> I believe this is related to NIFI-5341 which turned on the NiFiGroovyTest
> in nifi-framework/nifi-runtime. That unit test tries to decrypt a
> aes/gcm/256 protected value from nifi.propertes. My Oracle JDK does not
> have Unlimited Strength JCE policy files installed. If I install the JCE
> policy files, then the unit test passes.
>
> Should we rework this unit test to use aes/gcm/128 crypto so that someone
> without the JCE policy files can build and run unit tests?
>
> Thanks,
> -- Mike
>
>
>
Re: unit test failures on master
Posted by Andy LoPresto <al...@apache.org>.
Mike,
Please raise a Jira and I will take it (or I can raise it if you are unavailable). I believe Jeff Storck reactivated that test, and I verified and merged it. Both of us have JCE unlimited enabled on our machines. While the restriction is a legacy artifact of political decisions, we should still keep it in mind during PR reviews. Thanks for pointing this out.
Andy LoPresto
alopresto@apache.org
alopresto.apache@gmail.com
PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69
> On Jul 24, 2018, at 2:13 PM, Michael Moser <mo...@gmail.com> wrote:
>
> Greetings NiFi dev:
>
> I'm getting unit test failures trying to build the master branch.
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Building nifi-runtime 1.8.0-SNAPSHOT
> [INFO]
> ------------------------------------------------------------------------
> [INFO]
> [INFO] --- maven-surefire-plugin:2.20.1:test (default-test) @ nifi-runtime
> ---
> [INFO]
> [INFO] -------------------------------------------------------
> [INFO] T E S T S
> [INFO] -------------------------------------------------------
> [INFO] Running org.apache.nifi.NiFiGroovyTest
> [ERROR] Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 1.037 s <<< FAILURE! - in org.apache.nifi.NiFiGroovyTest
> [ERROR]
> testInitializePropertiesShouldSetBootstrapKeyFromFile(org.apache.nifi.NiFiGroovyTest)
> Time elapsed: 0.121 s <<< ERROR!
> java.lang.IllegalArgumentException: There was an issue decrypting protected
> properties
> at
> org.apache.nifi.NiFiGroovyTest.testInitializePropertiesShouldSetBootstrapKeyFromFile(NiFiGroovyTest.groovy:166)
> Caused by: org.apache.nifi.properties.SensitivePropertyProtectionException:
> The key must be a valid hexadecimal key
> at
> org.apache.nifi.NiFiGroovyTest.testInitializePropertiesShouldSetBootstrapKeyFromFile(NiFiGroovyTest.groovy:166)
>
> $ mvn -version
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T16:41:47+00:00)
> Maven home: /opt/apache-maven-3.3.9
> Java version: 1.8.0_144, vendor: Oracle Corporation
> Java home: /opt/jdk1.8.0_144/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-1062-aws", arch: "amd64", family: "unix"
>
> I believe this is related to NIFI-5341 which turned on the NiFiGroovyTest
> in nifi-framework/nifi-runtime. That unit test tries to decrypt a
> aes/gcm/256 protected value from nifi.propertes. My Oracle JDK does not
> have Unlimited Strength JCE policy files installed. If I install the JCE
> policy files, then the unit test passes.
>
> Should we rework this unit test to use aes/gcm/128 crypto so that someone
> without the JCE policy files can build and run unit tests?
>
> Thanks,
> -- Mike