You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Martin Koci (JIRA)" <ad...@incubator.apache.org> on 2006/09/25 15:25:50 UTC
[jira] Created: (ADFFACES-196) Allow using of compression (of
names) for user suplied CSS class names
Allow using of compression (of names) for user suplied CSS class names
----------------------------------------------------------------------
Key: ADFFACES-196
URL: http://issues.apache.org/jira/browse/ADFFACES-196
Project: MyFaces ADF-Faces
Issue Type: Bug
Reporter: Martin Koci
For now if user supplied CSS class names in styleClass attribute it works as following:
styleClass="styleClass1" - output in HTML is "x1n" (for example)
styleClass="styleClass1 styleClass2" - output is "styleClass1 styleClass2"
Problem is in FormInputRenderer.renderRootDomElementStyles - this method should split styleClass values and pass it in renderStyleClasses.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-196) Allow using of compression (of
names) for user suplied CSS class names
Posted by "Martin Koci (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-196?page=all ]
Martin Koci updated ADFFACES-196:
---------------------------------
Status: Patch Available (was: Open)
> Allow using of compression (of names) for user suplied CSS class names
> ----------------------------------------------------------------------
>
> Key: ADFFACES-196
> URL: http://issues.apache.org/jira/browse/ADFFACES-196
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Reporter: Martin Koci
>
> For now if user supplied CSS class names in styleClass attribute it works as following:
> styleClass="styleClass1" - output in HTML is "x1n" (for example)
> styleClass="styleClass1 styleClass2" - output is "styleClass1 styleClass2"
> Problem is in FormInputRenderer.renderRootDomElementStyles - this method should split styleClass values and pass it in renderStyleClasses.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-196) Allow using of compression (of
names) for user suplied CSS class names
Posted by "Martin Koci (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-196?page=all ]
Martin Koci updated ADFFACES-196:
---------------------------------
Attachment: FormInputRenderer.java.patch
A patch clarifies that problem
> Allow using of compression (of names) for user suplied CSS class names
> ----------------------------------------------------------------------
>
> Key: ADFFACES-196
> URL: http://issues.apache.org/jira/browse/ADFFACES-196
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Reporter: Martin Koci
> Attachments: FormInputRenderer.java.patch
>
>
> For now if user supplied CSS class names in styleClass attribute it works as following:
> styleClass="styleClass1" - output in HTML is "x1n" (for example)
> styleClass="styleClass1 styleClass2" - output is "styleClass1 styleClass2"
> Problem is in FormInputRenderer.renderRootDomElementStyles - this method should split styleClass values and pass it in renderStyleClasses.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-196) Allow using of compression (of
names) for user suplied CSS class names
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-196:
----------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> Allow using of compression (of names) for user suplied CSS class names
> ----------------------------------------------------------------------
>
> Key: ADFFACES-196
> URL: https://issues.apache.org/jira/browse/ADFFACES-196
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Affects Versions: 1.0.0-incubating-core
> Reporter: Martin Koci
> Assigned To: Adam Winer
> Fix For: 1.0.0-incubating-core
>
> Attachments: FormInputRenderer.java.patch
>
>
> For now if user supplied CSS class names in styleClass attribute it works as following:
> styleClass="styleClass1" - output in HTML is "x1n" (for example)
> styleClass="styleClass1 styleClass2" - output is "styleClass1 styleClass2"
> Problem is in FormInputRenderer.renderRootDomElementStyles - this method should split styleClass values and pass it in renderStyleClasses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-196) Allow using of compression (of
names) for user suplied CSS class names
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-196?page=all ]
Adam Winer updated ADFFACES-196:
--------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Assignee: Adam Winer
Fixed.
> Allow using of compression (of names) for user suplied CSS class names
> ----------------------------------------------------------------------
>
> Key: ADFFACES-196
> URL: http://issues.apache.org/jira/browse/ADFFACES-196
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Reporter: Martin Koci
> Assigned To: Adam Winer
> Attachments: FormInputRenderer.java.patch
>
>
> For now if user supplied CSS class names in styleClass attribute it works as following:
> styleClass="styleClass1" - output in HTML is "x1n" (for example)
> styleClass="styleClass1 styleClass2" - output is "styleClass1 styleClass2"
> Problem is in FormInputRenderer.renderRootDomElementStyles - this method should split styleClass values and pass it in renderStyleClasses.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-196) Allow using of compression (of
names) for user suplied CSS class names
Posted by "Martin Koci (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-196?page=comments#action_12439430 ]
Martin Koci commented on ADFFACES-196:
--------------------------------------
Problem is with matching
<element class="styleClass1">
<element class="styleClass2"/>
</element>.
Example:
jsp: <tr:inputText styleClass="styleClass1 styleClass2" />
In skin file is ' ' (space) not '.' (dot) between selectors:
.styleClass1 af|inputText::content {
....
}
Generated stylesheet:
.styleClass1 .af_inputText_content,.xch .x1m
Rendered html output:
<span class="styleClass1 styleClass2">
<input class="x1m" />
</span>
Selector will not match because styleClass1 is not compressed to 'xch'
> Allow using of compression (of names) for user suplied CSS class names
> ----------------------------------------------------------------------
>
> Key: ADFFACES-196
> URL: http://issues.apache.org/jira/browse/ADFFACES-196
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Reporter: Martin Koci
> Attachments: FormInputRenderer.java.patch
>
>
> For now if user supplied CSS class names in styleClass attribute it works as following:
> styleClass="styleClass1" - output in HTML is "x1n" (for example)
> styleClass="styleClass1 styleClass2" - output is "styleClass1 styleClass2"
> Problem is in FormInputRenderer.renderRootDomElementStyles - this method should split styleClass values and pass it in renderStyleClasses.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-196) Allow using of compression (of
names) for user suplied CSS class names
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-196?page=comments#action_12439350 ]
Jeanne Waldman commented on ADFFACES-196:
-----------------------------------------
What is the use case when a user puts more than one styleClass on the styleClass attribute and it doesn't work because it doesn't get compressed. In our generated css file we output both compressed and uncompressed styleclasses.
Here is a generic example of the problem:
<af:inputText styleClass="styleClass1 styleClass2" />
And in the skinning file:
af|inputText.styleClass1.styleClass2
We will generate this in the css:
.af_inputText.styleClass1.styleClass2, .x00.x01.x02 {some css properties}
And in the html we generate:
<span class="x00 styleClass1 styleClass2"><input...</span>
So, this can cause a problem, definitely, because we don't have .x00.styleClass1.styleClass2 in our generated css file. This is only a problem if both conditions are true:
1. The user added their own style classes to the skinning file
2. The user adds more than one style class name in the styleClass attribute.
Can you explain the exact use case that shows the problem you are having?
> Allow using of compression (of names) for user suplied CSS class names
> ----------------------------------------------------------------------
>
> Key: ADFFACES-196
> URL: http://issues.apache.org/jira/browse/ADFFACES-196
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Reporter: Martin Koci
> Attachments: FormInputRenderer.java.patch
>
>
> For now if user supplied CSS class names in styleClass attribute it works as following:
> styleClass="styleClass1" - output in HTML is "x1n" (for example)
> styleClass="styleClass1 styleClass2" - output is "styleClass1 styleClass2"
> Problem is in FormInputRenderer.renderRootDomElementStyles - this method should split styleClass values and pass it in renderStyleClasses.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-196) Allow using of compression (of
names) for user suplied CSS class names
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-196?page=comments#action_12437674 ]
Adam Winer commented on ADFFACES-196:
-------------------------------------
The overhead of running styleClass.split() on every request seems too much, esp. since the 99% case is when a user only specifies one styleclass. This should be optimized. (Also, the patch doesn't use Trinidad code style conventions).
> Allow using of compression (of names) for user suplied CSS class names
> ----------------------------------------------------------------------
>
> Key: ADFFACES-196
> URL: http://issues.apache.org/jira/browse/ADFFACES-196
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Reporter: Martin Koci
> Attachments: FormInputRenderer.java.patch
>
>
> For now if user supplied CSS class names in styleClass attribute it works as following:
> styleClass="styleClass1" - output in HTML is "x1n" (for example)
> styleClass="styleClass1 styleClass2" - output is "styleClass1 styleClass2"
> Problem is in FormInputRenderer.renderRootDomElementStyles - this method should split styleClass values and pass it in renderStyleClasses.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira