You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/09/02 09:34:55 UTC
[GitHub] [incubator-dolphinscheduler] 597365581 opened a new pull request #3648: fix #3645
597365581 opened a new pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648
fix get yarn applications status from yarn server,http code return 404, get yarn applications status cause NullPointerException
## *Tips*
- *Thanks very much for contributing to Apache DolphinScheduler.*
- *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds checkstyle plugin.)*
## Brief change log
*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] felix-thinkingdata commented on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
felix-thinkingdata commented on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-686226980
> > > > > Can you describe what happens when volatilization happens? There is a difference between getting a status return exception, such as 404, and a task running status failure.It's best to describe the situation in detail.
> > > >
> > > >
> > > > > 什么情况下会发生？还有就是获取状态404和获取运行状态是失败的还是有区别的。最好详细描述下情况。
> > >
> > >
> > > 1、yarn http request timeout。2、yarn url is incorrect 3、 two yarn cluster，yarn url config in disorder and so no...
>
> Does this erase any specific exception information in the log?
>
> 这样会抹去在日志中的具体的异常信息吗？
I see that the lower utility class prints a detailed exception.
我看到了，下层工具类会打印详细异常。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-685680189
> > > Can you describe what happens when volatilization happens? There is a difference between getting a status return exception, such as 404, and a task running status failure.It's best to describe the situation in detail.
> >
> >
> > > 什么情况下会发生？还有就是获取状态404和获取运行状态是失败的还是有区别的。最好详细描述下情况。
>
> 1、yarn http request timeout。2、yarn url is incorrect 3、 two yarn cluster，yarn url config in disorder and so no...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3648: [FIXBUG][common]fix yarn applications status cause NPE(#3645)
Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-686279208
please change the pr title to [FIXBUG][common]fix yarn applications status cause NPE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-686230012
> Optimized exceptions when getting information over YARN HTTP.
>
> 优化了，在通过yarn http获取信息时的异常情况。
>
> good job
ok，can merge？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] felix-thinkingdata commented on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
felix-thinkingdata commented on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-685673482
> Can you describe what happens when volatilization happens? There is a difference between getting a status return exception, such as 404, and a task running status failure.It's best to describe the situation in detail.
>
> 什么情况下会发生？还有就是获取状态404和获取运行状态是失败的还是有区别的。最好详细描述下情况。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] felix-thinkingdata commented on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
felix-thinkingdata commented on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-686883752
please change the pr title to [FIXBUG][common]fix yarn applications status cause NPE
按照要求改下标题。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] felix-thinkingdata edited a comment on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
felix-thinkingdata edited a comment on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-685663882
Can you describe what happens when volatilization happens? There is a difference between getting a status return exception, such as 404, and a task running status failure.
什么情况下会发生？还有就是获取状态404和获取运行状态是失败的还是有区别的。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3648: [FIXBUG][common]fix yarn applications status cause NPE(#3645)
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-686902295
@felix-thinkingdata ok, title has changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] felix-thinkingdata commented on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
felix-thinkingdata commented on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-685663882
Can you describe what happens when volatilization happens?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] felix-thinkingdata commented on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
felix-thinkingdata commented on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-686272771
> ok，can merge？
Wait for others to review.I have no authority to merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-685644302
fix get yarn applications status from yarn server,http code return 404, get yarn applications status cause NullPointerException
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] felix-thinkingdata commented on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
felix-thinkingdata commented on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-686226143
> > > > Can you describe what happens when volatilization happens? There is a difference between getting a status return exception, such as 404, and a task running status failure.It's best to describe the situation in detail.
> > >
> > >
> > > > 什么情况下会发生？还有就是获取状态404和获取运行状态是失败的还是有区别的。最好详细描述下情况。
> >
> >
> > 1、yarn http request timeout。2、yarn url is incorrect 3、 two yarn cluster，yarn url config in disorder and so no...
Does this erase any specific exception information in the log?
这样会抹去在日志中的具体的异常信息吗？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-685519507
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-685522064
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-685519507
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3648&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3648&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3648&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3648&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3648&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3648&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3648&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje
ct/issues?id=apache-dolphinscheduler&pullRequest=3648&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3648&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3648&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3648&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25.png' alt='33.3%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3648&metric=new_coverage&view=list) [33.3% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3648&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3648&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3648&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] 597365581 commented on pull request #3648: fix #3645
Posted by GitBox <gi...@apache.org>.
597365581 commented on pull request #3648:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3648#issuecomment-685678059
> > Can you describe what happens when volatilization happens? There is a difference between getting a status return exception, such as 404, and a task running status failure.It's best to describe the situation in detail.
>
> > 什么情况下会发生？还有就是获取状态404和获取运行状态是失败的还是有区别的。最好详细描述下情况。
1、yarn http request timeout。2、yarn url is incorrect and so no...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org