You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Canbin Zheng (Jira)" <ji...@apache.org> on 2020/04/09 11:22:00 UTC

[jira] [Comment Edited] (FLINK-17008) Handle null value for HADOOP_CONF_DIR/HADOOP_HOME env in AbstractKubernetesParameters#getLocalHadoopConfigurationDirectory

    [ https://issues.apache.org/jira/browse/FLINK-17008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17079209#comment-17079209 ] 

Canbin Zheng edited comment on FLINK-17008 at 4/9/20, 11:21 AM:
----------------------------------------------------------------

Hi, [~chesnay].

If both *{color:#172b4d}ENV_HADOOP_CONF_DIR{color}* and {color:#172b4d}*ENV_HADOOP_HOME* are unset, then the {{possibleHadoopConfPaths}} would contain two elements that it shouldn't have: {{null/etc/hadoop}} and {{null/conf}}, though it does not affect the functionality, users will see the warning log noise from {{HadoopConfMountDecorator}} saying that{color}
{quote}{color:#172b4d}Found 0 files in directory null/etc/hadoop, skip to mount the Hadoop Configuration ConfigMap.{color}
{quote}
{quote}{color:#172b4d}Found 0 files in directory null/etc/hadoop, skip to create the Hadoop Configuration ConfigMap.{color}
{quote}
{color:#172b4d}It's my mistake when introducing the {{HadoopConfMountDecorator}}, given that the incorrect warnings could confuse users, this ticket proposes to fix it.{color}


was (Author: felixzheng):
Hi, [~chesnay].

If both *{color:#172b4d}ENV_HADOOP_CONF_DIR{color}* and {color:#172b4d}*ENV_HADOOP_HOME* are unset, then the {{possibleHadoopConfPaths}} would contain two elements that it shouldn't have: {{null/etc/hadoop}} and {{null/conf}}, though it does not affect the functionality, users will see the warning log noise from {{HadoopConfMountDecorator}} saying that{color}
{quote}{color:#172b4d}Found 0 files in directory null/etc/hadoop, skip to mount the Hadoop Configuration ConfigMap.{color}{quote}
{quote}{color:#172b4d}Found 0 files in directory null/etc/hadoop, skip to create the Hadoop Configuration ConfigMap.{color}{quote}
{color:#172b4d}It's my mistake when writing the {{HadoopConfMountDecorator}}, given that the incorrect warnings could confuse users, this ticket proposes to fix it.{color}

> Handle null value for HADOOP_CONF_DIR/HADOOP_HOME env in AbstractKubernetesParameters#getLocalHadoopConfigurationDirectory
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-17008
>                 URL: https://issues.apache.org/jira/browse/FLINK-17008
>             Project: Flink
>          Issue Type: Bug
>          Components: Deployment / Kubernetes
>            Reporter: Canbin Zheng
>            Priority: Minor
>             Fix For: 1.11.0
>
>
> {{System.getenv(Constants.ENV_HADOOP_CONF_DIR)}} or {{System.getenv(Constants.HADOOP_HOME)}} could return null value if they are not set in the System environments, it's a minor improvement to take these situations into consideration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)