You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "lvca (via GitHub)" <gi...@apache.org> on 2023/05/16 09:59:51 UTC
[GitHub] [tinkerpop] lvca opened a new pull request, #2065: Added missing annotation in test
lvca opened a new pull request, #2065:
URL: https://github.com/apache/tinkerpop/pull/2065
I recently upgrade ArcadeDB to the latest 3.6.3, but there is a test that won't pass in `org.apache.tinkerpop.gremlin.process.traversal.step.map.CountTest`:
```java
@Override
public Traversal<Vertex, Long> get_g_VX1X_valuesXageX_countXlocalX() {
return g.V(1).values("age").count(Scope.local);
};
```
I think the following annotation was missing:
```java
@FeatureRequirement(featureClass = Graph.Features.VertexFeatures.class, feature = Graph.Features.VertexFeatures.FEATURE_USER_SUPPLIED_IDS)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #2065: Added missing annotation in test
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2065:
URL: https://github.com/apache/tinkerpop/pull/2065#issuecomment-1555179917
Fixed in 3.5-dev in https://github.com/apache/tinkerpop/commit/822f652916f15be311f2f7760e5722a37813e38c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #2065: Added missing annotation in test
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2065:
URL: https://github.com/apache/tinkerpop/pull/2065#issuecomment-1549870109
Thanks for fixing this, but it's better to make `id` a test parameter like in other tests: https://github.com/apache/tinkerpop/blob/0ecc91dd10c5e4595052e9c52c320ac0a3a2969f/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/OrderTest.java#L503 In this case the test will work without `@FeatureRequirement`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2065: Added missing annotation in test
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2065:
URL: https://github.com/apache/tinkerpop/pull/2065#issuecomment-1550397367
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2065?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2065](https://app.codecov.io/gh/apache/tinkerpop/pull/2065?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e7cf34c) into [master](https://app.codecov.io/gh/apache/tinkerpop/commit/0ecc91dd10c5e4595052e9c52c320ac0a3a2969f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0ecc91d) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2065 +/- ##
============================================
- Coverage 68.98% 68.97% -0.01%
- Complexity 9159 9160 +1
============================================
Files 855 855
Lines 41518 41518
Branches 5613 5613
============================================
- Hits 28640 28639 -1
- Misses 10894 10898 +4
+ Partials 1984 1981 -3
```
[see 8 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2065/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk closed pull request #2065: Added missing annotation in test
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk closed pull request #2065: Added missing annotation in test
URL: https://github.com/apache/tinkerpop/pull/2065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] lvca commented on pull request #2065: Added missing annotation in test
Posted by "lvca (via GitHub)" <gi...@apache.org>.
lvca commented on PR #2065:
URL: https://github.com/apache/tinkerpop/pull/2065#issuecomment-1550337917
@vkagamlyk ok for me. ETA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] lvca commented on pull request #2065: Added missing annotation in test
Posted by "lvca (via GitHub)" <gi...@apache.org>.
lvca commented on PR #2065:
URL: https://github.com/apache/tinkerpop/pull/2065#issuecomment-1555217933
Any ETA to cherry-pick it in 3.6.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] lvca commented on pull request #2065: Added missing annotation in test
Posted by "lvca (via GitHub)" <gi...@apache.org>.
lvca commented on PR #2065:
URL: https://github.com/apache/tinkerpop/pull/2065#issuecomment-1550346709
I've updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org