You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "hoslo (via GitHub)" <gi...@apache.org> on 2024/01/24 05:43:44 UTC
[PR] fix(seafile): test_list_dir_with_metakey [opendal]
hoslo opened a new pull request, #4063:
URL: https://github.com/apache/opendal/pull/4063
Part #3976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(seafile): test_list_dir_with_metakey [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #4063:
URL: https://github.com/apache/opendal/pull/4063#discussion_r1464394724
##########
core/src/services/seafile/writer.rs:
##########
@@ -71,10 +71,10 @@ impl oio::OneShotWrite for SeafileWriter {
.stream(bs.len() as u64, Box::new(bs));
let multipart = Multipart::new()
- .part(file_part)
.part(FormDataPart::new("parent_dir").content("/"))
.part(FormDataPart::new("relative_path").content(relative_path.clone()))
- .part(FormDataPart::new("replace").content("1"));
+ .part(FormDataPart::new("replace").content("1"))
+ .part(file_part);
Review Comment:
> sorry, what I can see is just position of code line changes, is there any difference which I missing after the change?
Some services requires the file part to be last one.
##########
core/src/services/seafile/writer.rs:
##########
@@ -71,10 +71,10 @@ impl oio::OneShotWrite for SeafileWriter {
.stream(bs.len() as u64, Box::new(bs));
let multipart = Multipart::new()
- .part(file_part)
.part(FormDataPart::new("parent_dir").content("/"))
.part(FormDataPart::new("relative_path").content(relative_path.clone()))
- .part(FormDataPart::new("replace").content("1"));
+ .part(FormDataPart::new("replace").content("1"))
+ .part(file_part);
Review Comment:
> sorry, what I can see is just position of code line changes, is there any difference which I missing after the change?
Some services require the file part to be last one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(seafile): test_list_dir_with_metakey [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #4063:
URL: https://github.com/apache/opendal/pull/4063#issuecomment-1907582532
Hi @hoslo, congratulations on becoming a committer! You can now submit PRs by creating a branch directly in the apache/opendal repository, which will allow all CI checks to run automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(seafile): test_list_dir_with_metakey [opendal]
Posted by "Young-Flash (via GitHub)" <gi...@apache.org>.
Young-Flash commented on code in PR #4063:
URL: https://github.com/apache/opendal/pull/4063#discussion_r1464352989
##########
core/src/services/seafile/writer.rs:
##########
@@ -71,10 +71,10 @@ impl oio::OneShotWrite for SeafileWriter {
.stream(bs.len() as u64, Box::new(bs));
let multipart = Multipart::new()
- .part(file_part)
.part(FormDataPart::new("parent_dir").content("/"))
.part(FormDataPart::new("relative_path").content(relative_path.clone()))
- .part(FormDataPart::new("replace").content("1"));
+ .part(FormDataPart::new("replace").content("1"))
+ .part(file_part);
Review Comment:
sorry, what I can see is just position of code line changes, is there any difference which I missing after the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(seafile): test_list_dir_with_metakey [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #4063:
URL: https://github.com/apache/opendal/pull/4063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org